From: Chunfeng Yun <chunfeng.yun@mediatek.com>
To: u-boot@lists.denx.de
Subject: [PATCH v3 9/9] usb: xhci: convert to readx_poll_sleep_timeout()
Date: Mon, 7 Sep 2020 15:12:07 +0800 [thread overview]
Message-ID: <1599462727-2188-9-git-send-email-chunfeng.yun@mediatek.com> (raw)
In-Reply-To: <1599462727-2188-1-git-send-email-chunfeng.yun@mediatek.com>
Use readx_poll_sleep_timeout() to poll the register status
Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
---
v3: no changes
v2: fix typo of title suggested by Frank
---
drivers/usb/host/xhci.c | 25 +++++++++++--------------
1 file changed, 11 insertions(+), 14 deletions(-)
diff --git a/drivers/usb/host/xhci.c b/drivers/usb/host/xhci.c
index fe30101..3547a9b 100644
--- a/drivers/usb/host/xhci.c
+++ b/drivers/usb/host/xhci.c
@@ -33,6 +33,7 @@
#include <linux/bug.h>
#include <linux/delay.h>
#include <linux/errno.h>
+#include <linux/iopoll.h>
#include <usb/xhci.h>
#ifndef CONFIG_USB_MAX_CONTROLLER_COUNT
@@ -143,23 +144,19 @@ struct xhci_ctrl *xhci_get_ctrl(struct usb_device *udev)
* @param usec time to wait till
* @return 0 if handshake is success else < 0 on failure
*/
-static int handshake(uint32_t volatile *ptr, uint32_t mask,
- uint32_t done, int usec)
+static int
+handshake(uint32_t volatile *ptr, uint32_t mask, uint32_t done, int usec)
{
uint32_t result;
+ int ret;
+
+ ret = readx_poll_sleep_timeout(xhci_readl, ptr, result,
+ (result & mask) == done || result == U32_MAX,
+ 1, usec);
+ if (result == U32_MAX) /* card removed */
+ return -ENODEV;
- do {
- result = xhci_readl(ptr);
- if (result == ~(uint32_t)0)
- return -ENODEV;
- result &= mask;
- if (result == done)
- return 0;
- usec--;
- udelay(1);
- } while (usec > 0);
-
- return -ETIMEDOUT;
+ return ret;
}
/**
--
1.9.1
next prev parent reply other threads:[~2020-09-07 7:12 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-07 7:11 [PATCH v3 1/9] usb: xhci: add a member hci_version in xhci_ctrl struct Chunfeng Yun
2020-09-07 7:12 ` [PATCH v3 2/9] usb: xhci: create one unified function to calculate TRB TD remainder Chunfeng Yun
2020-09-08 5:41 ` Bin Meng
2020-09-08 7:40 ` Chunfeng Yun
2020-09-07 7:12 ` [PATCH v3 3/9] usb: xhci: add quirks flag to support MediaTek xHCI 0.96 Chunfeng Yun
2020-09-07 7:12 ` [PATCH v3 4/9] usb: xhci: convert to HCS_MAX_PORTS() Chunfeng Yun
2020-09-07 7:12 ` [PATCH v3 5/9] usb: xhci: convert to TRB_TYPE() Chunfeng Yun
2020-09-07 7:12 ` [PATCH v3 6/9] usb: xhci: convert to TRB_LEN() and TRB_INTR_TARGET() Chunfeng Yun
2020-09-08 1:30 ` Bin Meng
2020-09-08 7:39 ` Chunfeng Yun
2020-09-07 7:12 ` [PATCH v3 7/9] usb: xhci: convert to TRB_TX_TYPE() Chunfeng Yun
2020-09-08 1:31 ` Bin Meng
2020-09-07 7:12 ` [PATCH v3 8/9] usb: xhci: use macros with parameter to fill ep_info2 Chunfeng Yun
2020-09-08 1:35 ` Bin Meng
2020-09-07 7:12 ` Chunfeng Yun [this message]
2020-09-08 1:44 ` [PATCH v3 9/9] usb: xhci: convert to readx_poll_sleep_timeout() Bin Meng
2020-09-08 11:13 ` Marek Vasut
2020-09-08 11:24 ` Chunfeng Yun
2020-09-08 15:45 ` Bin Meng
2020-09-08 16:15 ` Marek Vasut
2020-09-08 16:34 ` Frank Wunderlich
2020-09-08 16:47 ` Marek Vasut
2020-09-08 17:14 ` Frank Wunderlich
2020-09-08 17:30 ` Marek Vasut
2020-09-09 1:55 ` Bin Meng
2020-09-09 10:00 ` Marek Vasut
2020-09-09 13:46 ` Bin Meng
2020-09-09 14:02 ` Marek Vasut
2020-09-09 14:05 ` Bin Meng
2020-09-09 14:16 ` Tom Rini
2020-09-09 14:16 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1599462727-2188-9-git-send-email-chunfeng.yun@mediatek.com \
--to=chunfeng.yun@mediatek.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox