public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [PATCH v3 9/9] usb: xhci: convert to readx_poll_sleep_timeout()
Date: Wed, 9 Sep 2020 10:16:29 -0400	[thread overview]
Message-ID: <20200909141629.GP7259@bill-the-cat> (raw)
In-Reply-To: <CAEUhbmV3n1kwpcDPTC=+d5Xw=tmH=c9Aq1e5Yb5i0NP3nLr69w@mail.gmail.com>

On Wed, Sep 09, 2020 at 10:05:42PM +0800, Bin Meng wrote:
> On Wed, Sep 9, 2020 at 10:02 PM Marek Vasut <marex@denx.de> wrote:
> >
> > On 9/9/20 3:46 PM, Bin Meng wrote:
> > > On Wed, Sep 9, 2020 at 7:05 PM Marek Vasut <marex@denx.de> wrote:
> > >>
> > >> On 9/9/20 3:55 AM, Bin Meng wrote:
> > >>> Hi Marek,
> > >>
> > >> Hi,
> > >>
> > >>> On Wed, Sep 9, 2020 at 12:15 AM Marek Vasut <marex@denx.de> wrote:
> > >>>>
> > >>>> On 9/8/20 5:45 PM, Bin Meng wrote:
> > >>>>> Hi Marek,
> > >>>>
> > >>>> Hi,
> > >>>>
> > >>>>> On Tue, Sep 8, 2020 at 7:13 PM Marek Vasut <marex@denx.de> wrote:
> > >>>>>>
> > >>>>>> On 9/8/20 3:44 AM, Bin Meng wrote:
> > >>>>>>> On Mon, Sep 7, 2020 at 3:14 PM Chunfeng Yun <chunfeng.yun@mediatek.com> wrote:
> > >>>>>>>>
> > >>>>>>>> Use readx_poll_sleep_timeout() to poll the register status
> > >>>>>>>>
> > >>>>>>>> Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
> > >>>>>>>> ---
> > >>>>>>>> v3: no changes
> > >>>>>>>>
> > >>>>>>>> v2: fix typo of title suggested by Frank
> > >>>>>>>> ---
> > >>>>>>>>  drivers/usb/host/xhci.c | 25 +++++++++++--------------
> > >>>>>>>>  1 file changed, 11 insertions(+), 14 deletions(-)
> > >>>>>>>>
> > >>>>>>>
> > >>>>>>> Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
> > >>>>>>
> > >>>>>> Thanks. So now I have half of a RESEND patchset with RB tags, and
> > >>>>>> another half of just RB tags without patchset. Can someone of you please
> > >>>>>> collect the tags and resend the patchset once more with the collected
> > >>>>>> tags, so it's all in one place ?
> > >>>>>>
> > >>>>>
> > >>>>> I believe the latest version has all the RB tags.
> > >>>>
> > >>>> Thank you, I cannot apply a patchset which only has "Re:" in my mailbox,
> > >>>> because the original patches are just not there.
> > >>>
> > >>> You can use patchwork to help the custodian work. I found it very
> > >>> helpful to download the patches from patchwork and apply.
> > >>
> > >> Can you also comment on patches via patchwork ?
> > >>
> > >> I mean, really, can we please just stick to the usual workflow ? That's
> > >> all I am asking for , nothing else, nothing new.
> > >
> > > I don't understand the question about "usual workflow". You asked "I
> > > cannot apply a patchset which only has "Re:" in my mailbox" and I
> > > recommended patchwork which will satisfy the requirement of what you
> > > asked.
> >
> > Right, I can, but if there is more I want to say about the patch, I
> > cannot do it with patchwork. Then I need the patch, which I don't have.
> > Hence my remark about the usual email-based workflow.
> 
> Yes, that's true. If we need to post comments about patches, we will
> have to use email.

Which, to close the loop, is trivial with patchwork, if you're making a
new comment, and hard if you are trying to join an ongoing conversation.

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200909/dc079d0c/attachment.sig>

  reply	other threads:[~2020-09-09 14:16 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-07  7:11 [PATCH v3 1/9] usb: xhci: add a member hci_version in xhci_ctrl struct Chunfeng Yun
2020-09-07  7:12 ` [PATCH v3 2/9] usb: xhci: create one unified function to calculate TRB TD remainder Chunfeng Yun
2020-09-08  5:41   ` Bin Meng
2020-09-08  7:40     ` Chunfeng Yun
2020-09-07  7:12 ` [PATCH v3 3/9] usb: xhci: add quirks flag to support MediaTek xHCI 0.96 Chunfeng Yun
2020-09-07  7:12 ` [PATCH v3 4/9] usb: xhci: convert to HCS_MAX_PORTS() Chunfeng Yun
2020-09-07  7:12 ` [PATCH v3 5/9] usb: xhci: convert to TRB_TYPE() Chunfeng Yun
2020-09-07  7:12 ` [PATCH v3 6/9] usb: xhci: convert to TRB_LEN() and TRB_INTR_TARGET() Chunfeng Yun
2020-09-08  1:30   ` Bin Meng
2020-09-08  7:39     ` Chunfeng Yun
2020-09-07  7:12 ` [PATCH v3 7/9] usb: xhci: convert to TRB_TX_TYPE() Chunfeng Yun
2020-09-08  1:31   ` Bin Meng
2020-09-07  7:12 ` [PATCH v3 8/9] usb: xhci: use macros with parameter to fill ep_info2 Chunfeng Yun
2020-09-08  1:35   ` Bin Meng
2020-09-07  7:12 ` [PATCH v3 9/9] usb: xhci: convert to readx_poll_sleep_timeout() Chunfeng Yun
2020-09-08  1:44   ` Bin Meng
2020-09-08 11:13     ` Marek Vasut
2020-09-08 11:24       ` Chunfeng Yun
2020-09-08 15:45       ` Bin Meng
2020-09-08 16:15         ` Marek Vasut
2020-09-08 16:34           ` Frank Wunderlich
2020-09-08 16:47             ` Marek Vasut
2020-09-08 17:14               ` Frank Wunderlich
2020-09-08 17:30                 ` Marek Vasut
2020-09-09  1:55           ` Bin Meng
2020-09-09 10:00             ` Marek Vasut
2020-09-09 13:46               ` Bin Meng
2020-09-09 14:02                 ` Marek Vasut
2020-09-09 14:05                   ` Bin Meng
2020-09-09 14:16                     ` Tom Rini [this message]
2020-09-09 14:16                     ` Marek Vasut

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200909141629.GP7259@bill-the-cat \
    --to=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox