[U-Boot] bf537-stamp board compilation problem

[U-Boot] bf537-stamp board compilation problem

[Michael Zaidman]

Hi,
Compiling the bf537-stamp board I got the following linker error:
/home/mike/develop/u-boot/u-boot-patch/common/cmd_mmc.c:53: undefined
reference to `mmc_legacy_init'
/home/mike/develop/u-boot/u-boot-patch/common/cmd_mmc.c:53: relocation
truncated to fit: R_pcrel24 against undefined symbol `mmc_legacy_init'
disk/libdisk.a(part.o):(.rodata.block_drvr+0x4): undefined reference
to `mmc_get_dev'
make: *** [u-boot] Error 1

While another blackfin board bf548-ezkit passes the compilation. The
only difference that makes sense to me is CONFIG_GENERIC_MMC that
presents in the bf548-ezkit.h and absents in the bf537-stamp.h

I am trying to cleanup POST issues and have no idea what MMC config
should be in blackfin particular board.
Am I observing a real problem or just missing something?

Thanks,
Michael

[U-Boot] bf537-stamp board compilation problem

[Mike Frysinger]

On Friday 23 April 2010 10:10:16 Michael Zaidman wrote:
> Compiling the bf537-stamp board I got the following linker error:
> /home/mike/develop/u-boot/u-boot-patch/common/cmd_mmc.c:53: undefined
> reference to `mmc_legacy_init'
> /home/mike/develop/u-boot/u-boot-patch/common/cmd_mmc.c:53: relocation
> truncated to fit: R_pcrel24 against undefined symbol `mmc_legacy_init'
> disk/libdisk.a(part.o):(.rodata.block_drvr+0x4): undefined reference
> to `mmc_get_dev'
> make: *** [u-boot] Error 1

remove CONFIG_{MMC,SPI_MMC} from the bf537-stamp.h config header
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20100423/f52810fc/attachment.pgp 

[U-Boot] bf537-stamp board compilation problem

[Michael Zaidman]

On Fri, Apr 23, 2010 at 5:56 PM, Mike Frysinger <vapier@gentoo.org> wrote:
> On Friday 23 April 2010 10:10:16 Michael Zaidman wrote:
>> Compiling the bf537-stamp board I got the following linker error:
>> /home/mike/develop/u-boot/u-boot-patch/common/cmd_mmc.c:53: undefined
>> reference to `mmc_legacy_init'
>> /home/mike/develop/u-boot/u-boot-patch/common/cmd_mmc.c:53: relocation
>> truncated to fit: R_pcrel24 against undefined symbol `mmc_legacy_init'
>> disk/libdisk.a(part.o):(.rodata.block_drvr+0x4): undefined reference
>> to `mmc_get_dev'
>> make: *** [u-boot] Error 1
>
> remove CONFIG_{MMC,SPI_MMC} from the bf537-stamp.h config header
> -mike
>
Ok, thanks, I just added CONFIG_GENERIC_MMC with the same effect :-)

BTW, looking on the blackfin POST implementation I wonder if it was
used recently. Enabling POST on the bf537-stamp board caused the
post_list array of post/tests.c to be linked instead of
arch/blackfin/cpu/lib/tests.c as was expected...

Thanks,
Michael

[U-Boot] bf537-stamp board compilation problem

[Mike Frysinger]

On Friday 23 April 2010 11:21:28 Michael Zaidman wrote:
> BTW, looking on the blackfin POST implementation I wonder if it was
> used recently. Enabling POST on the bf537-stamp board caused the
> post_list array of post/tests.c to be linked instead of
> arch/blackfin/cpu/lib/tests.c as was expected...

because the post/ dir has historically been ppc-only (literally sprinkled with 
code that would not compile for any other arch), we were filtering post/ out 
in the top level Makefile for Blackfin targets.
ifneq ($(ARCH),blackfin)
LIBS += post/libpost.a
endif
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20100423/6807d179/attachment.pgp 

[U-Boot] bf537-stamp board compilation problem

[Michael Zaidman]

On Fri, Apr 23, 2010 at 6:37 PM, Mike Frysinger <vapier@gentoo.org> wrote:
> On Friday 23 April 2010 11:21:28 Michael Zaidman wrote:
>> BTW, looking on the blackfin POST implementation I wonder if it was
>> used recently. Enabling POST on the bf537-stamp board caused the
>> post_list array of post/tests.c to be linked instead of
>> arch/blackfin/cpu/lib/tests.c as was expected...
>
> because the post/ dir has historically been ppc-only (literally sprinkled with
> code that would not compile for any other arch), we were filtering post/ out
> in the top level Makefile for Blackfin targets.
> ifneq ($(ARCH),blackfin)
> LIBS += post/libpost.a
> endif
> -mike
>
Ok, I am going to send the patches that bring the blackfin POST into
the main stream...
Will you fix the CONFIG_{MMC,SPI_MMC} in the bf537-stamp.h header by
yourself or you want me to do it it this patch set?

[U-Boot] bf537-stamp board compilation problem

[Mike Frysinger]

On Friday 23 April 2010 12:31:21 Michael Zaidman wrote:
> Will you fix the CONFIG_{MMC,SPI_MMC} in the bf537-stamp.h header by
> yourself or you want me to do it it this patch set?

i'll take care of it
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20100423/d3b3b2f8/attachment.pgp 

[U-Boot] bf537-stamp board compilation problem

[Wolfgang Denk]

Dear Mike Frysinger,

In message <201004231137.16732.vapier@gentoo.org> you wrote:
>
> because the post/ dir has historically been ppc-only (literally sprinkled with 
> code that would not compile for any other arch), we were filtering post/ out 
> in the top level Makefile for Blackfin targets.
> ifneq ($(ARCH),blackfin)
> LIBS += post/libpost.a
> endif

I'd rather have seen fixes for any such problems.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"In matters of principle, stand like a rock;  in  matters  of  taste,
swim with the current."                            - Thomas Jefferson

[U-Boot] bf537-stamp board compilation problem

[Mike Frysinger]

On Friday 23 April 2010 15:30:09 Wolfgang Denk wrote:
> Mike Frysinger wrote:
> > because the post/ dir has historically been ppc-only (literally sprinkled
> > with code that would not compile for any other arch), we were filtering
> > post/ out in the top level Makefile for Blackfin targets.
> > ifneq ($(ARCH),blackfin)
> > LIBS += post/libpost.a
> > endif
> 
> I'd rather have seen fixes for any such problems.

like i already said, we had plans to de-suckify post/, but never got around to 
it.  what you're asking for isnt trivial, nor were we seeing the demand for 
it.  i could just as easily say "i'd rather the code didnt assume powerpc 
everywhere", but it isnt like that gets us from point a to point b.
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20100423/78a210e1/attachment.pgp 

[U-Boot] bf537-stamp board compilation problem

[Wolfgang Denk]

Dear Mike Frysinger,

In message <201004231533.58136.vapier@gentoo.org> you wrote:
>
> it.  i could just as easily say "i'd rather the code didnt assume powerpc 
> everywhere", but it isnt like that gets us from point a to point b.

I would have preferred an architecture neutral implementation as well,
but you know how it works: you start with just one specific processor
in mind, then another CPU of the same architecture gets added, and
when you try to add support for another architecture some rework and
cleanup is needed.  Same story here: first came MPC823E, then PPC440EX.
Both happened to be PPC...

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"The more data I punch in this card,  the lighter it becomes, and the
lower the mailing cost."
                     - Stan Kelly-Bootle, "The Devil's DP Dictionary"

[U-Boot] bf537-stamp board compilation problem

[Michael Zaidman]

On Fri, Apr 23, 2010 at 10:30 PM, Wolfgang Denk <wd@denx.de> wrote:
> Dear Mike Frysinger,
>
> In message <201004231137.16732.vapier@gentoo.org> you wrote:
>>
>> because the post/ dir has historically been ppc-only (literally sprinkled with
>> code that would not compile for any other arch), we were filtering post/ out
>> in the top level Makefile for Blackfin targets.
>> ifneq ($(ARCH),blackfin)
>> LIBS += post/libpost.a
>> endif
>
> I'd rather have seen fixes for any such problems.
>
> Best regards,
>
> Wolfgang Denk

The http://lists.denx.de/pipermail/u-boot/2010-April/070561.html patch
addresses also this problem.

Regards,
Michael