public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
* [U-Boot] [PATCH 1/1] m68k/lib: fix serial driver relocation
@ 2012-11-23 22:23 Angelo Dureghello
  2013-01-11 14:45 ` Jens Scharsig
  0 siblings, 1 reply; 3+ messages in thread
From: Angelo Dureghello @ 2012-11-23 22:23 UTC (permalink / raw)
  To: u-boot

Fix coldfire serial driver bindings no more relocated to ram after last
changes to drivers/serial/serial.c (regression).
Serial initialization in ram has to be called after that gd->reloc_off is
calculated.

Signed-off-by: Angelo Dureghello <sysamfw@gmail.com>
Cc: Jason Jin <jason.jin@freescale.com>
---
diff --git a/arch/m68k/lib/board.c b/arch/m68k/lib/board.c
index 02d73fd..373570c 100644
--- a/arch/m68k/lib/board.c
+++ b/arch/m68k/lib/board.c
@@ -402,14 +402,14 @@ void board_init_r (gd_t *id, ulong dest_addr)

        gd->flags |= GD_FLG_RELOC;      /* tell others: relocation done */

-       serial_initialize();
-
        debug ("Now running in RAM - U-Boot at: %08lx\n", dest_addr);

        WATCHDOG_RESET ();

        gd->reloc_off =  dest_addr - CONFIG_SYS_MONITOR_BASE;

+	serial_initialize();
+
        monitor_flash_len = (ulong)&__init_end - dest_addr;

 #if defined(CONFIG_NEEDS_MANUAL_RELOC)

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [U-Boot] [PATCH 1/1] m68k/lib: fix serial driver relocation
  2012-11-23 22:23 [U-Boot] [PATCH 1/1] m68k/lib: fix serial driver relocation Angelo Dureghello
@ 2013-01-11 14:45 ` Jens Scharsig
  2013-01-11 23:45   ` Tom Rini
  0 siblings, 1 reply; 3+ messages in thread
From: Jens Scharsig @ 2013-01-11 14:45 UTC (permalink / raw)
  To: u-boot

Am 2012-11-23 23:23, schrieb Angelo Dureghello:
> Fix coldfire serial driver bindings no more relocated to ram after last
> changes to drivers/serial/serial.c (regression).
> Serial initialization in ram has to be called after that gd->reloc_off is
> calculated.
> 
> Signed-off-by: Angelo Dureghello <sysamfw@gmail.com>
> Cc: Jason Jin <jason.jin@freescale.com>
> ---
> diff --git a/arch/m68k/lib/board.c b/arch/m68k/lib/board.c
> index 02d73fd..373570c 100644
> --- a/arch/m68k/lib/board.c
> +++ b/arch/m68k/lib/board.c
> @@ -402,14 +402,14 @@ void board_init_r (gd_t *id, ulong dest_addr)
> 
>         gd->flags |= GD_FLG_RELOC;      /* tell others: relocation done */
> 
> -       serial_initialize();
> -
>         debug ("Now running in RAM - U-Boot at: %08lx\n", dest_addr);
> 
>         WATCHDOG_RESET ();
> 
>         gd->reloc_off =  dest_addr - CONFIG_SYS_MONITOR_BASE;
> 
> +	serial_initialize();
> +
>         monitor_flash_len = (ulong)&__init_end - dest_addr;
> 
>  #if defined(CONFIG_NEEDS_MANUAL_RELOC)
> 

Acked-by: Jens Scharsig (BuS Elektronik) <esw@bus-elektronik.de>
Tested-by: Jens Scharsig (BuS Elektronik) <esw@bus-elektronik.de>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [U-Boot] [PATCH 1/1] m68k/lib: fix serial driver relocation
  2013-01-11 14:45 ` Jens Scharsig
@ 2013-01-11 23:45   ` Tom Rini
  0 siblings, 0 replies; 3+ messages in thread
From: Tom Rini @ 2013-01-11 23:45 UTC (permalink / raw)
  To: u-boot

On Fri, Jan 11, 2013 at 03:45:26PM +0100, Jens Scharsig wrote:
> Am 2012-11-23 23:23, schrieb Angelo Dureghello:
> > Fix coldfire serial driver bindings no more relocated to ram after last
> > changes to drivers/serial/serial.c (regression).
> > Serial initialization in ram has to be called after that gd->reloc_off is
> > calculated.
> > 
> > Signed-off-by: Angelo Dureghello <sysamfw@gmail.com>
> > Cc: Jason Jin <jason.jin@freescale.com>
> > ---
> > diff --git a/arch/m68k/lib/board.c b/arch/m68k/lib/board.c
> > index 02d73fd..373570c 100644
> > --- a/arch/m68k/lib/board.c
> > +++ b/arch/m68k/lib/board.c
> > @@ -402,14 +402,14 @@ void board_init_r (gd_t *id, ulong dest_addr)
> > 
> >         gd->flags |= GD_FLG_RELOC;      /* tell others: relocation done */
> > 
> > -       serial_initialize();
> > -
> >         debug ("Now running in RAM - U-Boot at: %08lx\n", dest_addr);
> > 
> >         WATCHDOG_RESET ();
> > 
> >         gd->reloc_off =  dest_addr - CONFIG_SYS_MONITOR_BASE;
> > 
> > +	serial_initialize();
> > +
> >         monitor_flash_len = (ulong)&__init_end - dest_addr;
> > 
> >  #if defined(CONFIG_NEEDS_MANUAL_RELOC)
> > 
> 
> Acked-by: Jens Scharsig (BuS Elektronik) <esw@bus-elektronik.de>
> Tested-by: Jens Scharsig (BuS Elektronik) <esw@bus-elektronik.de>

Applied to u-boot/master, thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20130111/4ff958be/attachment.pgp>

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2013-01-11 23:45 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-11-23 22:23 [U-Boot] [PATCH 1/1] m68k/lib: fix serial driver relocation Angelo Dureghello
2013-01-11 14:45 ` Jens Scharsig
2013-01-11 23:45   ` Tom Rini

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox