From: Tom Rini <trini@ti.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/2] pcm051: Add support for Phytec phyCORE-AM335x
Date: Thu, 10 Jan 2013 08:14:04 -0700 [thread overview]
Message-ID: <20130110151404.GA12136@bill-the-cat> (raw)
In-Reply-To: <0E39AF7C-22FB-47F7-8639-6FD4CDAD6C43@lemonage.de>
On Thu, Jan 10, 2013 at 08:30:09AM +0100, Lars Poeschel wrote:
> Hi Wolfgang, hi Tom,
>
> as I almost have the changes requested by Wolfgang in place, you two can choose, which version I should resubmit. ;)
>
> Am 09.01.2013 um 20:34 schrieb Tom Rini:
[snip]
> >>> + if (!eth_getenv_enetaddr("ethaddr", mac_addr)) {
> >>> + debug("<ethaddr> not set. Reading from E-fuse\n");
> >>
> >> This should be a printf(). Any such automatic changes are always
> >> worth to be told explicitly.
> >
> > This is the normal case of asking the hardware what MAC it shipped with.
> > Why do we want to tell the user the expected has happened?
>
> Here I'd prefer the printf variant, because for a common user it is not obivous, that it is reading the MAC from efuse. So this message is helpful.
OK, please also patch board/ti/am335x/board.c to also printf here then.
Other than that, yes, I'd be happy to see you make the other changes you
said. Just partially trying to help explain the SoC to Wolfgang :)
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20130110/003c1cbc/attachment.pgp>
prev parent reply other threads:[~2013-01-10 15:14 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-08 16:52 [U-Boot] [PATCH 1/2] am33xx: add a pulldown macro to pinmux config Lars Poeschel
2013-01-08 16:52 ` [U-Boot] [PATCH 2/2] pcm051: Add support for Phytec phyCORE-AM335x Lars Poeschel
2013-01-08 18:58 ` Wolfgang Denk
2013-01-09 14:23 ` Lars Poeschel
2013-01-09 19:34 ` Tom Rini
2013-01-10 7:30 ` Lars Poeschel
2013-01-10 15:14 ` Tom Rini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130110151404.GA12136@bill-the-cat \
--to=trini@ti.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox