U-Boot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] EXT4: Fix number base handling of "ext4write" command
Date: Fri, 31 Jan 2014 10:45:03 +0100	[thread overview]
Message-ID: <20140131094503.767FF38095D@gemini.denx.de> (raw)
In-Reply-To: <20140131102755.63297928@amdc2363>

Dear Lukasz,

In message <20140131102755.63297928@amdc2363> you wrote:
> 
> > 	ext4write mmc 0:2 ${addr} ${filename} ${filesize}
> > 
> > Change this to use the standard notation of base 16 input format.
> > See also commit b770e88
> > 
> > WARNING: this is a change to the user interface!!
> 
> In other words you are breaking API :-) - but this change is more than
> welcome and you have got enough power to do it :-).

Yes, I'm breaking the current (incorrectly implemented) ABI to fix it
and make it consistend with other use (for example, "fatwrite").  As
is, it can only be used from the command line, but not from any
scripts that refer for example to ${filesize}.

> My only comment is to add proper description to the ext4write commend 
> description. Now it only says:
> 
> "<interface> <dev[:part]> <addr> <absolute filename path> [sizebytes]\n"
> 
> and I think, that we could come up with [sizebytes - HEX] or something
> similar.

I do not see any such need.  Hex input base is the established and
documented default - ext4write is not a special command, so why should
we mention this here when we do not mention it anywhere else?

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Advice is seldom welcome; and those who want it the most always like
it the least.                         -- Philip Earl of Chesterfield

  reply	other threads:[~2014-01-31  9:45 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-31  8:28 [U-Boot] [PATCH] EXT4: Fix number base handling of "ext4write" command Wolfgang Denk
2014-01-31  9:27 ` Lukasz Majewski
2014-01-31  9:45   ` Wolfgang Denk [this message]
2014-01-31 10:08     ` Lukasz Majewski
2014-01-31 11:26       ` Wolfgang Denk
2014-02-19 15:49 ` [U-Boot] " Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140131094503.767FF38095D@gemini.denx.de \
    --to=wd@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox