From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v7 1/6] spi: cadence_qspi: move trigger base configuration in init
Date: Fri, 25 Sep 2015 00:32:24 +0200 [thread overview]
Message-ID: <20150924223224.608B5380905@gemini.denx.de> (raw)
In-Reply-To: <CAD6G_RSZAK7u=_ArT8SgqMvrdQ6ULi9szmxhF++kAEw-gv4Erw@mail.gmail.com>
Dear Jagan,
In message <CAD6G_RSZAK7u=_ArT8SgqMvrdQ6ULi9szmxhF++kAEw-gv4Erw@mail.gmail.com> you wrote:
>
> What if we move Vikas changes now for this release as he stated in
> previous mail "about sending patches later".
Well, we've been there too many times before. In to many cases, the
"later" just did not happen.
> My idea is someone is trying to clean it up existing code then give
> him a chance to move his code as well because he sent couple times.
Well, I think it would be better to clean up first, instead of just
reshuffeling the crappy code.
Also, I would like to hear a comment about comparing the efforts (and
benefits) of cleaning up this stuff versus doing a clean port of the
Linux version of that driver.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Eureka! -- Archimedes
next prev parent reply other threads:[~2015-09-24 22:32 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-24 0:19 [U-Boot] [PATCH v7 0/6] spi: cadence_qspi: optimize & fix indirect rd-writes Vikas Manocha
2015-09-24 0:19 ` [U-Boot] [PATCH v7 1/6] spi: cadence_qspi: move trigger base configuration in init Vikas Manocha
2015-09-24 7:22 ` Wolfgang Denk
2015-09-24 18:12 ` Vikas MANOCHA
2015-09-24 18:56 ` Wolfgang Denk
2015-09-24 19:39 ` Jagan Teki
2015-09-24 22:32 ` Wolfgang Denk [this message]
2015-09-25 23:25 ` Vikas MANOCHA
2015-09-24 0:19 ` [U-Boot] [PATCH v7 2/6] spi: cadence_qspi: fix indirect read/write start address Vikas Manocha
2015-09-24 7:18 ` Wolfgang Denk
2015-09-24 0:19 ` [U-Boot] [PATCH v7 3/6] spi: cadence_qspi: fix base trigger address & transfer " Vikas Manocha
2015-09-24 7:24 ` Wolfgang Denk
2015-09-24 7:49 ` Wolfgang Denk
2015-09-24 0:19 ` [U-Boot] [PATCH v7 4/6] spi: cadence_qspi: rename ahbbase to flashbase for clarity Vikas Manocha
2015-09-24 0:19 ` [U-Boot] [PATCH v7 5/6] spi: cadence_qspi: remove unused macro Vikas Manocha
2015-09-24 0:19 ` [U-Boot] [PATCH v7 6/6] spi: cadence_qspi: get fifo width from device tree Vikas Manocha
2015-09-24 7:34 ` Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150924223224.608B5380905@gemini.denx.de \
--to=wd@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox