public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v7 1/6] spi: cadence_qspi: move trigger base configuration in init
Date: Thu, 24 Sep 2015 09:22:03 +0200	[thread overview]
Message-ID: <20150924072203.81D11380DF2@gemini.denx.de> (raw)
In-Reply-To: <1443053976-9112-2-git-send-email-vikas.manocha@st.com>

Dear Vikas,

In message <1443053976-9112-2-git-send-email-vikas.manocha@st.com> you wrote:
> No need to configure indirect trigger address for every read/write.
...
>  	/* Indirect mode configurations */
>  	writel((plat->sram_size/2), plat->regbase + CQSPI_REG_SRAMPARTITION);
> +	writel((u32)plat->ahbbase & CQSPI_INDIRECTTRIGGER_ADDR_MASK,
> +	       plat->regbase + CQSPI_REG_INDIRECTTRIGGER);

I did not mention this explicitly, so I do it here:

Please fix this type cast issue globally, in all your patches.
Thanks.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"Marriage is like a cage; one sees the birds outside desperate to get
in, and those inside desperate to get out."               - Montaigne

  reply	other threads:[~2015-09-24  7:22 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-24  0:19 [U-Boot] [PATCH v7 0/6] spi: cadence_qspi: optimize & fix indirect rd-writes Vikas Manocha
2015-09-24  0:19 ` [U-Boot] [PATCH v7 1/6] spi: cadence_qspi: move trigger base configuration in init Vikas Manocha
2015-09-24  7:22   ` Wolfgang Denk [this message]
2015-09-24 18:12     ` Vikas MANOCHA
2015-09-24 18:56       ` Wolfgang Denk
2015-09-24 19:39         ` Jagan Teki
2015-09-24 22:32           ` Wolfgang Denk
2015-09-25 23:25             ` Vikas MANOCHA
2015-09-24  0:19 ` [U-Boot] [PATCH v7 2/6] spi: cadence_qspi: fix indirect read/write start address Vikas Manocha
2015-09-24  7:18   ` Wolfgang Denk
2015-09-24  0:19 ` [U-Boot] [PATCH v7 3/6] spi: cadence_qspi: fix base trigger address & transfer " Vikas Manocha
2015-09-24  7:24   ` Wolfgang Denk
2015-09-24  7:49   ` Wolfgang Denk
2015-09-24  0:19 ` [U-Boot] [PATCH v7 4/6] spi: cadence_qspi: rename ahbbase to flashbase for clarity Vikas Manocha
2015-09-24  0:19 ` [U-Boot] [PATCH v7 5/6] spi: cadence_qspi: remove unused macro Vikas Manocha
2015-09-24  0:19 ` [U-Boot] [PATCH v7 6/6] spi: cadence_qspi: get fifo width from device tree Vikas Manocha
2015-09-24  7:34   ` Wolfgang Denk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150924072203.81D11380DF2@gemini.denx.de \
    --to=wd@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox