public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 3/4] net: cpsw: Add support to drive gpios for ethernet to be functional
Date: Tue, 26 Jul 2016 08:56:05 +0200	[thread overview]
Message-ID: <20160726065605.50CBF100C4F@atlas.denx.de> (raw)
In-Reply-To: <a210f61e-bf51-a946-013c-dd98fd9a17b0@ti.com>

Dear "R, Vignesh",

In message <a210f61e-bf51-a946-013c-dd98fd9a17b0@ti.com> you wrote:
> 
> >> @@ -1203,6 +1206,16 @@ static int cpsw_eth_ofdata_to_platdata(struct udevice *dev)
> >>  		return -ENOENT;
> >>  	}
> >>  
> >> +
> >> +	num_mode_gpios = gpio_get_list_count(dev, "mode-gpios");
> > 
> > Extra blank line added.
> 
> I added blank line for readability. So, that code block handling
> toggling of "mode-gpios" is separated from the rest. I can remove that
> if that seems unnecessary.

There was already a blank line which provides enough separation. No
need to have multiple consecutive blank lines.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
In an infinite universe all things are possible, including the possi-
bility that the universe does not exist.
                        - Terry Pratchett, _The Dark Side of the Sun_

  reply	other threads:[~2016-07-26  6:56 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-25 13:10 [U-Boot] [PATCH 0/4] Add support for TI PCF8575 I2C GPIO expander Vignesh R
2016-07-25 13:10 ` [U-Boot] [PATCH 1/4] gpio: Add driver " Vignesh R
2016-07-25 13:38   ` Tom Rini
2016-08-01  1:01   ` Simon Glass
2016-08-01  8:54     ` Vignesh R
2016-07-25 13:10 ` [U-Boot] [PATCH 2/4] ARM: dra7xx_evm: Enable support for TI PCF8575 Vignesh R
2016-07-25 13:38   ` Tom Rini
2016-07-26  6:33     ` Vignesh R
2016-08-01  1:01       ` Simon Glass
2016-08-01  4:23         ` Vignesh R
2016-07-25 13:10 ` [U-Boot] [PATCH 3/4] net: cpsw: Add support to drive gpios for ethernet to be functional Vignesh R
2016-07-25 13:38   ` Tom Rini
2016-07-26  6:37     ` R, Vignesh
2016-07-26  6:56       ` Wolfgang Denk [this message]
2016-07-26  6:58         ` R, Vignesh
2016-07-26 12:13       ` Tom Rini
2016-07-27 12:53         ` Vignesh R
2016-07-25 13:10 ` [U-Boot] [PATCH 4/4] ARM: dts: dra72-evm: Add mode-gpios entry for mac node Vignesh R
2016-07-25 13:38   ` Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160726065605.50CBF100C4F@atlas.denx.de \
    --to=wd@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox