From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 3/4] net: cpsw: Add support to drive gpios for ethernet to be functional
Date: Tue, 26 Jul 2016 08:13:37 -0400 [thread overview]
Message-ID: <20160726121337.GS14698@bill-the-cat> (raw)
In-Reply-To: <a210f61e-bf51-a946-013c-dd98fd9a17b0@ti.com>
On Tue, Jul 26, 2016 at 12:07:26PM +0530, R, Vignesh wrote:
>
>
> On 7/25/2016 7:08 PM, Tom Rini wrote:
> > On Mon, Jul 25, 2016 at 06:40:22PM +0530, Vignesh R wrote:
> >
> >> On DRA72 EVM, cpsw slaves may be muxed with other modules. This
> >> selection is controlled by a pcf gpio line. Add support for cpsw driver
> >> to acquire mode-gpios and select the appropriate slave using gpio APIs.
> >>
> >> Signed-off-by: Vignesh R <vigneshr@ti.com>
> >
> > Reviewed-by: Tom Rini <trini@konsulko.com>
> >
> > Minor nit below:
> >
> >> @@ -1203,6 +1206,16 @@ static int cpsw_eth_ofdata_to_platdata(struct udevice *dev)
> >> return -ENOENT;
> >> }
> >>
> >> +
> >> + num_mode_gpios = gpio_get_list_count(dev, "mode-gpios");
> >
> > Extra blank line added.
>
> I added blank line for readability. So, that code block handling
> toggling of "mode-gpios" is separated from the rest. I can remove that
> if that seems unnecessary.
Two empty lines in a row just isn't done so yes please, thanks.
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20160726/65cab7be/attachment.sig>
next prev parent reply other threads:[~2016-07-26 12:13 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-25 13:10 [U-Boot] [PATCH 0/4] Add support for TI PCF8575 I2C GPIO expander Vignesh R
2016-07-25 13:10 ` [U-Boot] [PATCH 1/4] gpio: Add driver " Vignesh R
2016-07-25 13:38 ` Tom Rini
2016-08-01 1:01 ` Simon Glass
2016-08-01 8:54 ` Vignesh R
2016-07-25 13:10 ` [U-Boot] [PATCH 2/4] ARM: dra7xx_evm: Enable support for TI PCF8575 Vignesh R
2016-07-25 13:38 ` Tom Rini
2016-07-26 6:33 ` Vignesh R
2016-08-01 1:01 ` Simon Glass
2016-08-01 4:23 ` Vignesh R
2016-07-25 13:10 ` [U-Boot] [PATCH 3/4] net: cpsw: Add support to drive gpios for ethernet to be functional Vignesh R
2016-07-25 13:38 ` Tom Rini
2016-07-26 6:37 ` R, Vignesh
2016-07-26 6:56 ` Wolfgang Denk
2016-07-26 6:58 ` R, Vignesh
2016-07-26 12:13 ` Tom Rini [this message]
2016-07-27 12:53 ` Vignesh R
2016-07-25 13:10 ` [U-Boot] [PATCH 4/4] ARM: dts: dra72-evm: Add mode-gpios entry for mac node Vignesh R
2016-07-25 13:38 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160726121337.GS14698@bill-the-cat \
--to=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox