From: Vignesh R <vigneshr@ti.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/4] ARM: dra7xx_evm: Enable support for TI PCF8575
Date: Tue, 26 Jul 2016 12:03:13 +0530 [thread overview]
Message-ID: <715c96ff-e364-04bc-b108-38d97a015960@ti.com> (raw)
In-Reply-To: <20160725133839.GI14698@bill-the-cat>
On Monday 25 July 2016 07:08 PM, Tom Rini wrote:
> On Mon, Jul 25, 2016 at 06:40:21PM +0530, Vignesh R wrote:
>
>> On DRA7, pcf chip present at address 0x21 on i2c1, is used to
>> switch between cpsw slave0 and slave1. Hence, enable PCF
>> driver for the same.
>>
>> Signed-off-by: Vignesh R <vigneshr@ti.com>
>> ---
>> include/configs/dra7xx_evm.h | 5 +++++
>> 1 file changed, 5 insertions(+)
>>
>> diff --git a/include/configs/dra7xx_evm.h b/include/configs/dra7xx_evm.h
>> index 0d51aeb86909..4ad8beaf2f75 100644
>> --- a/include/configs/dra7xx_evm.h
>> +++ b/include/configs/dra7xx_evm.h
>> @@ -328,4 +328,9 @@
>> #define CONFIG_EEPROM_CHIP_ADDRESS 0x50
>> #define CONFIG_EEPROM_BUS_ADDRESS 0
>>
>> +/* PCF Support */
>> +#ifndef CONFIG_SPL_BUILD
>> +#define CONFIG_PCF8575_GPIO
>> +#endif
>
> We need to invert the logic and undef on SPL, and pick this up normally
> via Kconfig.
>
I tried that initially but, the logic does not seem to work. Since, the
driver is DM only driver, undef'ing CONFIG_PCF8575_GPIO on
CONFIG_SPL_BUILD does seem to take any effect, the driver is still being
compiled for SPL build and results in compile time errors. It seems that
undef in include/configs/* file does not seem to take effect in
Makefile, but only takes effect in the code. Any idea what am I missing?
--
Regards
Vignesh
next prev parent reply other threads:[~2016-07-26 6:33 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-25 13:10 [U-Boot] [PATCH 0/4] Add support for TI PCF8575 I2C GPIO expander Vignesh R
2016-07-25 13:10 ` [U-Boot] [PATCH 1/4] gpio: Add driver " Vignesh R
2016-07-25 13:38 ` Tom Rini
2016-08-01 1:01 ` Simon Glass
2016-08-01 8:54 ` Vignesh R
2016-07-25 13:10 ` [U-Boot] [PATCH 2/4] ARM: dra7xx_evm: Enable support for TI PCF8575 Vignesh R
2016-07-25 13:38 ` Tom Rini
2016-07-26 6:33 ` Vignesh R [this message]
2016-08-01 1:01 ` Simon Glass
2016-08-01 4:23 ` Vignesh R
2016-07-25 13:10 ` [U-Boot] [PATCH 3/4] net: cpsw: Add support to drive gpios for ethernet to be functional Vignesh R
2016-07-25 13:38 ` Tom Rini
2016-07-26 6:37 ` R, Vignesh
2016-07-26 6:56 ` Wolfgang Denk
2016-07-26 6:58 ` R, Vignesh
2016-07-26 12:13 ` Tom Rini
2016-07-27 12:53 ` Vignesh R
2016-07-25 13:10 ` [U-Boot] [PATCH 4/4] ARM: dts: dra72-evm: Add mode-gpios entry for mac node Vignesh R
2016-07-25 13:38 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=715c96ff-e364-04bc-b108-38d97a015960@ti.com \
--to=vigneshr@ti.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox