[U-Boot] [PATCH v2 1/4] rockchip: rk3229: move usb gadget into defconfig

[U-Boot] [PATCH v2 1/4] rockchip: rk3229: move usb gadget into defconfig

[Kever Yang]

Use the defconfig for all usb gadget and function related
option instead of define then in header file.

Signed-off-by: Kever Yang <kever.yang@rock-chips.com>
Acked-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
---

Changes in v2: None

 configs/evb-rk3229_defconfig    | 17 +++++++++++++++++
 include/configs/evb_rk3229.h    |  1 -
 include/configs/rk322x_common.h | 20 --------------------
 3 files changed, 17 insertions(+), 21 deletions(-)

diff --git a/configs/evb-rk3229_defconfig b/configs/evb-rk3229_defconfig
index f4ad4c2..bf5baf5 100644
--- a/configs/evb-rk3229_defconfig
+++ b/configs/evb-rk3229_defconfig
@@ -14,9 +14,18 @@ CONFIG_ENV_IS_IN_MMC=y
 CONFIG_SPL_STACK_R=y
 CONFIG_SPL_STACK_R_MALLOC_SIMPLE_LEN=0x200
 CONFIG_FASTBOOT=y
+CONFIG_USB_FUNCTION_FASTBOOT=y
+CONFIG_CMD_FASTBOOT=y
+CONFIG_ANDROID_BOOT_IMAGE=y
+CONFIG_FASTBOOT_BUF_ADDR=0x60800800
+CONFIG_FASTBOOT_BUF_SIZE=0x04000000
+CONFIG_FASTBOOT_FLASH=y
+CONFIG_FASTBOOT_FLASH_MMC_DEV=0
 # CONFIG_CMD_IMLS is not set
 CONFIG_CMD_GPT=y
 CONFIG_CMD_MMC=y
+CONFIG_CMD_USB=y
+CONFIG_CMD_USB_MASS_STORAGE=y
 # CONFIG_CMD_SETEXPR is not set
 CONFIG_CMD_TIME=y
 CONFIG_SPL_OF_CONTROL=y
@@ -41,4 +50,12 @@ CONFIG_DEBUG_UART_CLOCK=24000000
 CONFIG_DEBUG_UART_SHIFT=2
 CONFIG_SYS_NS16550=y
 CONFIG_SYSRESET=y
+CONFIG_USB=y
+CONFIG_USB_DWC2=y
+CONFIG_USB_GADGET=y
+CONFIG_USB_GADGET_DWC2_OTG=y
+CONFIG_USB_GADGET_DOWNLOAD=y
+CONFIG_G_DNL_MANUFACTURER="Rockchip"
+CONFIG_G_DNL_VENDOR_NUM=0x2207
+CONFIG_G_DNL_PRODUCT_NUM=0x320a
 CONFIG_ERRNO_STR=y
diff --git a/include/configs/evb_rk3229.h b/include/configs/evb_rk3229.h
index 6e1fd1c..8906c8f 100644
--- a/include/configs/evb_rk3229.h
+++ b/include/configs/evb_rk3229.h
@@ -40,7 +40,6 @@
 
 #define CONFIG_PREBOOT
 
-#define CONFIG_ANDROID_BOOT_IMAGE
 #define CONFIG_SYS_BOOT_RAMDISK_HIGH
 
 #undef CONFIG_BOOTCOMMAND
diff --git a/include/configs/rk322x_common.h b/include/configs/rk322x_common.h
index a145b74..7630bc5 100644
--- a/include/configs/rk322x_common.h
+++ b/include/configs/rk322x_common.h
@@ -40,28 +40,8 @@
 #define SDRAM_MAX_SIZE			0x80000000
 
 #ifndef CONFIG_SPL_BUILD
-/* usb otg */
-#define CONFIG_USB_GADGET
-#define CONFIG_USB_GADGET_DUALSPEED
-#define CONFIG_USB_GADGET_DWC2_OTG
-#define CONFIG_USB_GADGET_VBUS_DRAW	0
-
-/* fastboot  */
-#define CONFIG_CMD_FASTBOOT
-#define CONFIG_USB_FUNCTION_FASTBOOT
-#define CONFIG_FASTBOOT_FLASH
-#define CONFIG_FASTBOOT_FLASH_MMC_DEV	0
-#define CONFIG_FASTBOOT_BUF_ADDR	CONFIG_SYS_LOAD_ADDR
-#define CONFIG_FASTBOOT_BUF_SIZE	0x08000000
-
 /* usb mass storage */
 #define CONFIG_USB_FUNCTION_MASS_STORAGE
-#define CONFIG_CMD_USB_MASS_STORAGE
-
-#define CONFIG_USB_GADGET_DOWNLOAD
-#define CONFIG_G_DNL_MANUFACTURER	"Rockchip"
-#define CONFIG_G_DNL_VENDOR_NUM		0x2207
-#define CONFIG_G_DNL_PRODUCT_NUM	0x320a
 
 /* usb host */
 #ifdef CONFIG_CMD_USB
-- 
1.9.1

[U-Boot] [PATCH v2 2/4] rockchip: rk322x: update the sysreg number for boot mode

[Kever Yang]

The boot mode for rk322x is stored in sysreg 0, update it.

Signed-off-by: Kever Yang <kever.yang@rock-chips.com>
Acked-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
---

Changes in v2: None

 arch/arm/mach-rockchip/rk322x-board.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm/mach-rockchip/rk322x-board.c b/arch/arm/mach-rockchip/rk322x-board.c
index 1e79c19..91e3c90 100644
--- a/arch/arm/mach-rockchip/rk322x-board.c
+++ b/arch/arm/mach-rockchip/rk322x-board.c
@@ -20,12 +20,12 @@ DECLARE_GLOBAL_DATA_PTR;
 static void setup_boot_mode(void)
 {
 	struct rk322x_grf *const grf = (void *)GRF_BASE;
-	int boot_mode = readl(&grf->os_reg[4]);
+	int boot_mode = readl(&grf->os_reg[0]);
 
 	debug("boot mode %x.\n", boot_mode);
 
 	/* Clear boot mode */
-	writel(BOOT_NORMAL, &grf->os_reg[4]);
+	writel(BOOT_NORMAL, &grf->os_reg[0]);
 
 	switch (boot_mode) {
 	case BOOT_FASTBOOT:
-- 
1.9.1

[U-Boot] [U-Boot, v2, 2/4] rockchip: rk322x: update the sysreg number for boot mode

[Philipp Tomsich]

> The boot mode for rk322x is stored in sysreg 0, update it.
> 
> Signed-off-by: Kever Yang <kever.yang@rock-chips.com>
> Acked-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
> ---
> 
> Changes in v2: None
> 
>  arch/arm/mach-rockchip/rk322x-board.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 

Reviewed-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>

[U-Boot] [U-Boot, v2, 2/4] rockchip: rk322x: update the sysreg number for boot mode

[Philipp Tomsich]

> The boot mode for rk322x is stored in sysreg 0, update it.
> 
> Signed-off-by: Kever Yang <kever.yang@rock-chips.com>
> Acked-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
> Reviewed-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
> ---
> 
> Changes in v2: None
> 
>  arch/arm/mach-rockchip/rk322x-board.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 

Applied to u-boot-rockchip, thanks!

[U-Boot] [PATCH v2 3/4] rockchip: add BOOT_LOADER support for boot mode

[Kever Yang]

Rockchip using rockusb for flash emmc via USB, people
use 'reboot loader' in kernel and then want to get a rockusb
device in bootloader for firmware update.

Signed-off-by: Kever Yang <kever.yang@rock-chips.com>
---

Changes in v2:
- use env_set() instead of setenv()

 arch/arm/mach-rockchip/rk3036-board.c | 4 ++++
 arch/arm/mach-rockchip/rk322x-board.c | 4 ++++
 arch/arm/mach-rockchip/rk3288-board.c | 4 ++++
 3 files changed, 12 insertions(+)

diff --git a/arch/arm/mach-rockchip/rk3036-board.c b/arch/arm/mach-rockchip/rk3036-board.c
index a3457f3..1f11f8e 100644
--- a/arch/arm/mach-rockchip/rk3036-board.c
+++ b/arch/arm/mach-rockchip/rk3036-board.c
@@ -40,6 +40,10 @@ static void setup_boot_mode(void)
 		printf("enter UMS!\n");
 		env_set("preboot", "setenv preboot; ums mmc 0");
 		break;
+	case BOOT_LOADER:
+		printf("enter Rockusb!\n");
+		env_set("preboot", "setenv preboot; rockusb 0 mmc 0");
+		break;
 	}
 }
 
diff --git a/arch/arm/mach-rockchip/rk322x-board.c b/arch/arm/mach-rockchip/rk322x-board.c
index 91e3c90..8c77977 100644
--- a/arch/arm/mach-rockchip/rk322x-board.c
+++ b/arch/arm/mach-rockchip/rk322x-board.c
@@ -36,6 +36,10 @@ static void setup_boot_mode(void)
 		printf("enter UMS!\n");
 		env_set("preboot", "setenv preboot; ums mmc 0");
 		break;
+	case BOOT_LOADER:
+		printf("enter Rockusb!\n");
+		env_set("preboot", "setenv preboot; rockusb 0 mmc 0");
+		break;
 	}
 }
 
diff --git a/arch/arm/mach-rockchip/rk3288-board.c b/arch/arm/mach-rockchip/rk3288-board.c
index 74c6cc1..a08658a 100644
--- a/arch/arm/mach-rockchip/rk3288-board.c
+++ b/arch/arm/mach-rockchip/rk3288-board.c
@@ -44,6 +44,10 @@ static void setup_boot_mode(void)
 		env_set("preboot", "setenv preboot; if mmc dev 0;"
 		       "then ums mmc 0; else ums mmc 1;fi");
 		break;
+	case BOOT_LOADER:
+		printf("enter Rockusb!\n");
+		env_set("preboot", "setenv preboot; rockusb 0 mmc 0");
+		break;
 	}
 }
 
-- 
1.9.1

[U-Boot] [U-Boot, v2, 3/4] rockchip: add BOOT_LOADER support for boot mode

[Philipp Tomsich]

On Tue, 22 Aug 2017, Kever Yang wrote:

> Rockchip using rockusb for flash emmc via USB, people
> use 'reboot loader' in kernel and then want to get a rockusb
> device in bootloader for firmware update.
>
> Signed-off-by: Kever Yang <kever.yang@rock-chips.com>

Reviewed-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>

See blow for requested changes.

> ---
>
> Changes in v2:
> - use env_set() instead of setenv()
>
> arch/arm/mach-rockchip/rk3036-board.c | 4 ++++
> arch/arm/mach-rockchip/rk322x-board.c | 4 ++++
> arch/arm/mach-rockchip/rk3288-board.c | 4 ++++
> 3 files changed, 12 insertions(+)
>
> diff --git a/arch/arm/mach-rockchip/rk3036-board.c b/arch/arm/mach-rockchip/rk3036-board.c
> index a3457f3..1f11f8e 100644
> --- a/arch/arm/mach-rockchip/rk3036-board.c
> +++ b/arch/arm/mach-rockchip/rk3036-board.c
> @@ -40,6 +40,10 @@ static void setup_boot_mode(void)
> 		printf("enter UMS!\n");
> 		env_set("preboot", "setenv preboot; ums mmc 0");
> 		break;
> +	case BOOT_LOADER:
> +		printf("enter Rockusb!\n");
> +		env_set("preboot", "setenv preboot; rockusb 0 mmc 0");
> +		break;

Looks like this is duplicated code across all our boards.
Can you please factor this out and call into common code for this?

> 	}
> }
>
> diff --git a/arch/arm/mach-rockchip/rk322x-board.c b/arch/arm/mach-rockchip/rk322x-board.c
> index 91e3c90..8c77977 100644
> --- a/arch/arm/mach-rockchip/rk322x-board.c
> +++ b/arch/arm/mach-rockchip/rk322x-board.c
> @@ -36,6 +36,10 @@ static void setup_boot_mode(void)
> 		printf("enter UMS!\n");
> 		env_set("preboot", "setenv preboot; ums mmc 0");
> 		break;
> +	case BOOT_LOADER:
> +		printf("enter Rockusb!\n");
> +		env_set("preboot", "setenv preboot; rockusb 0 mmc 0");
> +		break;
> 	}
> }
>
> diff --git a/arch/arm/mach-rockchip/rk3288-board.c b/arch/arm/mach-rockchip/rk3288-board.c
> index 74c6cc1..a08658a 100644
> --- a/arch/arm/mach-rockchip/rk3288-board.c
> +++ b/arch/arm/mach-rockchip/rk3288-board.c
> @@ -44,6 +44,10 @@ static void setup_boot_mode(void)
> 		env_set("preboot", "setenv preboot; if mmc dev 0;"
> 		       "then ums mmc 0; else ums mmc 1;fi");
> 		break;
> +	case BOOT_LOADER:
> +		printf("enter Rockusb!\n");
> +		env_set("preboot", "setenv preboot; rockusb 0 mmc 0");
> +		break;
> 	}
> }
>
>

[U-Boot] [PATCH v2 4/4] rockchip: enable rockusb for all rockchip SoCs

[Kever Yang]

Rockusb will be used by all the rockchip SoCs, enable it by
default in Kconfig, and it can be work if USB gadget is available.

Signed-off-by: Kever Yang <kever.yang@rock-chips.com>
Acked-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
---

Changes in v2: None

 arch/arm/Kconfig | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
index da9324b..f566d50 100644
--- a/arch/arm/Kconfig
+++ b/arch/arm/Kconfig
@@ -1084,6 +1084,8 @@ config ARCH_ROCKCHIP
 	select DM_PWM
 	select DM_REGULATOR
 	imply FAT_WRITE
+	imply USB_FUNCTION_ROCKUSB
+	imply CMD_ROCKUSB
 
 config TARGET_THUNDERX_88XX
 	bool "Support ThunderX 88xx"
-- 
1.9.1

[U-Boot] [PATCH v2 4/4] rockchip: enable rockusb for all rockchip SoCs

[Dr. Philipp Tomsich]

Kever,

I was about to apply the rockusb changes onto next yesterday, when I realised
that rockusb hadn’t been merged on the USB side…

Do you know the status on the rockusb patches?
I’d like to avoid merging this on our end, before the infrastructure has been merged.

Regards,
Philipp.

> On 22 Aug 2017, at 09:35, Kever Yang <kever.yang@rock-chips.com> wrote:
> 
> Rockusb will be used by all the rockchip SoCs, enable it by
> default in Kconfig, and it can be work if USB gadget is available.
> 
> Signed-off-by: Kever Yang <kever.yang@rock-chips.com>
> Acked-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
> ---
> 
> Changes in v2: None
> 
> arch/arm/Kconfig | 2 ++
> 1 file changed, 2 insertions(+)
> 
> diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
> index da9324b..f566d50 100644
> --- a/arch/arm/Kconfig
> +++ b/arch/arm/Kconfig
> @@ -1084,6 +1084,8 @@ config ARCH_ROCKCHIP
> 	select DM_PWM
> 	select DM_REGULATOR
> 	imply FAT_WRITE
> +	imply USB_FUNCTION_ROCKUSB
> +	imply CMD_ROCKUSB
> 
> config TARGET_THUNDERX_88XX
> 	bool "Support ThunderX 88xx"
> -- 
> 1.9.1
> 

[U-Boot] [PATCH v2 4/4] rockchip: enable rockusb for all rockchip SoCs

[Kever Yang]

Philipp,

     I have no idea about the status of rockusb, it has been a long time 
on the list.

Maybe Eddie or Lukasz have an answer?

I have to use those patches on my local branch, so that we don't have to 
enter

bootrom mode for firmware update.

Thanks,
- Kever
On 08/22/2017 04:44 PM, Dr. Philipp Tomsich wrote:
> Kever,
>
> I was about to apply the rockusb changes onto next yesterday, when I realised
> that rockusb hadn’t been merged on the USB side…
>
> Do you know the status on the rockusb patches?
> I’d like to avoid merging this on our end, before the infrastructure has been merged.
>
> Regards,
> Philipp.
>
>> On 22 Aug 2017, at 09:35, Kever Yang <kever.yang@rock-chips.com> wrote:
>>
>> Rockusb will be used by all the rockchip SoCs, enable it by
>> default in Kconfig, and it can be work if USB gadget is available.
>>
>> Signed-off-by: Kever Yang <kever.yang@rock-chips.com>
>> Acked-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
>> ---
>>
>> Changes in v2: None
>>
>> arch/arm/Kconfig | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
>> index da9324b..f566d50 100644
>> --- a/arch/arm/Kconfig
>> +++ b/arch/arm/Kconfig
>> @@ -1084,6 +1084,8 @@ config ARCH_ROCKCHIP
>> 	select DM_PWM
>> 	select DM_REGULATOR
>> 	imply FAT_WRITE
>> +	imply USB_FUNCTION_ROCKUSB
>> +	imply CMD_ROCKUSB
>>
>> config TARGET_THUNDERX_88XX
>> 	bool "Support ThunderX 88xx"
>> -- 
>> 1.9.1
>>
>

[U-Boot] [PATCH v2 4/4] rockchip: enable rockusb for all rockchip SoCs

[Łukasz Majewski]

Hi Kever,


> Philipp,
>
>     I have no idea about the status of rockusb, it has been a long time
> on the list.
>
> Maybe Eddie or Lukasz have an answer?

I've asked Eddie to fix issues with breaking other boards when enabling 
USB gadget infrastructure on RK.

No reply since then.

>
> I have to use those patches on my local branch, so that we don't have to
> enter
>
> bootrom mode for firmware update.
>
> Thanks,
> - Kever
> On 08/22/2017 04:44 PM, Dr. Philipp Tomsich wrote:
>> Kever,
>>
>> I was about to apply the rockusb changes onto next yesterday, when I
>> realised
>> that rockusb hadn’t been merged on the USB side…
>>
>> Do you know the status on the rockusb patches?
>> I’d like to avoid merging this on our end, before the infrastructure
>> has been merged.
>>
>> Regards,
>> Philipp.
>>
>>> On 22 Aug 2017, at 09:35, Kever Yang <kever.yang@rock-chips.com> wrote:
>>>
>>> Rockusb will be used by all the rockchip SoCs, enable it by
>>> default in Kconfig, and it can be work if USB gadget is available.
>>>
>>> Signed-off-by: Kever Yang <kever.yang@rock-chips.com>
>>> Acked-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
>>> ---
>>>
>>> Changes in v2: None
>>>
>>> arch/arm/Kconfig | 2 ++
>>> 1 file changed, 2 insertions(+)
>>>
>>> diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
>>> index da9324b..f566d50 100644
>>> --- a/arch/arm/Kconfig
>>> +++ b/arch/arm/Kconfig
>>> @@ -1084,6 +1084,8 @@ config ARCH_ROCKCHIP
>>>     select DM_PWM
>>>     select DM_REGULATOR
>>>     imply FAT_WRITE
>>> +    imply USB_FUNCTION_ROCKUSB
>>> +    imply CMD_ROCKUSB
>>>
>>> config TARGET_THUNDERX_88XX
>>>     bool "Support ThunderX 88xx"
>>> --
>>> 1.9.1
>>>
>>
>
>
>


-- 
Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de

[U-Boot] [PATCH v2 4/4] rockchip: enable rockusb for all rockchip SoCs

[Andy Yan]

Hi Lukasz:

2017-08-22 18:05 GMT+08:00 Łukasz Majewski <lukma@denx.de>:

> Hi Kever,
>
>
> Philipp,
>>
>>     I have no idea about the status of rockusb, it has been a long time
>> on the list.
>>
>> Maybe Eddie or Lukasz have an answer?
>>
>
> I've asked Eddie to fix issues with breaking other boards when enabling
> USB gadget infrastructure on RK.
>
> No reply since then.
>
>

Eddie has fix all the issues he can reproduced on local。 The only problem
now is that  the rk3036 based boards(evb-rk3036/kylin-rk3036) show compile
errors on CI[0], but when we do the same compile on our local computer, the
all evb-rk3036 and kylin-rk3036 compiled successfully. And we didn't find
anything in Eddie's patch that will trigger such errors. As you mentationed
in the mail[1], you have also build rk3036 successfully on your local. So
maybe there is something different between the CI and the local build.
Could you please give as some directions on this？

[0] https://travis-ci.org/eddiecailinux/u-boot/jobs/235944449#L759
[1] http://patchwork.ozlabs.org/patch/766901/


>
>> I have to use those patches on my local branch, so that we don't have to
>> enter
>>
>> bootrom mode for firmware update.
>>
>> Thanks,
>> - Kever
>> On 08/22/2017 04:44 PM, Dr. Philipp Tomsich wrote:
>>
>>> Kever,
>>>
>>> I was about to apply the rockusb changes onto next yesterday, when I
>>> realised
>>> that rockusb hadn’t been merged on the USB side…
>>>
>>> Do you know the status on the rockusb patches?
>>> I’d like to avoid merging this on our end, before the infrastructure
>>> has been merged.
>>>
>>> Regards,
>>> Philipp.
>>>
>>> On 22 Aug 2017, at 09:35, Kever Yang <kever.yang@rock-chips.com> wrote:
>>>>
>>>> Rockusb will be used by all the rockchip SoCs, enable it by
>>>> default in Kconfig, and it can be work if USB gadget is available.
>>>>
>>>> Signed-off-by: Kever Yang <kever.yang@rock-chips.com>
>>>> Acked-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
>>>> ---
>>>>
>>>> Changes in v2: None
>>>>
>>>> arch/arm/Kconfig | 2 ++
>>>> 1 file changed, 2 insertions(+)
>>>>
>>>> diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
>>>> index da9324b..f566d50 100644
>>>> --- a/arch/arm/Kconfig
>>>> +++ b/arch/arm/Kconfig
>>>> @@ -1084,6 +1084,8 @@ config ARCH_ROCKCHIP
>>>>     select DM_PWM
>>>>     select DM_REGULATOR
>>>>     imply FAT_WRITE
>>>> +    imply USB_FUNCTION_ROCKUSB
>>>> +    imply CMD_ROCKUSB
>>>>
>>>> config TARGET_THUNDERX_88XX
>>>>     bool "Support ThunderX 88xx"
>>>> --
>>>> 1.9.1
>>>>
>>>>
>>>
>>
>>
>>
>
> --
> Best regards,
>
> Lukasz Majewski
>
> --
>
> DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
> Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
>
> _______________________________________________
> U-Boot mailing list
> U-Boot at lists.denx.de
> https://lists.denx.de/listinfo/u-boot
>

[U-Boot] [PATCH v2 4/4] rockchip: enable rockusb for all rockchip SoCs

[Dr. Philipp Tomsich]

> On 25 Aug 2017, at 03:51, Andy Yan <andyshrk@gmail.com> wrote:
> 
> Hi Lukasz:
> 
> 2017-08-22 18:05 GMT+08:00 Łukasz Majewski <lukma at denx.de <mailto:lukma@denx.de>>:
> Hi Kever,
> 
> 
> Philipp,
> 
>     I have no idea about the status of rockusb, it has been a long time
> on the list.
> 
> Maybe Eddie or Lukasz have an answer?
> 
> I've asked Eddie to fix issues with breaking other boards when enabling USB gadget infrastructure on RK.
> 
> No reply since then.
> 
> 
> 
> Eddie has fix all the issues he can reproduced on local。 The only problem now is that  the rk3036 based boards(evb-rk3036/kylin-rk3036) show compile errors on CI[0],

The Travis log shows linker errors for some of the other boards (i.e. not evb-rk3036/kylin-rk3036), due to unresolved symbols.

> but when we do the same compile on our local computer, the all evb-rk3036 and kylin-rk3036 compiled successfully. And we didn't find anything in Eddie's patch that will trigger such errors. As you mentationed in the mail[1], you have also build rk3036 successfully on your local. So maybe there is something different between the CI and the local build. Could you please give as some directions on this？
> 
> [0] https://travis-ci.org/eddiecailinux/u-boot/jobs/235944449#L759 <https://travis-ci.org/eddiecailinux/u-boot/jobs/235944449#L759>[1] http://patchwork.ozlabs.org/patch/766901/ <http://patchwork.ozlabs.org/patch/766901/>
> 
> 
> 
> I have to use those patches on my local branch, so that we don't have to
> enter
> 
> bootrom mode for firmware update.
> 
> Thanks,
> - Kever
> On 08/22/2017 04:44 PM, Dr. Philipp Tomsich wrote:
> Kever,
> 
> I was about to apply the rockusb changes onto next yesterday, when I
> realised
> that rockusb hadn’t been merged on the USB side…
> 
> Do you know the status on the rockusb patches?
> I’d like to avoid merging this on our end, before the infrastructure
> has been merged.
> 
> Regards,
> Philipp.
> 
> On 22 Aug 2017, at 09:35, Kever Yang <kever.yang at rock-chips.com <mailto:kever.yang@rock-chips.com>> wrote:
> 
> Rockusb will be used by all the rockchip SoCs, enable it by
> default in Kconfig, and it can be work if USB gadget is available.
> 
> Signed-off-by: Kever Yang <kever.yang at rock-chips.com <mailto:kever.yang@rock-chips.com>>
> Acked-by: Philipp Tomsich <philipp.tomsich at theobroma-systems.com <mailto:philipp.tomsich@theobroma-systems.com>>
> ---
> 
> Changes in v2: None
> 
> arch/arm/Kconfig | 2 ++
> 1 file changed, 2 insertions(+)
> 
> diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
> index da9324b..f566d50 100644
> --- a/arch/arm/Kconfig
> +++ b/arch/arm/Kconfig
> @@ -1084,6 +1084,8 @@ config ARCH_ROCKCHIP
>     select DM_PWM
>     select DM_REGULATOR
>     imply FAT_WRITE
> +    imply USB_FUNCTION_ROCKUSB
> +    imply CMD_ROCKUSB
> 
> config TARGET_THUNDERX_88XX
>     bool "Support ThunderX 88xx"
> --
> 1.9.1
> 
> 
> 
> 
> 
> 
> 
> -- 
> Best regards,
> 
> Lukasz Majewski
> 
> --
> 
> DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
> Phone: (+49)-8142-66989-10 <tel:%28%2B49%29-8142-66989-10> Fax: (+49)-8142-66989-80 <tel:%28%2B49%29-8142-66989-80> Email: wd at denx.de <mailto:wd@denx.de>
> 
> _______________________________________________
> U-Boot mailing list
> U-Boot at lists.denx.de <mailto:U-Boot@lists.denx.de>
> https://lists.denx.de/listinfo/u-boot <https://lists.denx.de/listinfo/u-boot>

[U-Boot] [PATCH v2 4/4] rockchip: enable rockusb for all rockchip SoCs

[Łukasz Majewski]

Hi Philipp, Andy, Tom
>
>> On 25 Aug 2017, at 03:51, Andy Yan <andyshrk@gmail.com> wrote:
>>
>> Hi Lukasz:
>>
>> 2017-08-22 18:05 GMT+08:00 Łukasz Majewski <lukma at denx.de <mailto:lukma@denx.de>>:
>> Hi Kever,
>>
>>
>> Philipp,
>>
>>     I have no idea about the status of rockusb, it has been a long time
>> on the list.
>>
>> Maybe Eddie or Lukasz have an answer?
>>
>> I've asked Eddie to fix issues with breaking other boards when enabling USB gadget infrastructure on RK.
>>
>> No reply since then.
>>
>>
>>
>> Eddie has fix all the issues he can reproduced on local。 The only problem now is that  the rk3036 based boards(evb-rk3036/kylin-rk3036) show compile errors on CI[0],
>
> The Travis log shows linker errors for some of the other boards (i.e. not evb-rk3036/kylin-rk3036), due to unresolved symbols.

Yes, Indeed.

I've build those boards locally with gcc 6.3 and it was successful.


Regarding travis CI:

With Eddie's patches it shows error:
https://travis-ci.org/lmajewski/u-boot-dfu/builds/268270904

However, without Eddie's patches travis-CI doesn't show any errors:
https://travis-ci.org/lmajewski/u-boot-dfu/builds/268303030


Let's ask Tom (who has far more experience with travis-CI), if he saw 
something like that before.

>
>> but when we do the same compile on our local computer, the all evb-rk3036 and kylin-rk3036 compiled successfully. And we didn't find anything in Eddie's patch that will trigger such errors. As you mentationed in the mail[1], you have also build rk3036 successfully on your local. So maybe there is something different between the CI and the local build. Could you please give as some directions on this？
>>
>> [0] https://travis-ci.org/eddiecailinux/u-boot/jobs/235944449#L759 <https://travis-ci.org/eddiecailinux/u-boot/jobs/235944449#L759>[1] http://patchwork.ozlabs.org/patch/766901/ <http://patchwork.ozlabs.org/patch/766901/>
>>
>>
>>
>> I have to use those patches on my local branch, so that we don't have to
>> enter
>>
>> bootrom mode for firmware update.
>>
>> Thanks,
>> - Kever
>> On 08/22/2017 04:44 PM, Dr. Philipp Tomsich wrote:
>> Kever,
>>
>> I was about to apply the rockusb changes onto next yesterday, when I
>> realised
>> that rockusb hadn’t been merged on the USB side…
>>
>> Do you know the status on the rockusb patches?
>> I’d like to avoid merging this on our end, before the infrastructure
>> has been merged.
>>
>> Regards,
>> Philipp.
>>
>> On 22 Aug 2017, at 09:35, Kever Yang <kever.yang at rock-chips.com <mailto:kever.yang@rock-chips.com>> wrote:
>>
>> Rockusb will be used by all the rockchip SoCs, enable it by
>> default in Kconfig, and it can be work if USB gadget is available.
>>
>> Signed-off-by: Kever Yang <kever.yang at rock-chips.com <mailto:kever.yang@rock-chips.com>>
>> Acked-by: Philipp Tomsich <philipp.tomsich at theobroma-systems.com <mailto:philipp.tomsich@theobroma-systems.com>>
>> ---
>>
>> Changes in v2: None
>>
>> arch/arm/Kconfig | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
>> index da9324b..f566d50 100644
>> --- a/arch/arm/Kconfig
>> +++ b/arch/arm/Kconfig
>> @@ -1084,6 +1084,8 @@ config ARCH_ROCKCHIP
>>     select DM_PWM
>>     select DM_REGULATOR
>>     imply FAT_WRITE
>> +    imply USB_FUNCTION_ROCKUSB
>> +    imply CMD_ROCKUSB
>>
>> config TARGET_THUNDERX_88XX
>>     bool "Support ThunderX 88xx"
>> --
>> 1.9.1
>>
>>
>>
>>
>>
>>
>>
>> --
>> Best regards,
>>
>> Lukasz Majewski
>>
>> --
>>
>> DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
>> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
>> Phone: (+49)-8142-66989-10 <tel:%28%2B49%29-8142-66989-10> Fax: (+49)-8142-66989-80 <tel:%28%2B49%29-8142-66989-80> Email: wd at denx.de <mailto:wd@denx.de>
>>
>> _______________________________________________
>> U-Boot mailing list
>> U-Boot at lists.denx.de <mailto:U-Boot@lists.denx.de>
>> https://lists.denx.de/listinfo/u-boot <https://lists.denx.de/listinfo/u-boot>
>


-- 
Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de

[U-Boot] [PATCH v2 4/4] rockchip: enable rockusb for all rockchip SoCs

[Łukasz Majewski]

Dear All,

> Hi Philipp, Andy, Tom
>>
>>> On 25 Aug 2017, at 03:51, Andy Yan <andyshrk@gmail.com> wrote:
>>>
>>> Hi Lukasz:
>>>
>>> 2017-08-22 18:05 GMT+08:00 Łukasz Majewski <lukma@denx.de
>>> <mailto:lukma@denx.de>>:
>>> Hi Kever,
>>>
>>>
>>> Philipp,
>>>
>>>     I have no idea about the status of rockusb, it has been a long time
>>> on the list.
>>>
>>> Maybe Eddie or Lukasz have an answer?
>>>
>>> I've asked Eddie to fix issues with breaking other boards when
>>> enabling USB gadget infrastructure on RK.
>>>
>>> No reply since then.
>>>
>>>
>>>
>>> Eddie has fix all the issues he can reproduced on local。 The only
>>> problem now is that  the rk3036 based boards(evb-rk3036/kylin-rk3036)
>>> show compile errors on CI[0],
>>
>> The Travis log shows linker errors for some of the other boards (i.e.
>> not evb-rk3036/kylin-rk3036), due to unresolved symbols.
>
> Yes, Indeed.
>
> I've build those boards locally with gcc 6.3 and it was successful.

And in the meantime - I would like to kindly ask Eddie to rebase this 
patch series on the newest u-boot-usb/master branch.

I will add the code to -dfu and submit a PR when new merge window opens.

Thanks in advance,
Łukasz

>
>
> Regarding travis CI:
>
> With Eddie's patches it shows error:
> https://travis-ci.org/lmajewski/u-boot-dfu/builds/268270904
>
> However, without Eddie's patches travis-CI doesn't show any errors:
> https://travis-ci.org/lmajewski/u-boot-dfu/builds/268303030
>
>
> Let's ask Tom (who has far more experience with travis-CI), if he saw
> something like that before.
>
>>
>>> but when we do the same compile on our local computer, the all
>>> evb-rk3036 and kylin-rk3036 compiled successfully. And we didn't find
>>> anything in Eddie's patch that will trigger such errors. As you
>>> mentationed in the mail[1], you have also build rk3036 successfully
>>> on your local. So maybe there is something different between the CI
>>> and the local build. Could you please give as some directions on this？
>>>
>>> [0] https://travis-ci.org/eddiecailinux/u-boot/jobs/235944449#L759
>>> <https://travis-ci.org/eddiecailinux/u-boot/jobs/235944449#L759>[1]
>>> http://patchwork.ozlabs.org/patch/766901/
>>> <http://patchwork.ozlabs.org/patch/766901/>
>>>
>>>
>>>
>>> I have to use those patches on my local branch, so that we don't have to
>>> enter
>>>
>>> bootrom mode for firmware update.
>>>
>>> Thanks,
>>> - Kever
>>> On 08/22/2017 04:44 PM, Dr. Philipp Tomsich wrote:
>>> Kever,
>>>
>>> I was about to apply the rockusb changes onto next yesterday, when I
>>> realised
>>> that rockusb hadn’t been merged on the USB side…
>>>
>>> Do you know the status on the rockusb patches?
>>> I’d like to avoid merging this on our end, before the infrastructure
>>> has been merged.
>>>
>>> Regards,
>>> Philipp.
>>>
>>> On 22 Aug 2017, at 09:35, Kever Yang <kever.yang@rock-chips.com
>>> <mailto:kever.yang@rock-chips.com>> wrote:
>>>
>>> Rockusb will be used by all the rockchip SoCs, enable it by
>>> default in Kconfig, and it can be work if USB gadget is available.
>>>
>>> Signed-off-by: Kever Yang <kever.yang@rock-chips.com
>>> <mailto:kever.yang@rock-chips.com>>
>>> Acked-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com
>>> <mailto:philipp.tomsich@theobroma-systems.com>>
>>> ---
>>>
>>> Changes in v2: None
>>>
>>> arch/arm/Kconfig | 2 ++
>>> 1 file changed, 2 insertions(+)
>>>
>>> diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
>>> index da9324b..f566d50 100644
>>> --- a/arch/arm/Kconfig
>>> +++ b/arch/arm/Kconfig
>>> @@ -1084,6 +1084,8 @@ config ARCH_ROCKCHIP
>>>     select DM_PWM
>>>     select DM_REGULATOR
>>>     imply FAT_WRITE
>>> +    imply USB_FUNCTION_ROCKUSB
>>> +    imply CMD_ROCKUSB
>>>
>>> config TARGET_THUNDERX_88XX
>>>     bool "Support ThunderX 88xx"
>>> --
>>> 1.9.1
>>>
>>>
>>>
>>>
>>>
>>>
>>>
>>> --
>>> Best regards,
>>>
>>> Lukasz Majewski
>>>
>>> --
>>>
>>> DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
>>> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
>>> Phone: (+49)-8142-66989-10 <tel:%28%2B49%29-8142-66989-10> Fax:
>>> (+49)-8142-66989-80 <tel:%28%2B49%29-8142-66989-80> Email: wd at denx.de
>>> <mailto:wd@denx.de>
>>>
>>> _______________________________________________
>>> U-Boot mailing list
>>> U-Boot at lists.denx.de <mailto:U-Boot@lists.denx.de>
>>> https://lists.denx.de/listinfo/u-boot
>>> <https://lists.denx.de/listinfo/u-boot>
>>
>
>


-- 
Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de

[U-Boot] [PATCH v2 4/4] rockchip: enable rockusb for all rockchip SoCs

[Tom Rini]

On Fri, Aug 25, 2017 at 01:06:55PM +0200, Łukasz Majewski wrote:
> Hi Philipp, Andy, Tom
> >
> >>On 25 Aug 2017, at 03:51, Andy Yan <andyshrk@gmail.com> wrote:
> >>
> >>Hi Lukasz:
> >>
> >>2017-08-22 18:05 GMT+08:00 Łukasz Majewski <lukma at denx.de <mailto:lukma@denx.de>>:
> >>Hi Kever,
> >>
> >>
> >>Philipp,
> >>
> >>    I have no idea about the status of rockusb, it has been a long time
> >>on the list.
> >>
> >>Maybe Eddie or Lukasz have an answer?
> >>
> >>I've asked Eddie to fix issues with breaking other boards when enabling USB gadget infrastructure on RK.
> >>
> >>No reply since then.
> >>
> >>
> >>
> >>Eddie has fix all the issues he can reproduced on local。 The only problem now is that  the rk3036 based boards(evb-rk3036/kylin-rk3036) show compile errors on CI[0],
> >
> >The Travis log shows linker errors for some of the other boards (i.e. not evb-rk3036/kylin-rk3036), due to unresolved symbols.
> 
> Yes, Indeed.
> 
> I've build those boards locally with gcc 6.3 and it was successful.

The same one we use in travis-ci, from Linaro?

> Regarding travis CI:
> 
> With Eddie's patches it shows error:
> https://travis-ci.org/lmajewski/u-boot-dfu/builds/268270904
> 
> However, without Eddie's patches travis-CI doesn't show any errors:
> https://travis-ci.org/lmajewski/u-boot-dfu/builds/268303030
> 
> 
> Let's ask Tom (who has far more experience with travis-CI), if he
> saw something like that before.

Well, travis talks about using docker to replicate their environment,
which means someone should be able to do that, get it to fail in a
debugable environment and then move forward.

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20170826/dcc2250f/attachment.sig>

[U-Boot] [PATCH v2 4/4] rockchip: enable rockusb for all rockchip SoCs

[Łukasz Majewski]

On 08/26/2017 02:46 PM, Tom Rini wrote:
> On Fri, Aug 25, 2017 at 01:06:55PM +0200, Łukasz Majewski wrote:
>> Hi Philipp, Andy, Tom
>>>
>>>> On 25 Aug 2017, at 03:51, Andy Yan <andyshrk@gmail.com> wrote:
>>>>
>>>> Hi Lukasz:
>>>>
>>>> 2017-08-22 18:05 GMT+08:00 Łukasz Majewski <lukma at denx.de <mailto:lukma@denx.de>>:
>>>> Hi Kever,
>>>>
>>>>
>>>> Philipp,
>>>>
>>>>    I have no idea about the status of rockusb, it has been a long time
>>>> on the list.
>>>>
>>>> Maybe Eddie or Lukasz have an answer?
>>>>
>>>> I've asked Eddie to fix issues with breaking other boards when enabling USB gadget infrastructure on RK.
>>>>
>>>> No reply since then.
>>>>
>>>>
>>>>
>>>> Eddie has fix all the issues he can reproduced on local。 The only problem now is that  the rk3036 based boards(evb-rk3036/kylin-rk3036) show compile errors on CI[0],
>>>
>>> The Travis log shows linker errors for some of the other boards (i.e. not evb-rk3036/kylin-rk3036), due to unresolved symbols.
>>
>> Yes, Indeed.
>>
>> I've build those boards locally with gcc 6.3 and it was successful.
>
> The same one we use in travis-ci, from Linaro?

I've been using some OE build from yocto 2.3 SDK.

I will try to use the one from Linaro.

>
>> Regarding travis CI:
>>
>> With Eddie's patches it shows error:
>> https://travis-ci.org/lmajewski/u-boot-dfu/builds/268270904
>>
>> However, without Eddie's patches travis-CI doesn't show any errors:
>> https://travis-ci.org/lmajewski/u-boot-dfu/builds/268303030
>>
>>
>> Let's ask Tom (who has far more experience with travis-CI), if he
>> saw something like that before.
>
> Well, travis talks about using docker to replicate their environment,
> which means someone should be able to do that, get it to fail in a
> debugable environment and then move forward.

 From the sentence it seems like travis-ci is going to use docker. Is it 
correct?

Is it now possible to download the docker container for build testing?

>


-- 
Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de

[U-Boot] [PATCH v2 4/4] rockchip: enable rockusb for all rockchip SoCs

[Tom Rini]

On Sat, Aug 26, 2017 at 07:28:05PM +0200, Łukasz Majewski wrote:
> On 08/26/2017 02:46 PM, Tom Rini wrote:
> >On Fri, Aug 25, 2017 at 01:06:55PM +0200, Łukasz Majewski wrote:
> >>Hi Philipp, Andy, Tom
> >>>
> >>>>On 25 Aug 2017, at 03:51, Andy Yan <andyshrk@gmail.com> wrote:
> >>>>
> >>>>Hi Lukasz:
> >>>>
> >>>>2017-08-22 18:05 GMT+08:00 Łukasz Majewski <lukma at denx.de <mailto:lukma@denx.de>>:
> >>>>Hi Kever,
> >>>>
> >>>>
> >>>>Philipp,
> >>>>
> >>>>   I have no idea about the status of rockusb, it has been a long time
> >>>>on the list.
> >>>>
> >>>>Maybe Eddie or Lukasz have an answer?
> >>>>
> >>>>I've asked Eddie to fix issues with breaking other boards when enabling USB gadget infrastructure on RK.
> >>>>
> >>>>No reply since then.
> >>>>
> >>>>
> >>>>
> >>>>Eddie has fix all the issues he can reproduced on local。 The only problem now is that  the rk3036 based boards(evb-rk3036/kylin-rk3036) show compile errors on CI[0],
> >>>
> >>>The Travis log shows linker errors for some of the other boards (i.e. not evb-rk3036/kylin-rk3036), due to unresolved symbols.
> >>
> >>Yes, Indeed.
> >>
> >>I've build those boards locally with gcc 6.3 and it was successful.
> >
> >The same one we use in travis-ci, from Linaro?
> 
> I've been using some OE build from yocto 2.3 SDK.
> 
> I will try to use the one from Linaro.

Thanks.

> >>Regarding travis CI:
> >>
> >>With Eddie's patches it shows error:
> >>https://travis-ci.org/lmajewski/u-boot-dfu/builds/268270904
> >>
> >>However, without Eddie's patches travis-CI doesn't show any errors:
> >>https://travis-ci.org/lmajewski/u-boot-dfu/builds/268303030
> >>
> >>
> >>Let's ask Tom (who has far more experience with travis-CI), if he
> >>saw something like that before.
> >
> >Well, travis talks about using docker to replicate their environment,
> >which means someone should be able to do that, get it to fail in a
> >debugable environment and then move forward.
> 
> From the sentence it seems like travis-ci is going to use docker. Is
> it correct?
> 
> Is it now possible to download the docker container for build testing?

I don't have the link off-hand, but in part of the "debugging travis
build failures" pages travis-ci has, it talks about how to re-create the
build environment using Docker.

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20170827/f654e69a/attachment.sig>

[U-Boot] [PATCH v2 4/4] rockchip: enable rockusb for all rockchip SoCs

[Kever Yang]

Philipp,

     I have no idea about the status of rockusb, it has been a long time 
on the list.

Maybe Eddie or Lukasz have an answer?

I have to use those patches on my local branch, so that we don't have to 
enter

bootrom mode for firmware update.

Thanks,
- Kever
On 08/22/2017 04:44 PM, Dr. Philipp Tomsich wrote:
> Kever,
>
> I was about to apply the rockusb changes onto next yesterday, when I realised
> that rockusb hadn’t been merged on the USB side…
>
> Do you know the status on the rockusb patches?
> I’d like to avoid merging this on our end, before the infrastructure has been merged.
>
> Regards,
> Philipp.
>
>> On 22 Aug 2017, at 09:35, Kever Yang <kever.yang@rock-chips.com> wrote:
>>
>> Rockusb will be used by all the rockchip SoCs, enable it by
>> default in Kconfig, and it can be work if USB gadget is available.
>>
>> Signed-off-by: Kever Yang <kever.yang@rock-chips.com>
>> Acked-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
>> ---
>>
>> Changes in v2: None
>>
>> arch/arm/Kconfig | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
>> index da9324b..f566d50 100644
>> --- a/arch/arm/Kconfig
>> +++ b/arch/arm/Kconfig
>> @@ -1084,6 +1084,8 @@ config ARCH_ROCKCHIP
>> 	select DM_PWM
>> 	select DM_REGULATOR
>> 	imply FAT_WRITE
>> +	imply USB_FUNCTION_ROCKUSB
>> +	imply CMD_ROCKUSB
>>
>> config TARGET_THUNDERX_88XX
>> 	bool "Support ThunderX 88xx"
>> -- 
>> 1.9.1
>>
>

[U-Boot] [U-Boot, v2, 4/4] rockchip: enable rockusb for all rockchip SoCs

[Philipp Tomsich]

> Rockusb will be used by all the rockchip SoCs, enable it by
> default in Kconfig, and it can be work if USB gadget is available.
> 
> Signed-off-by: Kever Yang <kever.yang@rock-chips.com>
> Acked-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
> ---
> 
> Changes in v2: None
> 
>  arch/arm/Kconfig | 2 ++
>  1 file changed, 2 insertions(+)
> 

Reviewed-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>

[U-Boot] [U-Boot, v2, 1/4] rockchip: rk3229: move usb gadget into defconfig

[Philipp Tomsich]

> Use the defconfig for all usb gadget and function related
> option instead of define then in header file.
> 
> Signed-off-by: Kever Yang <kever.yang@rock-chips.com>
> Acked-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
> ---
> 
> Changes in v2: None
> 
>  configs/evb-rk3229_defconfig    | 17 +++++++++++++++++
>  include/configs/evb_rk3229.h    |  1 -
>  include/configs/rk322x_common.h | 20 --------------------
>  3 files changed, 17 insertions(+), 21 deletions(-)
> 

Reviewed-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>