From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 5/5] x86: acpi: Generate SPCR table
Date: Thu, 15 Nov 2018 19:58:54 +0200 [thread overview]
Message-ID: <20181115175854.7550-6-andriy.shevchenko@linux.intel.com> (raw)
In-Reply-To: <20181115175854.7550-1-andriy.shevchenko@linux.intel.com>
Microsoft specifies a SPCR (Serial Port Console Redirection Table) [1].
Let's provide it in U-Boot.
[1] https://msdn.microsoft.com/en-us/library/windows/hardware/dn639132(v=vs.85).aspx
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
arch/x86/include/asm/acpi_table.h | 2 +
arch/x86/lib/acpi_table.c | 85 +++++++++++++++++++++++++++++++
2 files changed, 87 insertions(+)
diff --git a/arch/x86/include/asm/acpi_table.h b/arch/x86/include/asm/acpi_table.h
index 51cc806673..e3b65cff66 100644
--- a/arch/x86/include/asm/acpi_table.h
+++ b/arch/x86/include/asm/acpi_table.h
@@ -327,6 +327,8 @@ struct acpi_global_nvs;
#define ACPI_DBG2_USB_XHCI 0x0000
#define ACPI_DBG2_USB_EHCI 0x0001
+#define ACPI_DBG2_UNKNOWN 0x00FF
+
/* SPCR (Serial Port Console Redirection table) */
struct __packed acpi_spcr {
struct acpi_table_header header;
diff --git a/arch/x86/lib/acpi_table.c b/arch/x86/lib/acpi_table.c
index c6b2026613..d8b44aea02 100644
--- a/arch/x86/lib/acpi_table.c
+++ b/arch/x86/lib/acpi_table.c
@@ -12,6 +12,7 @@
#include <cpu.h>
#include <dm.h>
#include <dm/uclass-internal.h>
+#include <serial.h>
#include <version.h>
#include <asm/acpi/global_nvs.h>
#include <asm/acpi_table.h>
@@ -338,6 +339,82 @@ static void acpi_create_mcfg(struct acpi_mcfg *mcfg)
header->checksum = table_compute_checksum((void *)mcfg, header->length);
}
+static void acpi_create_spcr(struct acpi_spcr *spcr)
+{
+ struct acpi_table_header *header = &(spcr->header);
+ struct serial_device_info info = {0};
+ int access_size;
+ int ret;
+
+ /* Fill out header fields */
+ acpi_fill_header(header, "SPCR");
+ header->length = sizeof(struct acpi_spcr);
+ header->revision = 2;
+
+ ret = serial_getinfo(&info);
+ if (ret)
+ spcr->interface_type = ACPI_DBG2_UNKNOWN;
+ else
+ spcr->interface_type = ACPI_DBG2_16550_COMPATIBLE;
+ debug("UART type %u (serial_getinfo() rc=%d)\n", spcr->interface_type, ret);
+
+ /* Encode baud rate */
+ switch (info.baudrate) {
+ case 9600:
+ spcr->baud_rate = 3;
+ break;
+ case 19200:
+ spcr->baud_rate = 4;
+ break;
+ case 57600:
+ spcr->baud_rate = 6;
+ break;
+ case 115200:
+ spcr->baud_rate = 7;
+ break;
+ default:
+ spcr->baud_rate = 0;
+ break;
+ }
+
+ /* Encode register access size */
+ switch (info.reg_shift) {
+ case 0:
+ access_size = ACPI_ACCESS_SIZE_BYTE_ACCESS;
+ break;
+ case 1:
+ access_size = ACPI_ACCESS_SIZE_WORD_ACCESS;
+ break;
+ case 2:
+ access_size = ACPI_ACCESS_SIZE_DWORD_ACCESS;
+ break;
+ case 3:
+ access_size = ACPI_ACCESS_SIZE_QWORD_ACCESS;
+ break;
+ default:
+ access_size = ACPI_ACCESS_SIZE_UNDEFINED;
+ break;
+ }
+
+ spcr->serial_port.space_id = ACPI_ADDRESS_SPACE_MEMORY;
+ spcr->serial_port.bit_width = info.reg_width;
+ spcr->serial_port.bit_offset = info.reg_offset;
+ spcr->serial_port.access_size = access_size;
+ spcr->serial_port.addrl = info.addr >> 0;
+ spcr->serial_port.addrh = info.addr >> 32;
+
+ /* REVISIT: Hard coded values for now */
+ spcr->parity = 0;
+ spcr->stop_bits = 1;
+
+ /* REVISIT: No PCI devices for now */
+ spcr->pci_device_id = 0xffff;
+ spcr->pci_vendor_id = 0xffff;
+
+ /* Fix checksum */
+ header->checksum = table_compute_checksum((void *)spcr, header->length);
+}
+
/*
* QEMU's version of write_acpi_tables is defined in drivers/misc/qfw.c
*/
@@ -352,6 +429,7 @@ ulong write_acpi_tables(ulong start)
struct acpi_fadt *fadt;
struct acpi_mcfg *mcfg;
struct acpi_madt *madt;
+ struct acpi_spcr *spcr;
int i;
current = start;
@@ -440,6 +518,13 @@ ulong write_acpi_tables(ulong start)
acpi_add_table(rsdp, mcfg);
current = ALIGN(current, 16);
+ debug("ACPI: * SPCR\n");
+ spcr = (struct acpi_spcr *)current;
+ acpi_create_spcr(spcr);
+ current += spcr->header.length;
+ acpi_add_table(rsdp, spcr);
+ current = ALIGN(current, 16);
+
debug("current = %x\n", current);
acpi_rsdp_addr = (unsigned long)rsdp;
--
2.19.1
next prev parent reply other threads:[~2018-11-15 17:58 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-15 17:58 [U-Boot] [PATCH v2 0/5] ACPI: Generate SPCR table Andy Shevchenko
2018-11-15 17:58 ` [U-Boot] [PATCH v2 1/5] serial: Introduce ->getinfo() callback Andy Shevchenko
2018-11-15 18:22 ` Alexander Graf
2018-11-15 19:31 ` Andy Shevchenko
2018-11-15 20:09 ` Alexander Graf
2018-11-20 18:27 ` Andy Shevchenko
2018-11-15 19:45 ` Simon Glass
2018-11-15 19:51 ` Andy Shevchenko
2018-11-15 20:22 ` Simon Glass
2018-11-20 17:39 ` Andy Shevchenko
2018-11-20 18:32 ` Andy Shevchenko
2018-11-20 22:04 ` Alexander Graf
2018-11-20 22:16 ` Andy Shevchenko
2018-11-15 17:58 ` [U-Boot] [PATCH v2 2/5] serial: ns16550: Read reg-io-width from device tree Andy Shevchenko
2018-11-15 18:28 ` Alexander Graf
2018-11-15 19:33 ` Andy Shevchenko
2018-11-15 20:12 ` Alexander Graf
2018-11-15 19:45 ` Simon Glass
2018-11-15 19:53 ` Andy Shevchenko
2018-11-15 17:58 ` [U-Boot] [PATCH v2 3/5] serial: ns16550: Provide ->getinfo() implementation Andy Shevchenko
2018-11-15 18:30 ` Alexander Graf
2018-11-15 19:37 ` Andy Shevchenko
2018-11-15 19:45 ` Simon Glass
2018-11-15 17:58 ` [U-Boot] [PATCH v2 4/5] x86: acpi: Add SPCR table description Andy Shevchenko
2018-11-18 12:37 ` Bin Meng
2018-11-15 17:58 ` Andy Shevchenko [this message]
2018-11-15 18:27 ` [U-Boot] [PATCH v2 5/5] x86: acpi: Generate SPCR table Alexander Graf
2018-11-15 19:43 ` Andy Shevchenko
2018-11-15 20:19 ` Alexander Graf
2018-11-20 21:06 ` Andy Shevchenko
2018-11-18 12:37 ` Bin Meng
2018-11-20 20:47 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181115175854.7550-6-andriy.shevchenko@linux.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox