From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 1/5] serial: Introduce ->getinfo() callback
Date: Tue, 20 Nov 2018 20:32:06 +0200 [thread overview]
Message-ID: <20181120183206.GE10650@smile.fi.intel.com> (raw)
In-Reply-To: <CAPnjgZ15iujg9h2wVaDVKhd0KnTffMUCJPDiBVfLk49COy+8Tw@mail.gmail.com>
On Thu, Nov 15, 2018 at 11:45:32AM -0800, Simon Glass wrote:
> On 15 November 2018 at 09:58, Andy Shevchenko
> <andriy.shevchenko@linux.intel.com> wrote:
> > +/* REVISIT: ACPI GAS specification implied */
> > +struct serial_device_info {
> > + unsigned int baudrate;
> > + u8 addr_space; /* 0 - MMIO, 1 - IO */
>
> Please make this an enum
OK.
>
> > + u8 reg_width;
> > + u8 reg_offset;
> > + u8 reg_shift;
> > + u64 addr;
>
> ulong
This, unfortunately, will not work. ACPI takes the address as 32-bit halves,
and shift to 32 on 32-bit platform is UB.
> Needs a struct comment as I don't know what most of these do.
OK.
> What about parity, number of bits, etc?
As discussed before, it will be filled thru getconfig().
Though, I would add necessary members explicitly.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2018-11-20 18:32 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-15 17:58 [U-Boot] [PATCH v2 0/5] ACPI: Generate SPCR table Andy Shevchenko
2018-11-15 17:58 ` [U-Boot] [PATCH v2 1/5] serial: Introduce ->getinfo() callback Andy Shevchenko
2018-11-15 18:22 ` Alexander Graf
2018-11-15 19:31 ` Andy Shevchenko
2018-11-15 20:09 ` Alexander Graf
2018-11-20 18:27 ` Andy Shevchenko
2018-11-15 19:45 ` Simon Glass
2018-11-15 19:51 ` Andy Shevchenko
2018-11-15 20:22 ` Simon Glass
2018-11-20 17:39 ` Andy Shevchenko
2018-11-20 18:32 ` Andy Shevchenko [this message]
2018-11-20 22:04 ` Alexander Graf
2018-11-20 22:16 ` Andy Shevchenko
2018-11-15 17:58 ` [U-Boot] [PATCH v2 2/5] serial: ns16550: Read reg-io-width from device tree Andy Shevchenko
2018-11-15 18:28 ` Alexander Graf
2018-11-15 19:33 ` Andy Shevchenko
2018-11-15 20:12 ` Alexander Graf
2018-11-15 19:45 ` Simon Glass
2018-11-15 19:53 ` Andy Shevchenko
2018-11-15 17:58 ` [U-Boot] [PATCH v2 3/5] serial: ns16550: Provide ->getinfo() implementation Andy Shevchenko
2018-11-15 18:30 ` Alexander Graf
2018-11-15 19:37 ` Andy Shevchenko
2018-11-15 19:45 ` Simon Glass
2018-11-15 17:58 ` [U-Boot] [PATCH v2 4/5] x86: acpi: Add SPCR table description Andy Shevchenko
2018-11-18 12:37 ` Bin Meng
2018-11-15 17:58 ` [U-Boot] [PATCH v2 5/5] x86: acpi: Generate SPCR table Andy Shevchenko
2018-11-15 18:27 ` Alexander Graf
2018-11-15 19:43 ` Andy Shevchenko
2018-11-15 20:19 ` Alexander Graf
2018-11-20 21:06 ` Andy Shevchenko
2018-11-18 12:37 ` Bin Meng
2018-11-20 20:47 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181120183206.GE10650@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox