From: Boris Brezillon <boris.brezillon@bootlin.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v3 06/11] mtd: Be more strict on the "mtdparts=" prefix check
Date: Mon, 19 Nov 2018 21:59:50 +0100 [thread overview]
Message-ID: <20181119205955.32042-7-boris.brezillon@bootlin.com> (raw)
In-Reply-To: <20181119205955.32042-1-boris.brezillon@bootlin.com>
strstr() does not guarantee that the string we're searching for is
placed at the beginning. Use strncmp() instead.
Fixes: 5db66b3aee6f ("cmd: mtd: add 'mtd' command")
Signed-off-by: Boris Brezillon <boris.brezillon@bootlin.com>
---
Changes in v3:
- None
Changes in v2:
- New patch
---
drivers/mtd/mtd_uboot.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mtd/mtd_uboot.c b/drivers/mtd/mtd_uboot.c
index c4434d70520d..d551aee20203 100644
--- a/drivers/mtd/mtd_uboot.c
+++ b/drivers/mtd/mtd_uboot.c
@@ -215,7 +215,7 @@ int mtd_probe_devices(void)
return 0;
/* Start the parsing by ignoring the extra 'mtdparts=' prefix, if any */
- if (strstr(mtdparts, "mtdparts="))
+ if (!strncmp(mtdparts, "mtdparts=", sizeof("mtdparts=") - 1))
mtdparts += 9;
/* For each MTD device in mtdparts */
--
2.17.1
next prev parent reply other threads:[~2018-11-19 20:59 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-19 20:59 [U-Boot] [PATCH v3 00/11] mtd/sf: Various fixes Boris Brezillon
2018-11-19 20:59 ` [U-Boot] [PATCH v3 01/11] mtd: Add a function to report when the MTD dev list has been updated Boris Brezillon
2018-11-21 6:44 ` Heiko Schocher
2018-11-19 20:59 ` [U-Boot] [PATCH v3 02/11] mtd: Parse mtdparts/mtdids again when the MTD " Boris Brezillon
2018-11-21 6:44 ` Heiko Schocher
2018-11-19 20:59 ` [U-Boot] [PATCH v3 03/11] mtd: Delete partitions attached to the device when a device is deleted Boris Brezillon
2018-11-21 6:44 ` Heiko Schocher
2018-11-22 8:32 ` Boris Brezillon
2018-11-19 20:59 ` [U-Boot] [PATCH v3 04/11] mtd: sf: Make sure we don't register the same device twice Boris Brezillon
2018-11-21 6:45 ` Heiko Schocher
2018-11-22 7:04 ` Jagan Teki
2018-11-19 20:59 ` [U-Boot] [PATCH v3 05/11] mtd: Use get_mtdids() instead of env_get("mtdids") in mtd_search_alternate_name() Boris Brezillon
2018-11-21 6:45 ` Heiko Schocher
2018-11-19 20:59 ` Boris Brezillon [this message]
2018-11-21 6:45 ` [U-Boot] [PATCH v3 06/11] mtd: Be more strict on the "mtdparts=" prefix check Heiko Schocher
2018-11-19 20:59 ` [U-Boot] [PATCH v3 07/11] mtd: Make sure the name passed in mtdparts fits in mtd_name[] Boris Brezillon
2018-11-21 6:45 ` Heiko Schocher
2018-11-19 20:59 ` [U-Boot] [PATCH v3 08/11] mtd: Make sure we don't parse MTD partitions belonging to another dev Boris Brezillon
2018-11-21 6:46 ` Heiko Schocher
2018-11-19 20:59 ` [U-Boot] [PATCH v3 09/11] mtd: Don't stop MTD partition creation when it fails on one device Boris Brezillon
2018-11-21 6:46 ` Heiko Schocher
2018-11-19 20:59 ` [U-Boot] [PATCH v3 10/11] mtd: sf: Unregister the MTD device prior to removing the spi_flash obj Boris Brezillon
2018-11-21 6:47 ` Heiko Schocher
2018-11-22 7:06 ` Jagan Teki
2018-11-19 20:59 ` [U-Boot] [PATCH v3 11/11] mtd: sf: Make sf_mtd.c more robust Boris Brezillon
2018-11-21 6:47 ` Heiko Schocher
2018-11-22 7:10 ` Jagan Teki
2018-11-22 8:40 ` Boris Brezillon
2018-11-26 8:42 ` Boris Brezillon
2018-11-26 11:12 ` Jagan Teki
2018-11-26 12:37 ` Boris Brezillon
2018-11-26 12:42 ` Boris Brezillon
2018-11-26 13:05 ` Jagan Teki
2018-11-26 13:25 ` Miquel Raynal
2018-11-27 12:36 ` Boris Brezillon
2018-11-27 15:44 ` Jagan Teki
2018-11-19 21:02 ` [U-Boot] [PATCH v3 00/11] mtd/sf: Various fixes Boris Brezillon
2018-11-21 6:43 ` Heiko Schocher
2018-11-21 12:58 ` Boris Brezillon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181119205955.32042-7-boris.brezillon@bootlin.com \
--to=boris.brezillon@bootlin.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox