From: Heiko Schocher <hs@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v3 09/11] mtd: Don't stop MTD partition creation when it fails on one device
Date: Wed, 21 Nov 2018 07:46:46 +0100 [thread overview]
Message-ID: <c7d2f9c6-b4e7-985b-dffc-540fe526b549@denx.de> (raw)
In-Reply-To: <20181119205955.32042-10-boris.brezillon@bootlin.com>
Hello Boris,
Am 19.11.2018 um 21:59 schrieb Boris Brezillon:
> MTD partition creation code is a bit tricky. It tries to figure out
> when things have changed (either MTD dev list or mtdparts/mtdids vars)
> and when that happens it first deletes all the partitions that had been
> previously created and then creates the new ones based on the new
> mtdparts/mtdids values.
> But before deleting the old partitions, it ensures that none of the
> currently registered parts are being used and bails out when that's
> not the case. So, we end up in a situation where, if at least one MTD
> dev has one of its partitions used by someone (UBI for instance), the
> partitions update logic no longer works for other devs.
>
> Rework the code to relax the logic and allow updates of MTD parts on
> devices that are not being used (we still refuse to updates parts on
> devices who have at least one of their partitions used by someone).
>
> Fixes: 5db66b3aee6f ("cmd: mtd: add 'mtd' command")
> Signed-off-by: Boris Brezillon <boris.brezillon@bootlin.com>
> ---
> Changes in v3:
> - None
>
> Changes in v2:
> - New patch
>
> Changes in v3:
> - Re-create partitions when our last attempt do delete all existing
> parts failed. This way we can update parts after ubi detach has
> been called without having to change mtdparts/mtdids.
> ---
> drivers/mtd/mtd_uboot.c | 96 +++++++++++++++++++++++++++++------------
> drivers/mtd/mtdpart.c | 12 ++++++
> include/linux/mtd/mtd.h | 2 +
> 3 files changed, 82 insertions(+), 28 deletions(-)
Tested-by: Heiko Schocher <hs@denx.de>
bye,
Heiko
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-52 Fax: +49-8142-66989-80 Email: hs at denx.de
next prev parent reply other threads:[~2018-11-21 6:46 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-19 20:59 [U-Boot] [PATCH v3 00/11] mtd/sf: Various fixes Boris Brezillon
2018-11-19 20:59 ` [U-Boot] [PATCH v3 01/11] mtd: Add a function to report when the MTD dev list has been updated Boris Brezillon
2018-11-21 6:44 ` Heiko Schocher
2018-11-19 20:59 ` [U-Boot] [PATCH v3 02/11] mtd: Parse mtdparts/mtdids again when the MTD " Boris Brezillon
2018-11-21 6:44 ` Heiko Schocher
2018-11-19 20:59 ` [U-Boot] [PATCH v3 03/11] mtd: Delete partitions attached to the device when a device is deleted Boris Brezillon
2018-11-21 6:44 ` Heiko Schocher
2018-11-22 8:32 ` Boris Brezillon
2018-11-19 20:59 ` [U-Boot] [PATCH v3 04/11] mtd: sf: Make sure we don't register the same device twice Boris Brezillon
2018-11-21 6:45 ` Heiko Schocher
2018-11-22 7:04 ` Jagan Teki
2018-11-19 20:59 ` [U-Boot] [PATCH v3 05/11] mtd: Use get_mtdids() instead of env_get("mtdids") in mtd_search_alternate_name() Boris Brezillon
2018-11-21 6:45 ` Heiko Schocher
2018-11-19 20:59 ` [U-Boot] [PATCH v3 06/11] mtd: Be more strict on the "mtdparts=" prefix check Boris Brezillon
2018-11-21 6:45 ` Heiko Schocher
2018-11-19 20:59 ` [U-Boot] [PATCH v3 07/11] mtd: Make sure the name passed in mtdparts fits in mtd_name[] Boris Brezillon
2018-11-21 6:45 ` Heiko Schocher
2018-11-19 20:59 ` [U-Boot] [PATCH v3 08/11] mtd: Make sure we don't parse MTD partitions belonging to another dev Boris Brezillon
2018-11-21 6:46 ` Heiko Schocher
2018-11-19 20:59 ` [U-Boot] [PATCH v3 09/11] mtd: Don't stop MTD partition creation when it fails on one device Boris Brezillon
2018-11-21 6:46 ` Heiko Schocher [this message]
2018-11-19 20:59 ` [U-Boot] [PATCH v3 10/11] mtd: sf: Unregister the MTD device prior to removing the spi_flash obj Boris Brezillon
2018-11-21 6:47 ` Heiko Schocher
2018-11-22 7:06 ` Jagan Teki
2018-11-19 20:59 ` [U-Boot] [PATCH v3 11/11] mtd: sf: Make sf_mtd.c more robust Boris Brezillon
2018-11-21 6:47 ` Heiko Schocher
2018-11-22 7:10 ` Jagan Teki
2018-11-22 8:40 ` Boris Brezillon
2018-11-26 8:42 ` Boris Brezillon
2018-11-26 11:12 ` Jagan Teki
2018-11-26 12:37 ` Boris Brezillon
2018-11-26 12:42 ` Boris Brezillon
2018-11-26 13:05 ` Jagan Teki
2018-11-26 13:25 ` Miquel Raynal
2018-11-27 12:36 ` Boris Brezillon
2018-11-27 15:44 ` Jagan Teki
2018-11-19 21:02 ` [U-Boot] [PATCH v3 00/11] mtd/sf: Various fixes Boris Brezillon
2018-11-21 6:43 ` Heiko Schocher
2018-11-21 12:58 ` Boris Brezillon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c7d2f9c6-b4e7-985b-dffc-540fe526b549@denx.de \
--to=hs@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox