* [U-Boot] [PATCH] apalis_imx6: fix set_emmcargs wrapper @ 2019-06-25 11:48 Igor Opaniuk 2019-06-26 7:37 ` Philippe Schenker 0 siblings, 1 reply; 4+ messages in thread From: Igor Opaniuk @ 2019-06-25 11:48 UTC (permalink / raw) To: u-boot From: Igor Opaniuk <igor.opaniuk@toradex.com> Fix set_emmcargs wrapper, which prepares proper bootargs for booting from eMMC. Signed-off-by: Igor Opaniuk <igor.opaniuk@toradex.com> --- include/configs/apalis_imx6.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/configs/apalis_imx6.h b/include/configs/apalis_imx6.h index 4b0a3fb26b..cffb90a690 100644 --- a/include/configs/apalis_imx6.h +++ b/include/configs/apalis_imx6.h @@ -121,8 +121,8 @@ "imx6q-apalis-cam-eval.dtb fat 0 1" #define EMMC_BOOTCMD \ - "set_emmcargs emmcargs ip=off root=PARTUUID=${uuid} ro,noatime " \ - "rootfstype=ext4 rootwait\0" \ + "set_emmcargs=setenv emmcargs ip=off root=PARTUUID=${uuid} " \ + "ro,noatime rootfstype=ext4 rootwait\0" \ "emmcboot=run setup; run emmcfinduuid; run set_emmcargs; " \ "setenv bootargs ${defargs} ${emmcargs} ${setupargs} " \ "${vidargs}; echo Booting from internal eMMC chip...; " \ -- 2.17.1 ^ permalink raw reply related [flat|nested] 4+ messages in thread
* [U-Boot] [PATCH] apalis_imx6: fix set_emmcargs wrapper 2019-06-25 11:48 [U-Boot] [PATCH] apalis_imx6: fix set_emmcargs wrapper Igor Opaniuk @ 2019-06-26 7:37 ` Philippe Schenker 2019-06-27 9:26 ` Igor Opaniuk 0 siblings, 1 reply; 4+ messages in thread From: Philippe Schenker @ 2019-06-26 7:37 UTC (permalink / raw) To: u-boot On Tue, 2019-06-25 at 14:48 +0300, Igor Opaniuk wrote: > From: Igor Opaniuk <igor.opaniuk@toradex.com> > > Fix set_emmcargs wrapper, which prepares proper bootargs for booting > from eMMC. > > Signed-off-by: Igor Opaniuk <igor.opaniuk@toradex.com> Reviewed-by: Philippe Schenker <philippe.schenker@toradex.com> > --- > include/configs/apalis_imx6.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/include/configs/apalis_imx6.h b/include/configs/apalis_imx6.h > index 4b0a3fb26b..cffb90a690 100644 > --- a/include/configs/apalis_imx6.h > +++ b/include/configs/apalis_imx6.h > @@ -121,8 +121,8 @@ > "imx6q-apalis-cam-eval.dtb fat 0 1" > > #define EMMC_BOOTCMD \ > - "set_emmcargs emmcargs ip=off root=PARTUUID=${uuid} ro,noatime " \ > - "rootfstype=ext4 rootwait\0" \ > + "set_emmcargs=setenv emmcargs ip=off root=PARTUUID=${uuid} " \ > + "ro,noatime rootfstype=ext4 rootwait\0" \ > "emmcboot=run setup; run emmcfinduuid; run set_emmcargs; " \ > "setenv bootargs ${defargs} ${emmcargs} ${setupargs} " \ > "${vidargs}; echo Booting from internal eMMC chip...; " \ ^ permalink raw reply [flat|nested] 4+ messages in thread
* [U-Boot] [PATCH] apalis_imx6: fix set_emmcargs wrapper 2019-06-26 7:37 ` Philippe Schenker @ 2019-06-27 9:26 ` Igor Opaniuk 2019-06-27 11:08 ` Stefano Babic 0 siblings, 1 reply; 4+ messages in thread From: Igor Opaniuk @ 2019-06-27 9:26 UTC (permalink / raw) To: u-boot Hi Stefano, On Wed, Jun 26, 2019 at 10:37 AM Philippe Schenker <dev@pschenker.ch> wrote: > > On Tue, 2019-06-25 at 14:48 +0300, Igor Opaniuk wrote: > > From: Igor Opaniuk <igor.opaniuk@toradex.com> > > > > Fix set_emmcargs wrapper, which prepares proper bootargs for booting > > from eMMC. > > > > Signed-off-by: Igor Opaniuk <igor.opaniuk@toradex.com> > > Reviewed-by: Philippe Schenker <philippe.schenker@toradex.com> > > > --- > > include/configs/apalis_imx6.h | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/include/configs/apalis_imx6.h b/include/configs/apalis_imx6.h > > index 4b0a3fb26b..cffb90a690 100644 > > --- a/include/configs/apalis_imx6.h > > +++ b/include/configs/apalis_imx6.h > > @@ -121,8 +121,8 @@ > > "imx6q-apalis-cam-eval.dtb fat 0 1" > > > > #define EMMC_BOOTCMD \ > > - "set_emmcargs emmcargs ip=off root=PARTUUID=${uuid} ro,noatime " \ > > - "rootfstype=ext4 rootwait\0" \ > > + "set_emmcargs=setenv emmcargs ip=off root=PARTUUID=${uuid} " \ > > + "ro,noatime rootfstype=ext4 rootwait\0" \ > > "emmcboot=run setup; run emmcfinduuid; run set_emmcargs; " \ > > "setenv bootargs ${defargs} ${emmcargs} ${setupargs} " \ > > "${vidargs}; echo Booting from internal eMMC chip...; " \ > This is a bug fix, currently boot on Apalis iMX6 is broken. could you please apply this patch so it's included in v2019.07 release? Thanks! -- Best regards - Freundliche Grüsse - Meilleures salutations Igor Opaniuk mailto: igor.opaniuk at gmail.com skype: igor.opanyuk +380 (93) 836 40 67 http://ua.linkedin.com/in/iopaniuk ^ permalink raw reply [flat|nested] 4+ messages in thread
* [U-Boot] [PATCH] apalis_imx6: fix set_emmcargs wrapper 2019-06-27 9:26 ` Igor Opaniuk @ 2019-06-27 11:08 ` Stefano Babic 0 siblings, 0 replies; 4+ messages in thread From: Stefano Babic @ 2019-06-27 11:08 UTC (permalink / raw) To: u-boot Hi Igor, On 27/06/19 11:26, Igor Opaniuk wrote: > Hi Stefano, > > On Wed, Jun 26, 2019 at 10:37 AM Philippe Schenker <dev@pschenker.ch> wrote: >> >> On Tue, 2019-06-25 at 14:48 +0300, Igor Opaniuk wrote: >>> From: Igor Opaniuk <igor.opaniuk@toradex.com> >>> >>> Fix set_emmcargs wrapper, which prepares proper bootargs for booting >>> from eMMC. >>> >>> Signed-off-by: Igor Opaniuk <igor.opaniuk@toradex.com> >> >> Reviewed-by: Philippe Schenker <philippe.schenker@toradex.com> >> >>> --- >>> include/configs/apalis_imx6.h | 4 ++-- >>> 1 file changed, 2 insertions(+), 2 deletions(-) >>> >>> diff --git a/include/configs/apalis_imx6.h b/include/configs/apalis_imx6.h >>> index 4b0a3fb26b..cffb90a690 100644 >>> --- a/include/configs/apalis_imx6.h >>> +++ b/include/configs/apalis_imx6.h >>> @@ -121,8 +121,8 @@ >>> "imx6q-apalis-cam-eval.dtb fat 0 1" >>> >>> #define EMMC_BOOTCMD \ >>> - "set_emmcargs emmcargs ip=off root=PARTUUID=${uuid} ro,noatime " \ >>> - "rootfstype=ext4 rootwait\0" \ >>> + "set_emmcargs=setenv emmcargs ip=off root=PARTUUID=${uuid} " \ >>> + "ro,noatime rootfstype=ext4 rootwait\0" \ >>> "emmcboot=run setup; run emmcfinduuid; run set_emmcargs; " \ >>> "setenv bootargs ${defargs} ${emmcargs} ${setupargs} " \ >>> "${vidargs}; echo Booting from internal eMMC chip...; " \ >> > > This is a bug fix, currently boot on Apalis iMX6 is broken. > could you please apply this patch so it's included in v2019.07 release? > I pick it up, I am sorting which fixes I should take for release. Thanks ! Best regards, Stefano -- ===================================================================== DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de ===================================================================== ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-06-27 11:08 UTC | newest] Thread overview: 4+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2019-06-25 11:48 [U-Boot] [PATCH] apalis_imx6: fix set_emmcargs wrapper Igor Opaniuk 2019-06-26 7:37 ` Philippe Schenker 2019-06-27 9:26 ` Igor Opaniuk 2019-06-27 11:08 ` Stefano Babic
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox