From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] spl: fix entry_point equal to load_addr
Date: Fri, 6 Dec 2019 08:44:28 -0500 [thread overview]
Message-ID: <20191206134428.GI9549@bill-the-cat> (raw)
In-Reply-To: <CAAh8qsycEvxrGDTirQaKGO3F_iuMLjJhjOVHUgMojX_Qf0MJiQ@mail.gmail.com>
On Fri, Dec 06, 2019 at 02:37:52PM +0100, Simon Goldschmidt wrote:
> On Fri, Dec 6, 2019 at 2:34 PM Tom Rini <trini@konsulko.com> wrote:
> >
> > On Fri, Dec 06, 2019 at 01:58:46PM +0100, Simon Goldschmidt wrote:
> > > On Fri, Dec 6, 2019 at 1:46 PM Patrice CHOTARD <patrice.chotard@st.com> wrote:
> > > >
> > > > Hi
> > > >
> > > > This patch is breaking the STM32MP15 basic boot (spl => u-boot).
> > >
> > > Looking at socfpga gen5 u-boot.img, this is probably broken as well.
> > >
> > > And I don't even see any RB or TB tags here :-(
> >
> > Ugh, what the heck? I applied this because I looked over the changes
> > and they seemed correct. I'm quite willing to just revert this but I
> > would like to know how it's breaking. Sorry all!
>
> Looking at the branch a few lines up I can understand why this seemed
> like a small change. I hadn't seen this before Patrice's mail, either.
>
> Let me test this on socfpga_socrates tomorrow, I could still be wrong since
> this is from reading the code and binary only. But entry_point should be 0
> in my u-boot.img if I'm not mistaken, and that should break it.
Maybe I just haven't had enough coffee or time to think, but that sounds
like entry_point being set wrong somewhere. Of course, if it's being
set wrong somewhere and it's not self-contained within U-Boot to correct
it (iow external scripts/docs), we have to deal with that reality.
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20191206/93682a81/attachment.sig>
next prev parent reply other threads:[~2019-12-06 13:44 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-25 16:18 [U-Boot] [PATCH] spl: fix entry_point equal to load_addr Giulio Benetti
2019-12-05 22:09 ` Tom Rini
2019-12-06 12:46 ` Patrice CHOTARD
2019-12-06 12:58 ` Simon Goldschmidt
2019-12-06 13:34 ` Tom Rini
2019-12-06 13:37 ` Simon Goldschmidt
2019-12-06 13:44 ` Tom Rini [this message]
2019-12-06 13:48 ` Giulio Benetti
2019-12-06 14:04 ` Patrice CHOTARD
2019-12-06 17:23 ` Giulio Benetti
2019-12-06 14:05 ` Simon Goldschmidt
2019-12-06 14:55 ` Tom Rini
2019-12-07 21:28 ` Simon Goldschmidt
2020-01-10 14:57 ` Giulio Benetti
2020-01-10 21:51 ` Tom Rini
2020-01-16 14:40 ` Tom Rini
2020-01-16 14:46 ` Giulio Benetti
2020-01-16 14:49 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191206134428.GI9549@bill-the-cat \
--to=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox