From: Giulio Benetti <giulio.benetti@benettiengineering.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] spl: fix entry_point equal to load_addr
Date: Thu, 16 Jan 2020 15:46:15 +0100 [thread overview]
Message-ID: <ffb53fb9-06cd-0d61-0752-414e5653db8a@benettiengineering.com> (raw)
In-Reply-To: <20200116144049.GA8732@bill-the-cat>
Hi Tom,
+Stefano B.
On 1/16/20 3:40 PM, Tom Rini wrote:
> On Mon, Nov 25, 2019 at 05:18:20PM +0100, Giulio Benetti wrote:
>
>> At the moment entry_point is set to image_get_load(header) that sets it
>> to "load address" instead of "entry point", assuming entry_point is
>> equal to load_addr, but it's not true. Then load_addr is set to
>> "entry_point - header_size", but this is wrong too since load_addr is
>> not an entry point.
>>
>> So use image_get_ep() for entry_point assignment and image_get_load()
>> for load_addr assignment.
>>
>> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
>
> Applied to u-boot/master, thanks!
It's been already committed by Stefano Babic in imx and you've pulled
from him.
Sorry that I've submitted it twice!
Best regards
--
Giulio Benetti
Benetti Engineering sas
next prev parent reply other threads:[~2020-01-16 14:46 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-25 16:18 [U-Boot] [PATCH] spl: fix entry_point equal to load_addr Giulio Benetti
2019-12-05 22:09 ` Tom Rini
2019-12-06 12:46 ` Patrice CHOTARD
2019-12-06 12:58 ` Simon Goldschmidt
2019-12-06 13:34 ` Tom Rini
2019-12-06 13:37 ` Simon Goldschmidt
2019-12-06 13:44 ` Tom Rini
2019-12-06 13:48 ` Giulio Benetti
2019-12-06 14:04 ` Patrice CHOTARD
2019-12-06 17:23 ` Giulio Benetti
2019-12-06 14:05 ` Simon Goldschmidt
2019-12-06 14:55 ` Tom Rini
2019-12-07 21:28 ` Simon Goldschmidt
2020-01-10 14:57 ` Giulio Benetti
2020-01-10 21:51 ` Tom Rini
2020-01-16 14:40 ` Tom Rini
2020-01-16 14:46 ` Giulio Benetti [this message]
2020-01-16 14:49 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ffb53fb9-06cd-0d61-0752-414e5653db8a@benettiengineering.com \
--to=giulio.benetti@benettiengineering.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox