[PATCH v2 0/4] Various i.MXRT bug/typo fixes

[PATCH v2 0/4] Various i.MXRT bug/typo fixes

[Giulio Benetti]

Hi Anatolij, Lukasz, Stefano, Fabio, All,

this patchset fix 2 bugs preventing from LCDIF to work when booting from
sd-card. There are also 2 little typo fixes for boards READMEs.

V1->V2:
* modify mxfsb.c patch as suggested by Fabio

Giulio Benetti (4):
  imxrt1050-evk: README: fix dd command destination
  imxrt1020-evk: README: fix dd command destination
  video: mxsfb: add clk_enable()
  clk: imx: clk-imxrt1050: fix lcdif clock gate

 board/freescale/imxrt1020-evk/README | 2 +-
 board/freescale/imxrt1050-evk/README | 2 +-
 drivers/clk/imx/clk-imxrt1050.c      | 2 +-
 drivers/video/mxsfb.c                | 6 ++++++
 4 files changed, 9 insertions(+), 3 deletions(-)

-- 
2.20.1

[PATCH v2 1/4] imxrt1050-evk: README: fix dd command destination

[Giulio Benetti]

Make "of=" the same for the 2 commands since we're writing to the same
sd-card.

Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
---
 board/freescale/imxrt1050-evk/README | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/board/freescale/imxrt1050-evk/README b/board/freescale/imxrt1050-evk/README
index f7e2894025..55b6a0877a 100644
--- a/board/freescale/imxrt1050-evk/README
+++ b/board/freescale/imxrt1050-evk/README
@@ -11,7 +11,7 @@ This will generate the SPL image called SPL and the u-boot.img.
 
 - Flash the SPL image into the micro SD card:
 
-sudo dd if=SPL of=/dev/mmcblk0 bs=1k seek=1; sync
+sudo dd if=SPL of=/dev/sdb bs=1k seek=1; sync
 
 - Flash the u-boot.img image into the micro SD card:
 
-- 
2.20.1

[PATCH v2 2/4] imxrt1020-evk: README: fix dd command destination

[Giulio Benetti]

Make "of=" the same for the 2 commands since we're writing to the
same sd-card.

Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
---
 board/freescale/imxrt1020-evk/README | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/board/freescale/imxrt1020-evk/README b/board/freescale/imxrt1020-evk/README
index 3da72fdad2..bcb3683163 100644
--- a/board/freescale/imxrt1020-evk/README
+++ b/board/freescale/imxrt1020-evk/README
@@ -11,7 +11,7 @@ This will generate the SPL image called SPL and the u-boot.img.
 
 - Flash the SPL image into the micro SD card:
 
-sudo dd if=SPL of=/dev/mmcblk0 bs=1k seek=1; sync
+sudo dd if=SPL of=/dev/sdb bs=1k seek=1; sync
 
 - Flash the u-boot.img image into the micro SD card:
 
-- 
2.20.1

[PATCH v2 3/4] video: mxsfb: add clk_enable()

[Giulio Benetti]

BROM doesn't enable lcdif by default so add clk_enable() after
clk_set_rate().

Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
---
V1->V2:
* call clk_enable() after clk_set_rate() as suggested by Fabio
---
 drivers/video/mxsfb.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/drivers/video/mxsfb.c b/drivers/video/mxsfb.c
index 8a5a61c9fb..12d00b4689 100644
--- a/drivers/video/mxsfb.c
+++ b/drivers/video/mxsfb.c
@@ -77,6 +77,12 @@ static void mxs_lcd_init(struct udevice *dev, u32 fb_addr,
 		dev_err(dev, "Failed to set mxs clk: %d\n", ret);
 		return;
 	}
+
+	ret = clk_enable(&per_clk);
+	if (ret < 0) {
+		dev_err(dev, "Failed to enable mxs clk: %d\n", ret);
+		return;
+	}
 #else
 	/* Kick in the LCDIF clock */
 	mxs_set_lcdclk(MXS_LCDIF_BASE, timings->pixelclock.typ / 1000);
-- 
2.20.1

[PATCH v2 4/4] clk: imx: clk-imxrt1050: fix lcdif clock gate

[Giulio Benetti]

LCDIF clock gate was wrong so set it according to RM.

Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
---
 drivers/clk/imx/clk-imxrt1050.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/clk/imx/clk-imxrt1050.c b/drivers/clk/imx/clk-imxrt1050.c
index 329f4580c5..8279e784fe 100644
--- a/drivers/clk/imx/clk-imxrt1050.c
+++ b/drivers/clk/imx/clk-imxrt1050.c
@@ -255,7 +255,7 @@ static int imxrt1050_clk_probe(struct udevice *dev)
 	clk_dm(IMXRT1050_CLK_SEMC,
 	       imx_clk_gate2("semc", "semc_podf", base + 0x74, 4));
 	clk_dm(IMXRT1050_CLK_LCDIF,
-	       imx_clk_gate2("lcdif", "lcdif_podf", base + 0x70, 28));
+	       imx_clk_gate2("lcdif", "lcdif_podf", base + 0x74, 10));
 
 	struct clk *clk, *clk1;
 
-- 
2.20.1

[PATCH v2 3/4] video: mxsfb: add clk_enable()

[Anatolij Gustschin]

On Mon, 27 Apr 2020 17:11:06 +0200
Giulio Benetti giulio.benetti at benettiengineering.com wrote:

> BROM doesn't enable lcdif by default so add clk_enable() after
> clk_set_rate().
> 
> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>

Reviewed-by: Anatolij Gustschin <agust@denx.de>

--
Anatolij

[PATCH v2 4/4] clk: imx: clk-imxrt1050: fix lcdif clock gate

[Anatolij Gustschin]

On Mon, 27 Apr 2020 17:11:07 +0200
Giulio Benetti giulio.benetti at benettiengineering.com wrote:

> LCDIF clock gate was wrong so set it according to RM.
> 
> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>

Reviewed-by: Anatolij Gustschin <agust@denx.de>

--
Anatolij

[PATCH v2 1/4] imxrt1050-evk: README: fix dd command destination

[Fabio Estevam]

Hi Giulio,

On Mon, Apr 27, 2020 at 12:11 PM Giulio Benetti
<giulio.benetti@benettiengineering.com> wrote:
>
> Make "of=" the same for the 2 commands since we're writing to the same
> sd-card.
>
> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
> ---
>  board/freescale/imxrt1050-evk/README | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/board/freescale/imxrt1050-evk/README b/board/freescale/imxrt1050-evk/README
> index f7e2894025..55b6a0877a 100644
> --- a/board/freescale/imxrt1050-evk/README
> +++ b/board/freescale/imxrt1050-evk/README
> @@ -11,7 +11,7 @@ This will generate the SPL image called SPL and the u-boot.img.
>
>  - Flash the SPL image into the micro SD card:
>
> -sudo dd if=SPL of=/dev/mmcblk0 bs=1k seek=1; sync
> +sudo dd if=SPL of=/dev/sdb bs=1k seek=1; sync

I usually prefer to write /dev/sdX instead because someone may follow
the instructions as is and inadvertently kill their hard disk or
another device that may appear at /dev/sdb.

[PATCH v2 3/4] video: mxsfb: add clk_enable()

[Fabio Estevam]

Hi Giulio,

On Mon, Apr 27, 2020 at 12:11 PM Giulio Benetti
<giulio.benetti@benettiengineering.com> wrote:
>
> BROM doesn't enable lcdif by default so add clk_enable() after
> clk_set_rate().
>
> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
> ---
> V1->V2:
> * call clk_enable() after clk_set_rate() as suggested by Fabio

Thanks for the respin:

Reviewed-by: Fabio Estevam <festevam@gmail.com>

[PATCH v2 4/4] clk: imx: clk-imxrt1050: fix lcdif clock gate

[Fabio Estevam]

On Mon, Apr 27, 2020 at 12:11 PM Giulio Benetti
<giulio.benetti@benettiengineering.com> wrote:
>
> LCDIF clock gate was wrong so set it according to RM.
>
> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>

Reviewed-by: Fabio Estevam <festevam@gmail.com>

[PATCH v2 1/4] imxrt1050-evk: README: fix dd command destination

[Giulio Benetti]

On 4/27/20 5:34 PM, Fabio Estevam wrote:
> Hi Giulio,
> 
> On Mon, Apr 27, 2020 at 12:11 PM Giulio Benetti
> <giulio.benetti@benettiengineering.com> wrote:
>>
>> Make "of=" the same for the 2 commands since we're writing to the same
>> sd-card.
>>
>> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
>> ---
>>   board/freescale/imxrt1050-evk/README | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/board/freescale/imxrt1050-evk/README b/board/freescale/imxrt1050-evk/README
>> index f7e2894025..55b6a0877a 100644
>> --- a/board/freescale/imxrt1050-evk/README
>> +++ b/board/freescale/imxrt1050-evk/README
>> @@ -11,7 +11,7 @@ This will generate the SPL image called SPL and the u-boot.img.
>>
>>   - Flash the SPL image into the micro SD card:
>>
>> -sudo dd if=SPL of=/dev/mmcblk0 bs=1k seek=1; sync
>> +sudo dd if=SPL of=/dev/sdb bs=1k seek=1; sync
> 
> I usually prefer to write /dev/sdX instead because someone may follow
> the instructions as is and inadvertently kill their hard disk or
> another device that may appear at /dev/sdb.

Oh, that's right.

I send V3 with that corrected.

Thank you
-- 
Giulio Benetti
Benetti Engineering sas