U-Boot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [PATCH V2] spi: Update speed/mode on change
Date: Fri, 26 Feb 2021 15:21:24 +0100	[thread overview]
Message-ID: <20210226142124.56305-1-marex@denx.de> (raw)

The spi_get_bus_and_cs() may be called on the same bus and chipselect
with different frequency or mode. This is valid usecase, but the code
fails to notify the controller of such a configuration change. Call
spi_set_speed_mode() in case bus frequency or bus mode changed to let
the controller update the configuration.

The problem can easily be triggered using the sspi command:
=> sspi 0:0 at 1000
=> sspi 0:0 at 2000
Without this patch, both transfers happen at 1000 Hz. With this patch,
the later transfer happens correctly at 2000 Hz.

Signed-off-by: Marek Vasut <marex@denx.de>
Cc: Jagan Teki <jagan@amarulasolutions.com>
Cc: Patrick Delaunay <patrick.delaunay@st.com>
---
V2: - Use bus_data->speed for the check
    - Release the bus on error
---
 drivers/spi/spi-uclass.c | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/drivers/spi/spi-uclass.c b/drivers/spi/spi-uclass.c
index 7155d4aebd6..5617f6645ee 100644
--- a/drivers/spi/spi-uclass.c
+++ b/drivers/spi/spi-uclass.c
@@ -405,12 +405,22 @@ int spi_get_bus_and_cs(int busnum, int cs, int speed, int mode,
 			goto err;
 	}
 
+	/* In case bus frequency or mode changed, update it. */
+	if ((speed && bus_data->speed && bus_data->speed != speed) ||
+	    (plat->mode != mode)) {
+		ret = spi_set_speed_mode(bus, speed, mode);
+		if (ret)
+			goto err_speed_mode;
+	}
+
 	*busp = bus;
 	*devp = slave;
 	log_debug("%s: bus=%p, slave=%p\n", __func__, bus, *devp);
 
 	return 0;
 
+err_speed_mode:
+	spi_release_bus(slave);
 err:
 	log_debug("%s: Error path, created=%d, device '%s'\n", __func__,
 		  created, dev->name);
-- 
2.30.0

             reply	other threads:[~2021-02-26 14:21 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-26 14:21 Marek Vasut [this message]
2021-03-25 17:41 ` [PATCH V2] spi: Update speed/mode on change Marek Vasut
2021-03-28 21:30 ` Tom Rini
2021-03-29  1:32   ` Marek Vasut
2021-03-29  1:59     ` Tom Rini
2021-03-29  2:09       ` Marek Vasut
2021-03-29  2:40         ` Marek Vasut
2021-03-31 19:18           ` Marek Vasut
2021-03-31 19:26             ` Tom Rini
2021-03-31 19:40               ` Tom Rini
2021-03-31 20:05                 ` Marek Vasut
2021-03-31 21:45                   ` Tom Rini
2021-03-31 22:19                     ` Simon Glass
2021-04-01 14:18                       ` Tom Rini
2021-03-31 22:39                     ` Marek Vasut
2021-03-31 22:50                       ` Simon Glass
2021-03-31 23:19                         ` Marek Vasut
2021-03-31 23:41                           ` Simon Glass
2021-03-31 23:47                             ` Marek Vasut
2021-03-31 23:54                               ` Tom Rini
  -- strict thread matches above, loose matches on Subject: below --
2021-06-10 12:00 Marek Vasut
2021-06-30 16:49 ` Tom Rini
2021-07-02 17:24   ` Da Xue
2021-07-02 17:44     ` Marek Vasut
     [not found]       ` <CACdvmAh4MZ-rACRAY1nv1d0myCMyNnXjR5htkHTpe3A-wm=B1g@mail.gmail.com>
2021-07-02 18:10         ` Marek Vasut
2021-07-02 18:28           ` Da Xue
2021-07-02 19:06             ` Marek Vasut
2021-07-02 19:35               ` Da Xue
2021-07-02 19:40                 ` Marek Vasut
2021-07-02 20:10                   ` Da Xue
2021-07-02 20:20                     ` Marek Vasut

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210226142124.56305-1-marex@denx.de \
    --to=marex@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox