From: Tom Rini <trini@konsulko.com>
To: Alexandru Gagniuc <mr.nuke.me@gmail.com>
Cc: u-boot@lists.denx.de, sjg@chromium.org
Subject: Re: [PATCH 3/5] common/spl: Drop SPL_HASH_SUPPORT in favor of SPL_HASH
Date: Mon, 30 Aug 2021 12:19:16 -0400 [thread overview]
Message-ID: <20210830161916.GA858@bill-the-cat> (raw)
In-Reply-To: <20210824005320.3647668-4-mr.nuke.me@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1383 bytes --]
On Mon, Aug 23, 2021 at 07:53:18PM -0500, Alexandru Gagniuc wrote:
> Both these configs exist. Stick to using CONFIG_SPL_HASH, and drop all
> references to CONFIG_SPL_HASH_SUPPORT.
>
> Signed-off-by: Alexandru Gagniuc <mr.nuke.me@gmail.com>
[snip]
> diff --git a/common/spl/Kconfig b/common/spl/Kconfig
> index d69d1fa5f7..c75c8aaf08 100644
> --- a/common/spl/Kconfig
> +++ b/common/spl/Kconfig
> @@ -477,16 +477,6 @@ config SPL_CRYPTO
> this option to build the drivers in drivers/crypto as part of an
> SPL build.
>
> -config SPL_HASH_SUPPORT
> - bool "Support hashing drivers"
> - select SHA1
> - select SHA256
> - help
> - Enable hashing drivers in SPL. These drivers can be used to
> - accelerate secure boot processing in secure applications. Enable
> - this option to build system-specific drivers for hash acceleration
> - as part of an SPL build.
There's a lot more work to be done around platforms that enabled
sha1/sha256 this way and confirming that it was actually unusable code.
For example, (as it was where I stopped paging at in less just now)
ls1043aqds_nor_ddr3 drops sha256 and md5 algorithm support, I suspect
because of this hunk, but could be some other part of the series. Using
buildman's --show-sizes --bloat can be really handy to see when a patch
drops out a bunch of code, or adds it in.
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
next prev parent reply other threads:[~2021-08-30 16:19 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-24 0:53 [PATCH 0/5] Fix FIT hash algos in SPL (Fixes v2021.10-rc2) Alexandru Gagniuc
2021-08-24 0:53 ` [PATCH 1/5] common: Remove unused CONFIG_FIT_SHAxxx selectors Alexandru Gagniuc
2021-08-24 0:53 ` [PATCH 2/5] lib: Drop SHA512_ALGO in lieu of SHA512 Alexandru Gagniuc
2021-08-24 0:53 ` [PATCH 3/5] common/spl: Drop SPL_HASH_SUPPORT in favor of SPL_HASH Alexandru Gagniuc
2021-08-30 13:58 ` Tom Rini
2021-08-30 16:02 ` Tom Rini
2021-08-30 16:19 ` Tom Rini [this message]
2021-08-24 0:53 ` [PATCH 4/5] image: Drop if/elseif hash selection in calculate_hash() Alexandru Gagniuc
2021-08-30 16:01 ` Tom Rini
2021-08-24 0:53 ` [PATCH 5/5] image: Drop IMAGE_ENABLE_{MD5, CRC32} #defines Alexandru Gagniuc
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210830161916.GA858@bill-the-cat \
--to=trini@konsulko.com \
--cc=mr.nuke.me@gmail.com \
--cc=sjg@chromium.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox