From: Vladimir Oltean <vladimir.oltean@nxp.com>
To: Michael Walle <michael@walle.cc>
Cc: "u-boot@lists.denx.de" <u-boot@lists.denx.de>,
Jagan Teki <jagan@amarulasolutions.com>,
Priyanka Jain <priyanka.jain@nxp.com>,
Tom Rini <trini@konsulko.com>,
Peter Griffin <peter.griffin@linaro.org>,
Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Subject: Re: [PATCH 7/9] serial: lpuart: add new compatible fsl, ls1028a-lpuart
Date: Tue, 31 Aug 2021 18:28:52 +0000 [thread overview]
Message-ID: <20210831182851.bbr2zaa27rgoya72@skbuf> (raw)
In-Reply-To: <20210831154028.1649864-8-michael@walle.cc>
On Tue, Aug 31, 2021 at 05:40:26PM +0200, Michael Walle wrote:
> The offical ls1028a binding of the driver uses the following as
> compatibles:
> compatible = "fsl,ls1028a-lpuart";
s/offical/official/
> diff --git a/drivers/serial/serial_lpuart.c b/drivers/serial/serial_lpuart.c
> index 2b473d70f6..3c9a69598a 100644
> --- a/drivers/serial/serial_lpuart.c
> +++ b/drivers/serial/serial_lpuart.c
> @@ -553,6 +553,8 @@ static const struct dm_serial_ops lpuart_serial_ops = {
> static const struct udevice_id lpuart_serial_ids[] = {
> { .compatible = "fsl,ls1021a-lpuart", .data =
> LPUART_FLAG_REGMAP_32BIT_REG | LPUART_FLAG_REGMAP_ENDIAN_BIG },
> + { .compatible = "fsl,ls1028a-lpuart",
> + .data = LPUART_FLAG_REGMAP_32BIT_REG },
The LS1028A LPUART is identical to LS1021A except for endianness, true.
So the U-Boot driver uses the "little-endian" OF property to clear the
LPUART_FLAG_REGMAP_ENDIAN_BIG flag from LS1021A, while the Linux driver
selects endianness based on compatible string.
> { .compatible = "fsl,imx7ulp-lpuart",
> .data = LPUART_FLAG_REGMAP_32BIT_REG },
> { .compatible = "fsl,vf610-lpuart"},
> --
> 2.30.2
Reviewed-by: Vladimir Oltean <vladimir.oltean@nxp.com>
next prev parent reply other threads:[~2021-08-31 18:29 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-31 15:40 [PATCH 0/9] arm: dts: ls1028a: sync device tree with linux Michael Walle
2021-08-31 15:40 ` [PATCH 1/9] armv8: ls1028a: add IOMMU stream ID to vivante node Michael Walle
2021-08-31 15:40 ` [PATCH 2/9] arm: dts: ls1028a: move devices into /soc Michael Walle
2021-08-31 18:46 ` Vladimir Oltean
2021-08-31 21:32 ` Michael Walle
2021-08-31 21:54 ` Vladimir Oltean
2021-08-31 15:40 ` [PATCH 3/9] arm: dts: ls1028a: remove /memory node Michael Walle
2021-08-31 18:38 ` Vladimir Oltean
2021-08-31 15:40 ` [PATCH 4/9] arm: dts: ls1028a: update the labels Michael Walle
2021-08-31 17:57 ` Vladimir Oltean
2021-08-31 15:40 ` [PATCH 5/9] watchdog: sp805_wdt: use correct compatible string Michael Walle
2021-08-31 15:40 ` [PATCH 6/9] spi: fsl_dspi: add new compatible fsl,ls1021a-v1.0-dspi Michael Walle
2021-08-31 18:32 ` Vladimir Oltean
2021-08-31 21:35 ` Michael Walle
2021-08-31 21:39 ` Vladimir Oltean
2021-08-31 21:53 ` Michael Walle
2021-08-31 21:58 ` Vladimir Oltean
2021-08-31 15:40 ` [PATCH 7/9] serial: lpuart: add new compatible fsl,ls1028a-lpuart Michael Walle
2021-08-31 18:28 ` Vladimir Oltean [this message]
2021-08-31 21:37 ` [PATCH 7/9] serial: lpuart: add new compatible fsl, ls1028a-lpuart Michael Walle
2021-08-31 22:01 ` Vladimir Oltean
2021-08-31 15:40 ` [PATCH 8/9] arm: dts: ls1028a: sync the fsl-ls1028a.dtsi with linux Michael Walle
2021-08-31 15:40 ` [PATCH 9/9] arm: dts: sl28: sync dtbs Michael Walle
2021-08-31 18:22 ` [PATCH 0/9] arm: dts: ls1028a: sync device tree with linux Vladimir Oltean
2021-08-31 21:38 ` Michael Walle
2021-08-31 18:51 ` Vladimir Oltean
2021-08-31 21:19 ` Michael Walle
2021-08-31 22:03 ` Vladimir Oltean
2021-08-31 22:07 ` Michael Walle
2021-09-01 7:51 ` Michael Walle
2021-08-31 22:11 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210831182851.bbr2zaa27rgoya72@skbuf \
--to=vladimir.oltean@nxp.com \
--cc=jagan@amarulasolutions.com \
--cc=manivannan.sadhasivam@linaro.org \
--cc=michael@walle.cc \
--cc=peter.griffin@linaro.org \
--cc=priyanka.jain@nxp.com \
--cc=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox