From: Vladimir Oltean <vladimir.oltean@nxp.com>
To: Michael Walle <michael@walle.cc>
Cc: "u-boot@lists.denx.de" <u-boot@lists.denx.de>,
Jagan Teki <jagan@amarulasolutions.com>,
Priyanka Jain <priyanka.jain@nxp.com>,
Tom Rini <trini@konsulko.com>,
Peter Griffin <peter.griffin@linaro.org>,
Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Subject: Re: [PATCH 2/9] arm: dts: ls1028a: move devices into /soc
Date: Tue, 31 Aug 2021 18:46:12 +0000 [thread overview]
Message-ID: <20210831184611.tk7dzssaxburpneg@skbuf> (raw)
In-Reply-To: <20210831154028.1649864-3-michael@walle.cc>
On Tue, Aug 31, 2021 at 05:40:21PM +0200, Michael Walle wrote:
> Move all the CCSR related device nodes into /soc similiar to the linux
> device tree.
>
> Signed-off-by: Michael Walle <michael@walle.cc>
> ---
> .../dts/fsl-ls1028a-kontron-sl28-u-boot.dtsi | 4 +
> .../dts/fsl-ls1028a-qds-1xxx-sch-30842.dtsi | 2 +-
> .../dts/fsl-ls1028a-qds-6xxx-sch-30842.dtsi | 2 +-
> .../dts/fsl-ls1028a-qds-7777-sch-30841.dtsi | 8 +-
> .../dts/fsl-ls1028a-qds-7xx7-sch-30841R.dtsi | 4 +-
> .../dts/fsl-ls1028a-qds-8xxx-sch-24801.dtsi | 2 +-
> .../fsl-ls1028a-qds-9999-sch-24801-LBRW.dtsi | 8 +-
> .../dts/fsl-ls1028a-qds-9999-sch-24801.dtsi | 8 +-
> .../fsl-ls1028a-qds-x3xx-sch-30841-LBRW.dtsi | 8 +-
> .../fsl-ls1028a-qds-x5xx-sch-28021-LBRW.dtsi | 8 +-
> .../dts/fsl-ls1028a-qds-x7xx-sch-30842.dtsi | 2 +-
> .../dts/fsl-ls1028a-qds-xx7x-sch-30842.dtsi | 2 +-
> arch/arm/dts/fsl-ls1028a-qds.dtsi | 4 +
> arch/arm/dts/fsl-ls1028a-rdb.dts | 4 +
> arch/arm/dts/fsl-ls1028a.dtsi | 767 +++++++++---------
> 15 files changed, 426 insertions(+), 407 deletions(-)
>
> diff --git a/arch/arm/dts/fsl-ls1028a-kontron-sl28-u-boot.dtsi b/arch/arm/dts/fsl-ls1028a-kontron-sl28-u-boot.dtsi
> index b3861ed98c..fa4c05212a 100644
> --- a/arch/arm/dts/fsl-ls1028a-kontron-sl28-u-boot.dtsi
> +++ b/arch/arm/dts/fsl-ls1028a-kontron-sl28-u-boot.dtsi
> @@ -266,6 +266,10 @@
> u-boot,dm-pre-reloc;
> };
>
> +&soc {
> + u-boot,dm-pre-reloc;
> +};
> +
Does the Kontron SL28 use SPL?
> &sysclk {
> u-boot,dm-pre-reloc;
> };
> diff --git a/arch/arm/dts/fsl-ls1028a-qds-x7xx-sch-30842.dtsi b/arch/arm/dts/fsl-ls1028a-qds-x7xx-sch-30842.dtsi
> index 1fb2cdf0c2..1834418ae2 100644
> --- a/arch/arm/dts/fsl-ls1028a-qds-x7xx-sch-30842.dtsi
> +++ b/arch/arm/dts/fsl-ls1028a-qds-x7xx-sch-30842.dtsi
> @@ -20,7 +20,7 @@
> &mscc_felix_port1 {
> status = "okay";
> phy-mode = "sgmii-2500";
> - phy-handle = <&{/i2c@2000000/fpga@66/mux-mdio@54/mdio@50/phy@02}>;
> + phy-handle = <&{/soc/i2c@2000000/fpga@66/mux-mdio@54/mdio@50/phy@02}>;
> };
>
> &mscc_felix_port4 {
> diff --git a/arch/arm/dts/fsl-ls1028a-qds-xx7x-sch-30842.dtsi b/arch/arm/dts/fsl-ls1028a-qds-xx7x-sch-30842.dtsi
> index 2333f74e5a..2ee11bcacb 100644
> --- a/arch/arm/dts/fsl-ls1028a-qds-xx7x-sch-30842.dtsi
> +++ b/arch/arm/dts/fsl-ls1028a-qds-xx7x-sch-30842.dtsi
> @@ -20,7 +20,7 @@
> &mscc_felix_port2 {
> status = "okay";
> phy-mode = "sgmii-2500";
> - phy-handle = <&{/i2c@2000000/fpga@66/mux-mdio@54/mdio@60/phy@02}>;
> + phy-handle = <&{/soc/i2c@2000000/fpga@66/mux-mdio@54/mdio@60/phy@02}>;
> };
>
> &mscc_felix_port4 {
> diff --git a/arch/arm/dts/fsl-ls1028a-qds.dtsi b/arch/arm/dts/fsl-ls1028a-qds.dtsi
> index 69632fa796..3b223a5b52 100644
> --- a/arch/arm/dts/fsl-ls1028a-qds.dtsi
> +++ b/arch/arm/dts/fsl-ls1028a-qds.dtsi
> @@ -241,6 +241,10 @@
> status = "okay";
> };
>
> +&soc {
> + u-boot,dm-pre-reloc;
> +};
> +
The LS1028A-QDS does not use SPL, it uses TF-A, hence the name:
configs/ls1028aqds_tfa_defconfig
> &usb1 {
> status = "okay";
> };
> diff --git a/arch/arm/dts/fsl-ls1028a-rdb.dts b/arch/arm/dts/fsl-ls1028a-rdb.dts
> index 82a8c0a0cd..06ee4e747a 100644
> --- a/arch/arm/dts/fsl-ls1028a-rdb.dts
> +++ b/arch/arm/dts/fsl-ls1028a-rdb.dts
> @@ -123,6 +123,10 @@
> status = "okay";
> };
>
> +&soc {
> + u-boot,dm-pre-reloc;
> +};
> +
Likewise.
Otherwise, the patch itself is pretty much impossible to follow. I guess
the only option would be to move nodes one by one to /soc such that it
becomes obvious. I don't have a strong preference, just saying that I
can't judge it for correctness.
next prev parent reply other threads:[~2021-08-31 18:46 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-31 15:40 [PATCH 0/9] arm: dts: ls1028a: sync device tree with linux Michael Walle
2021-08-31 15:40 ` [PATCH 1/9] armv8: ls1028a: add IOMMU stream ID to vivante node Michael Walle
2021-08-31 15:40 ` [PATCH 2/9] arm: dts: ls1028a: move devices into /soc Michael Walle
2021-08-31 18:46 ` Vladimir Oltean [this message]
2021-08-31 21:32 ` Michael Walle
2021-08-31 21:54 ` Vladimir Oltean
2021-08-31 15:40 ` [PATCH 3/9] arm: dts: ls1028a: remove /memory node Michael Walle
2021-08-31 18:38 ` Vladimir Oltean
2021-08-31 15:40 ` [PATCH 4/9] arm: dts: ls1028a: update the labels Michael Walle
2021-08-31 17:57 ` Vladimir Oltean
2021-08-31 15:40 ` [PATCH 5/9] watchdog: sp805_wdt: use correct compatible string Michael Walle
2021-08-31 15:40 ` [PATCH 6/9] spi: fsl_dspi: add new compatible fsl,ls1021a-v1.0-dspi Michael Walle
2021-08-31 18:32 ` Vladimir Oltean
2021-08-31 21:35 ` Michael Walle
2021-08-31 21:39 ` Vladimir Oltean
2021-08-31 21:53 ` Michael Walle
2021-08-31 21:58 ` Vladimir Oltean
2021-08-31 15:40 ` [PATCH 7/9] serial: lpuart: add new compatible fsl,ls1028a-lpuart Michael Walle
2021-08-31 18:28 ` [PATCH 7/9] serial: lpuart: add new compatible fsl, ls1028a-lpuart Vladimir Oltean
2021-08-31 21:37 ` Michael Walle
2021-08-31 22:01 ` Vladimir Oltean
2021-08-31 15:40 ` [PATCH 8/9] arm: dts: ls1028a: sync the fsl-ls1028a.dtsi with linux Michael Walle
2021-08-31 15:40 ` [PATCH 9/9] arm: dts: sl28: sync dtbs Michael Walle
2021-08-31 18:22 ` [PATCH 0/9] arm: dts: ls1028a: sync device tree with linux Vladimir Oltean
2021-08-31 21:38 ` Michael Walle
2021-08-31 18:51 ` Vladimir Oltean
2021-08-31 21:19 ` Michael Walle
2021-08-31 22:03 ` Vladimir Oltean
2021-08-31 22:07 ` Michael Walle
2021-09-01 7:51 ` Michael Walle
2021-08-31 22:11 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210831184611.tk7dzssaxburpneg@skbuf \
--to=vladimir.oltean@nxp.com \
--cc=jagan@amarulasolutions.com \
--cc=manivannan.sadhasivam@linaro.org \
--cc=michael@walle.cc \
--cc=peter.griffin@linaro.org \
--cc=priyanka.jain@nxp.com \
--cc=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox