From: Tom Rini <trini@konsulko.com>
To: Sinthu Raja M <sinthu.raja@mistralsolutions.com>
Cc: u-boot@lists.denx.de, Praneeth Bajjuri <praneeth@ti.com>,
Sinthu Raja <sinthu.raja@ti.com>
Subject: Re: [PATCH V2 09/17] arm: j721e: Add support for selecting DT based on EEPROM
Date: Fri, 12 Nov 2021 09:46:06 -0500 [thread overview]
Message-ID: <20211112144606.GY24579@bill-the-cat> (raw)
In-Reply-To: <CAEd-yTRSCJKzj62DEwrAjLWOp_Qo10NZiXo7tAyV8BO5vnpGTg@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1676 bytes --]
On Fri, Nov 12, 2021 at 07:02:49PM +0530, Sinthu Raja M wrote:
> Hi Tom,
>
> On Mon, Nov 8, 2021 at 9:23 PM Tom Rini <trini@konsulko.com> wrote:
> >
> > On Tue, Nov 02, 2021 at 07:35:50PM +0530, Sinthu Raja wrote:
> >
> > > From: Sinthu Raja <sinthu.raja@ti.com>
> > >
> > > Enable support for selecting DTB from FIT within SPL based on the
> > > board name read from EEPROM. This will help to use single defconfig
> > > for both EVM and SK.
> > >
> > > Also print FDT model name and board name read from EEPROM on SPL debug
> > > console. This is useful to verify that right dtb is loaded in each boot
> > > stage.
> > >
> > > Signed-off-by: Sinthu Raja <sinthu.raja@ti.com>
> > > ---
> > >
> > > No changes in V2.
> > >
> > > arch/arm/mach-k3/j721e_init.c | 62 +++++++++++++++++++++++++++++++++++
> > > 1 file changed, 62 insertions(+)
> >
> > The EEPROM scheme is not K3-generic, but rather TI reference platform
> > specific, so this needs to be abstracted to exist and be called from
> > under board/ti/j721e/.. thanks.
>
> I guess the commit description is a little misleading. It just calls
> the board_detect function which is existed under the board/ti/j721e.
> Printing of board info is not required here which can be removed.
Right, but board/ti/j721e/ code is not relevant to non-TI reference
platforms. The code under arch/arm/mach-k3/ needs to be SoC centric,
and the TI reference platforms and their shared EEPROM stuff needs to
be under board/ti/. It also needs to be as clear as possible how to
remove it as custom platforms don't usually copy this EEPROM scheme and
this adds confusion on their part.
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
next prev parent reply other threads:[~2021-11-12 14:46 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-02 14:05 [PATCH V2 00/17] Add support for J721E SK Sinthu Raja
2021-11-02 14:05 ` [PATCH V2 01/17] common: make: Support show_board_info() as part of SPL build Sinthu Raja
2021-11-08 15:49 ` Tom Rini
2021-11-02 14:05 ` [PATCH V2 02/17] drivers: power: pmic: Add support for tps659412 PMIC Sinthu Raja
2021-11-02 14:05 ` [PATCH V2 03/17] drivers: power: regulator: tps65941_regulator: Add support for 3Phase buck Sinthu Raja
2021-11-02 14:05 ` [PATCH V2 04/17] board: ti: j721e: Guard functions with right #ifdef to avoid build warnings Sinthu Raja
2021-11-08 15:49 ` Tom Rini
2021-11-02 14:05 ` [PATCH V2 05/17] board: ti: j721e: Enable support for reading EEPROM at next alternate address Sinthu Raja
2021-11-08 15:51 ` Tom Rini
2021-11-02 14:05 ` [PATCH V2 06/17] board: ti: j721e: Add support to update board_name for j721e-sk Sinthu Raja
2021-11-02 14:05 ` [PATCH V2 07/17] board: ti: j721e: Disable probing of daughtercards Sinthu Raja
2021-11-08 15:51 ` Tom Rini
2021-11-12 12:20 ` Sinthu Raja M
2021-11-02 14:05 ` [PATCH V2 08/17] board: ti: j721e: Add support for detecting multiple device trees Sinthu Raja
2021-11-02 14:05 ` [PATCH V2 09/17] arm: j721e: Add support for selecting DT based on EEPROM Sinthu Raja
2021-11-08 15:53 ` Tom Rini
2021-11-12 13:32 ` Sinthu Raja M
2021-11-12 14:46 ` Tom Rini [this message]
2021-11-02 14:05 ` [PATCH V2 10/17] arm: dts: k3-j721e-r5-common-proc-board: Do not use power-domains for I2C Sinthu Raja
2021-11-08 15:46 ` Tom Rini
2021-11-12 11:58 ` Sinthu Raja M
2021-11-12 14:42 ` Tom Rini
2021-11-02 14:05 ` [PATCH V2 11/17] arm: dts: k3-j721e-sk: Add initial A72 specific dts support Sinthu Raja
2021-11-08 15:47 ` Tom Rini
2021-11-12 11:59 ` Sinthu Raja M
2021-11-02 14:05 ` [PATCH V2 12/17] arm: dts: k3-j721e-r5-sk: Add initial R5 specific dts support for j721e-sk Sinthu Raja
2021-11-08 15:47 ` Tom Rini
2021-11-12 11:58 ` Sinthu Raja M
2021-11-02 14:05 ` [PATCH V2 13/17] configs: j721e_evm_r5: Enable support for building multiple dtbs into FIT Sinthu Raja
2021-11-02 14:05 ` [PATCH V2 14/17] configs: j721e_evm_a72: Add SK dtb as part of DTB FIT Sinthu Raja
2021-11-02 14:05 ` [PATCH V2 15/17] configs: j721e_evm_a72: Align OSPI partitions on erase block boundary Sinthu Raja
2021-11-02 14:05 ` [PATCH V2 16/17] configs: j721e_evm: Store env in MMC FAT partition Sinthu Raja
2021-11-02 14:05 ` [PATCH V2 17/17] include: configs: Update env for selecting right dtb Sinthu Raja
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211112144606.GY24579@bill-the-cat \
--to=trini@konsulko.com \
--cc=praneeth@ti.com \
--cc=sinthu.raja@mistralsolutions.com \
--cc=sinthu.raja@ti.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox