From: Tom Rini <trini@konsulko.com>
To: AKASHI Takahiro <takahiro.akashi@linaro.org>
Cc: sjg@chromium.org, xypron.glpk@gmx.de, u-boot@lists.denx.de
Subject: Re: [PATCH 3/7] disk: define nullified functions for !PARTITIONS
Date: Mon, 18 Apr 2022 23:09:38 -0400 [thread overview]
Message-ID: <20220419030938.GE3045430@bill-the-cat> (raw)
In-Reply-To: <20220419010158.47034-4-takahiro.akashi@linaro.org>
[-- Attachment #1: Type: text/plain, Size: 880 bytes --]
On Tue, Apr 19, 2022 at 10:01:54AM +0900, AKASHI Takahiro wrote:
> Some defconfig enables CMD_PART even if none of any partition table
> types (CONFIG_*_PARTITION) are enabled.
> This will lead to the size growth in SPL/TPL code since disk/part.c
> will be compiled in any way.
> We will change disk/Kconfig later so that CONFIG_PARTITIONS is only
> enabled when, at least, one of CONFIG_*_PARTITION is enabled.
>
> To make the build work (in particular, "part" command) correctly,
> a few functions should be defined as void functions in case of
> !CONFIG_PARTITIONS.
>
> Signed-off-by: AKASHI Takahiro <takahiro.akashi@linaro.org>
I guess I wonder why we don't just make CMD_PART depend on PARTITIONS
now and thus correct the few (single?) board that has this enabled
without underlying partition code by removing the can't be functional
cmd.
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
next prev parent reply other threads:[~2022-04-19 3:09 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-19 1:01 [PATCH 0/7] disk: don't compile in partition support for spl/tpl if not really necessary AKASHI Takahiro
2022-04-19 1:01 ` [PATCH 1/7] disk: include errno.h explicitly in part.h AKASHI Takahiro
2022-04-19 1:01 ` [PATCH 2/7] disk: enable function prototypes in part.h for SPL/TPL AKASHI Takahiro
2022-04-19 1:01 ` [PATCH 3/7] disk: define nullified functions for !PARTITIONS AKASHI Takahiro
2022-04-19 3:09 ` Tom Rini [this message]
2022-04-19 4:11 ` AKASHI Takahiro
2022-04-19 12:12 ` Tom Rini
2022-04-20 2:17 ` AKASHI Takahiro
2022-04-20 2:50 ` Tom Rini
2022-04-19 1:01 ` [PATCH 4/7] sandbox: move a function prototype AKASHI Takahiro
2022-04-19 1:01 ` [PATCH 5/7] efi_loader: PARTITION_UUIDS should be optional AKASHI Takahiro
2022-04-20 7:37 ` Heinrich Schuchardt
2022-04-21 0:57 ` AKASHI Takahiro
2022-04-21 13:13 ` Tom Rini
2022-04-19 1:01 ` [PATCH 6/7] efi_loader: disk: compile efi_disk when CONFIG_BLK AKASHI Takahiro
2022-04-20 7:42 ` Heinrich Schuchardt
2022-04-21 0:30 ` AKASHI Takahiro
2022-04-23 20:08 ` Heinrich Schuchardt
2022-04-19 1:01 ` [PATCH 7/7] disk: don't compile in partition support for spl/tpl if not really necessary AKASHI Takahiro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220419030938.GE3045430@bill-the-cat \
--to=trini@konsulko.com \
--cc=sjg@chromium.org \
--cc=takahiro.akashi@linaro.org \
--cc=u-boot@lists.denx.de \
--cc=xypron.glpk@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox