From: Andre Przywara <andre.przywara@arm.com>
To: Samuel Holland <samuel@sholland.org>
Cc: u-boot@lists.denx.de, Jagan Teki <jagan@amarulasolutions.com>,
Tom Rini <trini@konsulko.com>
Subject: Re: [PATCH 1/2] sunxi: Remove obsolete Kconfig selections
Date: Tue, 10 May 2022 00:43:09 +0100 [thread overview]
Message-ID: <20220510004309.6d9b9e50@slackpad.lan> (raw)
In-Reply-To: <20220509051055.40232-1-samuel@sholland.org>
On Mon, 9 May 2022 00:10:54 -0500
Samuel Holland <samuel@sholland.org> wrote:
> ARCH_SUNXI selects DM_SERIAL, so the condition can never be satisfied.
True, and even if !DM_SERIAL would be a thing, it looks odd to begin
with.
> Signed-off-by: Samuel Holland <samuel@sholland.org>
Reviewed-by: Andre Przywara <andre.przywara@arm.com>
Cheers,
Andre
> ---
>
> arch/arm/mach-sunxi/Kconfig | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/arch/arm/mach-sunxi/Kconfig b/arch/arm/mach-sunxi/Kconfig
> index 1f43b25324..ee606c5bbc 100644
> --- a/arch/arm/mach-sunxi/Kconfig
> +++ b/arch/arm/mach-sunxi/Kconfig
> @@ -207,7 +207,6 @@ config MACH_SUN5I
> select PHY_SUN4I_USB
> select SUNXI_GEN_SUN4I
> select SUPPORT_SPL
> - imply CONS_INDEX_2 if !DM_SERIAL
> imply SPL_SYS_I2C_LEGACY
> imply SYS_I2C_LEGACY
>
> @@ -255,7 +254,6 @@ config MACH_SUN8I_A23
> select SUPPORT_SPL
> select SYS_I2C_SUN8I_RSB
> select ARMV7_BOOT_SEC_DEFAULT if OLD_SUNXI_KERNEL_COMPAT
> - imply CONS_INDEX_5 if !DM_SERIAL
>
> config MACH_SUN8I_A33
> bool "sun8i (Allwinner A33)"
> @@ -270,7 +268,6 @@ config MACH_SUN8I_A33
> select SUPPORT_SPL
> select SYS_I2C_SUN8I_RSB
> select ARMV7_BOOT_SEC_DEFAULT if OLD_SUNXI_KERNEL_COMPAT
> - imply CONS_INDEX_5 if !DM_SERIAL
>
> config MACH_SUN8I_A83T
> bool "sun8i (Allwinner A83T)"
next prev parent reply other threads:[~2022-05-09 23:43 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-09 5:10 [PATCH 1/2] sunxi: Remove obsolete Kconfig selections Samuel Holland
2022-05-09 5:10 ` [PATCH 2/2] serial: Remove obsolete CONS_INDEX_n Kconfig options Samuel Holland
2022-05-09 13:19 ` Tom Rini
2022-05-09 23:45 ` Andre Przywara
2022-05-24 15:57 ` Andre Przywara
2022-05-09 23:43 ` Andre Przywara [this message]
2022-05-24 15:56 ` [PATCH 1/2] sunxi: Remove obsolete Kconfig selections Andre Przywara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220510004309.6d9b9e50@slackpad.lan \
--to=andre.przywara@arm.com \
--cc=jagan@amarulasolutions.com \
--cc=samuel@sholland.org \
--cc=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox