public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Francis Laniel <francis.laniel@amarulasolutions.com>
To: u-boot@lists.denx.de
Cc: Marek Behun <marek.behun@nic.cz>,
	Michael Nazzareno Trimarchi <michael@amarulasolutions.com>,
	Simon Glass <sjg@chromium.org>, Wolfgang Denk <wd@denx.de>,
	Harald Seiler <hws@denx.de>, Tom Rini <trini@konsulko.com>,
	Francis Laniel <francis.laniel@amarulasolutions.com>
Subject: [RFC PATCH v4 12/28] cmd: Add new parser command.
Date: Fri, 17 Jun 2022 00:31:42 +0200	[thread overview]
Message-ID: <20220616223158.9225-13-francis.laniel@amarulasolutions.com> (raw)
In-Reply-To: <20220616223158.9225-1-francis.laniel@amarulasolutions.com>

This command can be used to print the current parser with 'parser print'.
It can also be used to set the current parser with 'parser set'.
For the moment, only one value is valid for set: old.

Signed-off-by: Francis Laniel <francis.laniel@amarulasolutions.com>
---
 cmd/Makefile |   2 +
 cmd/parser.c | 113 +++++++++++++++++++++++++++++++++++++++++++++++++++
 common/cli.c |   3 +-
 3 files changed, 117 insertions(+), 1 deletion(-)
 create mode 100644 cmd/parser.c

diff --git a/cmd/Makefile b/cmd/Makefile
index 5e43a1e022..11ae749a92 100644
--- a/cmd/Makefile
+++ b/cmd/Makefile
@@ -205,6 +205,8 @@ obj-$(CONFIG_CMD_AVB) += avb.o
 # Foundries.IO SCP03
 obj-$(CONFIG_CMD_SCP03) += scp03.o
 
+obj-$(CONFIG_HUSH_PARSER) += parser.o
+
 obj-$(CONFIG_ARM) += arm/
 obj-$(CONFIG_RISCV) += riscv/
 obj-$(CONFIG_SANDBOX) += sandbox/
diff --git a/cmd/parser.c b/cmd/parser.c
new file mode 100644
index 0000000000..4283bc7566
--- /dev/null
+++ b/cmd/parser.c
@@ -0,0 +1,113 @@
+// SPDX-License-Identifier: GPL-2.0+
+
+#include <common.h>
+#include <cli.h>
+#include <command.h>
+#include <string.h>
+#include <asm/global_data.h>
+
+DECLARE_GLOBAL_DATA_PTR;
+
+static const char *gd_flags_to_parser(void)
+{
+	if (gd->flags & GD_FLG_HUSH_OLD_PARSER)
+		return "old";
+	return NULL;
+}
+
+static int do_parser_get(struct cmd_tbl *cmdtp, int flag, int argc,
+			      char *const argv[])
+{
+	const char *current = gd_flags_to_parser();
+
+	if (!current) {
+		printf("current parser value is not valid, this should not happen!\n");
+		return CMD_RET_FAILURE;
+	}
+
+	printf("%s\n", current);
+
+	return CMD_RET_SUCCESS;
+}
+
+static int parser_string_to_gd_flags(const char *parser)
+{
+	if (!strcmp(parser, "old"))
+		return GD_FLG_HUSH_OLD_PARSER;
+	return -1;
+}
+
+static void reset_parser_gd_flags(void)
+{
+	gd->flags &= ~GD_FLG_HUSH_OLD_PARSER;
+}
+
+static int do_parser_set(struct cmd_tbl *cmdtp, int flag, int argc,
+			      char *const argv[])
+{
+	char *parser_name;
+	int parser_flag;
+
+	if (argc < 2)
+		return CMD_RET_USAGE;
+
+	parser_name = argv[1];
+
+	parser_flag = parser_string_to_gd_flags(parser_name);
+	if (parser_flag == -1) {
+		printf("Bad value for parser name: %s\n", parser_name);
+		return CMD_RET_USAGE;
+	}
+
+	if (parser_flag == GD_FLG_HUSH_OLD_PARSER
+		&& !CONFIG_IS_ENABLED(HUSH_OLD_PARSER)) {
+		printf("Want to set current parser to old, but its code was not compiled!\n");
+		return CMD_RET_FAILURE;
+	}
+	reset_parser_gd_flags();
+	gd->flags |= parser_flag;
+
+	cli_init();
+	cli_loop();
+
+	/* cli_loop() should never return. */
+	return CMD_RET_FAILURE;
+}
+
+static struct cmd_tbl parser_sub[] = {
+	U_BOOT_CMD_MKENT(get, 1, 1, do_parser_get, "", ""),
+	U_BOOT_CMD_MKENT(set, 2, 1, do_parser_set, "", ""),
+};
+
+static int do_parser(struct cmd_tbl *cmdtp, int flag, int argc,
+			char *const argv[])
+{
+	struct cmd_tbl *cp;
+
+	if (argc < 2)
+		return CMD_RET_USAGE;
+
+	/* drop initial "parser" arg */
+	argc--;
+	argv++;
+
+	cp = find_cmd_tbl(argv[0], parser_sub, ARRAY_SIZE(parser_sub));
+	if (cp)
+		return cp->cmd(cmdtp, flag, argc, argv);
+
+	return CMD_RET_USAGE;
+}
+
+#if CONFIG_IS_ENABLED(SYS_LONGHELP)
+static char parser_help_text[] =
+	"get - print current parser\n"
+	"set - set the current parser, possible value is: old"
+	;
+#endif
+
+U_BOOT_CMD(parser, 3, 1, do_parser,
+	   "parser",
+#if CONFIG_IS_ENABLED(SYS_LONGHELP)
+	   parser_help_text
+#endif
+);
diff --git a/common/cli.c b/common/cli.c
index ef967f4f9e..82c69e5573 100644
--- a/common/cli.c
+++ b/common/cli.c
@@ -239,7 +239,8 @@ void cli_loop(void)
 void cli_init(void)
 {
 #ifdef CONFIG_HUSH_PARSER
-	if (!(gd->flags & GD_FLG_HUSH_OLD_PARSER))
+	if (!(gd->flags & GD_FLG_HUSH_OLD_PARSER)
+		&& CONFIG_IS_ENABLED(HUSH_OLD_PARSER))
 		gd->flags |= GD_FLG_HUSH_OLD_PARSER;
 	u_boot_hush_start();
 #endif
-- 
2.25.1


  parent reply	other threads:[~2022-06-16 22:36 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-16 22:31 [RFC PATCH v4 00/28] Modernize U-Boot shell Francis Laniel
2022-06-16 22:31 ` [RFC PATCH v4 01/28] video: sandbox: Add dummy function for sandbox_sdl_remove_display() Francis Laniel
2022-06-16 22:31 ` [RFC PATCH v4 02/28] test: Add framework to test hush behavior Francis Laniel
2022-06-16 22:31 ` [RFC PATCH v4 03/28] test: hush: Test hush if/else Francis Laniel
2022-06-16 22:31 ` [RFC PATCH v4 04/28] test/py: hush_if_test: Remove the test file Francis Laniel
2022-06-16 22:31 ` [RFC PATCH v4 05/28] test: hush: Test hush variable expansion Francis Laniel
2022-06-16 22:31 ` [RFC PATCH v4 06/28] test: hush: Test hush commands list Francis Laniel
2022-06-16 22:31 ` [RFC PATCH v4 07/28] test: hush: Test hush loops Francis Laniel
2022-06-16 22:31 ` [RFC PATCH v4 08/28] cli: Add Busybox upstream hush.c file Francis Laniel
2022-06-16 22:31 ` [RFC PATCH v4 09/28] cli: Port Busybox 2021 hush to U-Boot Francis Laniel
2022-06-16 22:31 ` [RFC PATCH v4 10/28] cli: Add menu for hush parser Francis Laniel
2022-06-16 22:31 ` [RFC PATCH v4 11/28] global_data.h: add GD_FLG_HUSH_OLD_PARSER flag Francis Laniel
2022-06-16 22:31 ` Francis Laniel [this message]
2022-06-16 22:31 ` [RFC PATCH v4 13/28] cli: Enables using hush 2021 parser as command line parser Francis Laniel
2022-06-16 22:31 ` [RFC PATCH v4 14/28] cli: hush_2021: Enable variables expansion for hush 2021 Francis Laniel
2022-06-16 22:31 ` [RFC PATCH v4 15/28] cli: hush_2021: Add functions to be called from run_command() Francis Laniel
2022-06-16 22:31 ` [RFC PATCH v4 16/28] cli: add hush 2021 as parser for run_command*() Francis Laniel
2022-06-16 22:31 ` [RFC PATCH v4 17/28] test: hush: Fix instructions list tests for hush 2021 Francis Laniel
2022-06-16 22:31 ` [RFC PATCH v4 18/28] test: hush: Fix variable expansion " Francis Laniel
2022-06-16 22:31 ` [RFC PATCH v4 19/28] cli: hush_2021: Enable using \< and \> as string compare operators Francis Laniel
2022-06-16 22:31 ` [RFC PATCH v4 20/28] cli: hush_2021: Enable if keyword Francis Laniel
2022-06-16 22:31 ` [RFC PATCH v4 21/28] test: hush: Fix if tests for hush 2021 Francis Laniel
2022-06-16 22:31 ` [RFC PATCH v4 22/28] cli: hush_2021: Enable loops Francis Laniel
2022-06-16 22:31 ` [RFC PATCH v4 23/28] test: hush: Fix loop tests for hush 2021 Francis Laniel
2022-06-16 22:31 ` [RFC PATCH v4 24/28] Modernize U-Boot shell Francis Laniel
2022-06-16 22:31 ` [RFC PATCH v4 25/28] cli: hush_2021: Add upstream commits up to 6th February 2022 Francis Laniel
2022-06-20 19:11   ` Tom Rini
2022-08-12 20:56     ` Francis Laniel
2022-06-16 22:31 ` [RFC PATCH v4 26/28] for test purpose only: Comment out dollar tests which prints error messages Francis Laniel
2022-06-17 14:02   ` Tom Rini
2022-08-12 21:12     ` Francis Laniel
2022-06-16 22:31 ` [RFC PATCH v4 27/28] for test purpose only: Comment out failed function which fails only in CI Francis Laniel
2022-06-17 14:49   ` Tom Rini
2022-10-10 20:52     ` [PATCH] for debug purpose only: add print to debug odd behavior Francis Laniel
2022-06-16 22:31 ` [RFC PATCH v4 28/28] board: keymile: common: Use environment to store IVM_* variables Francis Laniel
2022-06-17 14:48   ` Tom Rini
2022-06-20 14:46     ` Aleksandar Gerasimovski
2022-06-20 15:27       ` Holger Brunck
2022-06-20 15:35         ` Tom Rini
2022-06-20 16:08           ` Holger Brunck
2022-06-20 17:33             ` Tom Rini
2022-08-12 21:01               ` Francis Laniel
2022-08-15  8:13                 ` Holger Brunck
2022-06-17 14:50 ` [RFC PATCH v4 00/28] Modernize U-Boot shell Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220616223158.9225-13-francis.laniel@amarulasolutions.com \
    --to=francis.laniel@amarulasolutions.com \
    --cc=hws@denx.de \
    --cc=marek.behun@nic.cz \
    --cc=michael@amarulasolutions.com \
    --cc=sjg@chromium.org \
    --cc=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    --cc=wd@denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox