From: Francis Laniel <francis.laniel@amarulasolutions.com>
To: u-boot@lists.denx.de
Cc: Marek Behun <marek.behun@nic.cz>,
Michael Nazzareno Trimarchi <michael@amarulasolutions.com>,
Simon Glass <sjg@chromium.org>, Wolfgang Denk <wd@denx.de>,
Harald Seiler <hws@denx.de>, Tom Rini <trini@konsulko.com>,
Francis Laniel <francis.laniel@amarulasolutions.com>
Subject: [RFC PATCH v4 28/28] board: keymile: common: Use environment to store IVM_* variables.
Date: Fri, 17 Jun 2022 00:31:58 +0200 [thread overview]
Message-ID: <20220616223158.9225-29-francis.laniel@amarulasolutions.com> (raw)
In-Reply-To: <20220616223158.9225-1-francis.laniel@amarulasolutions.com>
These boards used set_local_var() to store some variables as local shell.
They then used get_local_var() to retrieve the variables values.
Instead of using local shell variables, they should use environment ones (like a
majority of board).
So, this patch converts using local variables to environment ones.
Signed-off-by: Francis Laniel <francis.laniel@amarulasolutions.com>
---
board/keymile/common/common.c | 8 ++++----
board/keymile/common/ivm.c | 9 +--------
2 files changed, 5 insertions(+), 12 deletions(-)
diff --git a/board/keymile/common/common.c b/board/keymile/common/common.c
index 3999f48719..72939af36e 100644
--- a/board/keymile/common/common.c
+++ b/board/keymile/common/common.c
@@ -219,7 +219,7 @@ static int do_setboardid(struct cmd_tbl *cmdtp, int flag, int argc,
unsigned char buf[32];
char *p;
- p = get_local_var("IVM_BoardId");
+ p = env_get("IVM_BoardId");
if (!p) {
printf("can't get the IVM_Boardid\n");
return 1;
@@ -228,7 +228,7 @@ static int do_setboardid(struct cmd_tbl *cmdtp, int flag, int argc,
env_set("boardid", (char *)buf);
printf("set boardid=%s\n", buf);
- p = get_local_var("IVM_HWKey");
+ p = env_get("IVM_HWKey");
if (!p) {
printf("can't get the IVM_HWKey\n");
return 1;
@@ -272,14 +272,14 @@ static int do_checkboardidhwk(struct cmd_tbl *cmdtp, int flag, int argc,
* first read out the real inventory values, these values are
* already stored in the local hush variables
*/
- p = get_local_var("IVM_BoardId");
+ p = env_get("IVM_BoardId");
if (!p) {
printf("can't get the IVM_Boardid\n");
return 1;
}
rc = strict_strtoul(p, 16, &ivmbid);
- p = get_local_var("IVM_HWKey");
+ p = env_get("IVM_HWKey");
if (!p) {
printf("can't get the IVM_HWKey\n");
return 1;
diff --git a/board/keymile/common/ivm.c b/board/keymile/common/ivm.c
index 67db0c50f4..e266d7ce81 100644
--- a/board/keymile/common/ivm.c
+++ b/board/keymile/common/ivm.c
@@ -44,14 +44,7 @@ static int ivm_calc_crc(unsigned char *buf, int len)
static int ivm_set_value(char *name, char *value)
{
- char tempbuf[256];
-
- if (value) {
- sprintf(tempbuf, "%s=%s", name, value);
- return set_local_var(tempbuf, 0);
- }
- unset_local_var(name);
- return 0;
+ return env_set(name, value);
}
static int ivm_get_value(unsigned char *buf, int len, char *name, int off,
--
2.25.1
next prev parent reply other threads:[~2022-06-16 22:40 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-16 22:31 [RFC PATCH v4 00/28] Modernize U-Boot shell Francis Laniel
2022-06-16 22:31 ` [RFC PATCH v4 01/28] video: sandbox: Add dummy function for sandbox_sdl_remove_display() Francis Laniel
2022-06-16 22:31 ` [RFC PATCH v4 02/28] test: Add framework to test hush behavior Francis Laniel
2022-06-16 22:31 ` [RFC PATCH v4 03/28] test: hush: Test hush if/else Francis Laniel
2022-06-16 22:31 ` [RFC PATCH v4 04/28] test/py: hush_if_test: Remove the test file Francis Laniel
2022-06-16 22:31 ` [RFC PATCH v4 05/28] test: hush: Test hush variable expansion Francis Laniel
2022-06-16 22:31 ` [RFC PATCH v4 06/28] test: hush: Test hush commands list Francis Laniel
2022-06-16 22:31 ` [RFC PATCH v4 07/28] test: hush: Test hush loops Francis Laniel
2022-06-16 22:31 ` [RFC PATCH v4 08/28] cli: Add Busybox upstream hush.c file Francis Laniel
2022-06-16 22:31 ` [RFC PATCH v4 09/28] cli: Port Busybox 2021 hush to U-Boot Francis Laniel
2022-06-16 22:31 ` [RFC PATCH v4 10/28] cli: Add menu for hush parser Francis Laniel
2022-06-16 22:31 ` [RFC PATCH v4 11/28] global_data.h: add GD_FLG_HUSH_OLD_PARSER flag Francis Laniel
2022-06-16 22:31 ` [RFC PATCH v4 12/28] cmd: Add new parser command Francis Laniel
2022-06-16 22:31 ` [RFC PATCH v4 13/28] cli: Enables using hush 2021 parser as command line parser Francis Laniel
2022-06-16 22:31 ` [RFC PATCH v4 14/28] cli: hush_2021: Enable variables expansion for hush 2021 Francis Laniel
2022-06-16 22:31 ` [RFC PATCH v4 15/28] cli: hush_2021: Add functions to be called from run_command() Francis Laniel
2022-06-16 22:31 ` [RFC PATCH v4 16/28] cli: add hush 2021 as parser for run_command*() Francis Laniel
2022-06-16 22:31 ` [RFC PATCH v4 17/28] test: hush: Fix instructions list tests for hush 2021 Francis Laniel
2022-06-16 22:31 ` [RFC PATCH v4 18/28] test: hush: Fix variable expansion " Francis Laniel
2022-06-16 22:31 ` [RFC PATCH v4 19/28] cli: hush_2021: Enable using \< and \> as string compare operators Francis Laniel
2022-06-16 22:31 ` [RFC PATCH v4 20/28] cli: hush_2021: Enable if keyword Francis Laniel
2022-06-16 22:31 ` [RFC PATCH v4 21/28] test: hush: Fix if tests for hush 2021 Francis Laniel
2022-06-16 22:31 ` [RFC PATCH v4 22/28] cli: hush_2021: Enable loops Francis Laniel
2022-06-16 22:31 ` [RFC PATCH v4 23/28] test: hush: Fix loop tests for hush 2021 Francis Laniel
2022-06-16 22:31 ` [RFC PATCH v4 24/28] Modernize U-Boot shell Francis Laniel
2022-06-16 22:31 ` [RFC PATCH v4 25/28] cli: hush_2021: Add upstream commits up to 6th February 2022 Francis Laniel
2022-06-20 19:11 ` Tom Rini
2022-08-12 20:56 ` Francis Laniel
2022-06-16 22:31 ` [RFC PATCH v4 26/28] for test purpose only: Comment out dollar tests which prints error messages Francis Laniel
2022-06-17 14:02 ` Tom Rini
2022-08-12 21:12 ` Francis Laniel
2022-06-16 22:31 ` [RFC PATCH v4 27/28] for test purpose only: Comment out failed function which fails only in CI Francis Laniel
2022-06-17 14:49 ` Tom Rini
2022-10-10 20:52 ` [PATCH] for debug purpose only: add print to debug odd behavior Francis Laniel
2022-06-16 22:31 ` Francis Laniel [this message]
2022-06-17 14:48 ` [RFC PATCH v4 28/28] board: keymile: common: Use environment to store IVM_* variables Tom Rini
2022-06-20 14:46 ` Aleksandar Gerasimovski
2022-06-20 15:27 ` Holger Brunck
2022-06-20 15:35 ` Tom Rini
2022-06-20 16:08 ` Holger Brunck
2022-06-20 17:33 ` Tom Rini
2022-08-12 21:01 ` Francis Laniel
2022-08-15 8:13 ` Holger Brunck
2022-06-17 14:50 ` [RFC PATCH v4 00/28] Modernize U-Boot shell Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220616223158.9225-29-francis.laniel@amarulasolutions.com \
--to=francis.laniel@amarulasolutions.com \
--cc=hws@denx.de \
--cc=marek.behun@nic.cz \
--cc=michael@amarulasolutions.com \
--cc=sjg@chromium.org \
--cc=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
--cc=wd@denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox