public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: sbabic@denx.de
To: Rasmus Villemoes <rasmus.villemoes@prevas.dk>,u-boot@lists.denx.de
Subject: [PATCH] imx8m: fix reading of DDR4 MR registers [again]
Date: Mon, 24 Oct 2022 15:54:19 +0200 (CEST)	[thread overview]
Message-ID: <20221024135422.1434181E0F@phobos.denx.de> (raw)
In-Reply-To: <20221006125650.1666672-1-rasmus.villemoes@prevas.dk>

> Commit 290ffe5788 (imx8m: fix reading of DDR4 MR registers) lifted a
> private definition of lpddr4_mr_read() from imx8mm-cl-iot-gate board
> code to drivers/ddr/imx/imx8m/ddrphy_utils.c, because that version
> actually seems to work in practice.
> However, commit 99c7cc58e1 (ddr: imx: Add i.MX9 DDR controller driver)
> reintroduced the broken version in drivers/ddr/imx/imx8m/ddr_init.c,
> copied most of the rest of ddrphy_utils.c to
> drivers/ddr/imx/phy/ddrphy_utils.c, and stopped building
> drivers/ddr/imx/imx8m/ddrphy_utils.c [and that file was then finally
> completely removed with 7e9bd84883 (imx8m: ddrphy_utils: Remove unused
> file)].
> I assume this must have broken the imx8mm-cl-iot-gate board, at least
> those that have not had their eeprom programmed with the proper
> information. It certainly did break our out-of-tree board which always
> reads back the ID register and uses that for a sanity check.
> So apply the fix from 290ffe5788 once again.
> Fixes: 99c7cc58e1 (ddr: imx: Add i.MX9 DDR controller driver)
> Signed-off-by: Rasmus Villemoes <rasmus.villemoes@prevas.dk>
> Reviewed-by: Fabio Estevam <festevam@denx.de>
Applied to u-boot-imx, master, thanks !

Best regards,
Stefano Babic

-- 
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic@denx.de
=====================================================================

      parent reply	other threads:[~2022-10-24 13:54 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-06 12:56 [PATCH] imx8m: fix reading of DDR4 MR registers [again] Rasmus Villemoes
2022-10-06 13:17 ` Fabio Estevam
2022-10-24 13:54 ` sbabic [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221024135422.1434181E0F@phobos.denx.de \
    --to=sbabic@denx.de \
    --cc=rasmus.villemoes@prevas.dk \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox