From: Tom Rini <trini@konsulko.com>
To: Simon Glass <sjg@chromium.org>
Cc: "U-Boot Mailing List" <u-boot@lists.denx.de>,
"Marek Vasut" <marex@denx.de>,
"Abdellatif El Khlifi" <abdellatif.elkhlifi@arm.com>,
"Andre Przywara" <andre.przywara@arm.com>,
"Ashok Reddy Soma" <ashok.reddy.soma@amd.com>,
"Bin Meng" <bmeng.cn@gmail.com>,
"Chunfeng Yun" <chunfeng.yun@mediatek.com>,
"Dzmitry Sankouski" <dsankouski@gmail.com>,
GSS_MTK_Uboot_upstream <GSS_MTK_Uboot_upstream@mediatek.com>,
"Heinrich Schuchardt" <xypron.glpk@gmx.de>,
"Ilias Apalodimas" <ilias.apalodimas@linaro.org>,
"Michal Simek" <michal.simek@amd.com>,
"Michal Suchanek" <msuchanek@suse.de>,
"Nikhil M Jain" <n-jain1@ti.com>, "Pali Rohár" <pali@kernel.org>,
"Ryder Lee" <ryder.lee@mediatek.com>, "Stefan Roese" <sr@denx.de>,
"Weijie Gao" <weijie.gao@mediatek.com>
Subject: Re: [PATCH v3 38/38] pci: serial: Support reading PCI-register size with base
Date: Mon, 25 Sep 2023 16:17:09 -0400 [thread overview]
Message-ID: <20230925201709.GP305624@bill-the-cat> (raw)
In-Reply-To: <20230924192536.1812799-39-sjg@chromium.org>
[-- Attachment #1: Type: text/plain, Size: 2607 bytes --]
On Sun, Sep 24, 2023 at 01:25:23PM -0600, Simon Glass wrote:
> The PCI helpers read only the base address for a PCI region. In some cases
> the size is needed as well, e.g. to pass along to a driver which needs to
> know the size of its register area.
>
> Update the functions to allow the size to be returned. For serial, record
> the information and provided it with the serial_info() call.
>
> A limitation still exists in that the size is not available when OF_LIVE
> is enabled, so take account of that in the tests.
>
> Signed-off-by: Simon Glass <sjg@chromium.org>
So on platforms that end up here, we see consistently:
eaidk-610-rk3399: all +224 spl/u-boot-spl:all +224 spl/u-boot-spl:text +224 text +224 tpl/u-boot-tpl:all +224 tpl/u-boot-tpl:text +224
u-boot: add: 2/0, grow: 3/0 bytes: 224/0 (224)
function old new delta
fdtdec_get_addr_size_auto_noparent - 124 +124
devfdt_get_addr_size_index - 72 +72
ns16550_serial_of_to_plat 316 328 +12
ns16550_serial_probe 132 140 +8
ns16550_serial_getinfo 84 92 +8
tpl-u-boot-tpl: add: 2/0, grow: 3/0 bytes: 224/0 (224)
function old new delta
fdtdec_get_addr_size_auto_noparent - 124 +124
devfdt_get_addr_size_index - 72 +72
ns16550_serial_of_to_plat 316 328 +12
ns16550_serial_probe 132 140 +8
ns16550_serial_getinfo 84 92 +8
spl-u-boot-spl: add: 2/0, grow: 3/0 bytes: 224/0 (224)
function old new delta
fdtdec_get_addr_size_auto_noparent - 124 +124
devfdt_get_addr_size_index - 72 +72
ns16550_serial_of_to_plat 316 328 +12
ns16550_serial_probe 132 140 +8
ns16550_serial_getinfo 84 92 +8
Can we optimize this in any way? I'm less concerned with full U-Boot
growing by 224 bytes than I am by TPL growing by that much too.
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
next prev parent reply other threads:[~2023-09-25 20:17 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-24 19:24 [PATCH v3 00/38] spl: Preparation for Universal Payload Simon Glass
2023-09-24 19:24 ` [PATCH v3 01/38] spl: Use CONFIG_SPL... instead of CONFIG_..._SPL_ Simon Glass
2023-09-25 14:55 ` Felix Brack
2023-09-25 16:08 ` Simon Glass
2023-10-09 16:15 ` Felix Brack
2023-09-24 19:24 ` [PATCH v3 02/38] spl: Rename SYS_SPL_ARGS_ADDR to SPL_PAYLOAD_ARGS_ADDR Simon Glass
2023-09-24 19:24 ` [PATCH v3 03/38] spl: Avoid #ifdef with CONFIG_SPL_SYS_MALLOC Simon Glass
2023-09-24 19:24 ` [PATCH v3 04/38] spl: mx6: powerpc: Drop the condition on timer_init() Simon Glass
2023-09-26 6:45 ` Christophe Leroy
2023-09-27 14:19 ` Simon Glass
2023-09-24 19:24 ` [PATCH v3 05/38] spl: Drop #ifdefs for BOARD_INIT and watchdog Simon Glass
2023-09-24 19:24 ` [PATCH v3 06/38] spl: Avoid #ifdef with CONFIG_SPL_PAYLOAD_ARGS_ADDR Simon Glass
2023-09-24 19:24 ` [PATCH v3 07/38] spl: Drop the switch() statement for OS selection Simon Glass
2023-09-24 19:24 ` [PATCH v3 08/38] spl: Create proper symbols for enabling the malloc() pool Simon Glass
2023-09-25 19:46 ` Tom Rini
2023-09-24 19:24 ` [PATCH v3 09/38] spl: Enable CONFIG_SPL_SYS_MALLOC_F where needed Simon Glass
2023-09-24 19:24 ` [PATCH v3 10/38] tpl: Enable CONFIG_TPL_SYS_MALLOC_F " Simon Glass
2023-09-24 19:24 ` [PATCH v3 11/38] spl: Use SYS_MALLOC_F instead of SYS_MALLOC_F_LEN Simon Glass
2023-09-24 19:24 ` [PATCH v3 12/38] Tidy up uses of CONFIG_SYS_MALLOC_F_LEN Simon Glass
2023-09-24 19:24 ` [PATCH v3 13/38] doc: Clean up SYS_MALLOC_SIMPLE Simon Glass
2023-09-24 19:24 ` [PATCH v3 14/38] dm: core: Correct help in TPL_DM and VPL_DM Simon Glass
2023-09-24 19:25 ` [PATCH v3 15/38] spl: Avoid an #ifdef when printing gd->malloc_ptr Simon Glass
2023-09-24 19:25 ` [PATCH v3 16/38] spl: Remove #ifdefs with BOOTSTAGE Simon Glass
2023-09-25 19:56 ` Tom Rini
2023-09-24 19:25 ` [PATCH v3 17/38] spl: Rename spl_load_fit_image() to load_simple_fit() Simon Glass
2023-09-24 19:25 ` [PATCH v3 18/38] spl: Move the full FIT code to spl_fit.c Simon Glass
2023-09-24 19:25 ` [PATCH v3 19/38] spl: Use the correct FIT_..._PROP constants Simon Glass
2023-09-24 19:25 ` [PATCH v3 20/38] spl: Move bloblist writing until the image is known Simon Glass
2023-09-24 19:25 ` [PATCH v3 21/38] dm: core: Reverse the argument order in ofnode_copy_props() Simon Glass
2023-09-24 19:25 ` [PATCH v3 22/38] dm: core: Ensure we run flattree tests on ofnode Simon Glass
2023-09-24 19:25 ` [PATCH v3 23/38] dm: core: Tidy up comments in the ofnode tests Simon Glass
2023-09-24 19:25 ` [PATCH v3 24/38] dm: core: Add a function to create an empty tree Simon Glass
2023-09-24 19:25 ` [PATCH v3 25/38] dm: core: Add a way to copy a node Simon Glass
2023-09-24 19:25 ` [PATCH v3 26/38] dm: core: Add a way to delete " Simon Glass
2023-09-24 19:25 ` [PATCH v3 27/38] dm: core: Add a way to convert a devicetree to a dtb Simon Glass
2023-09-24 19:25 ` [PATCH v3 28/38] dm: core: Support writing a boolean Simon Glass
2023-09-24 19:25 ` [PATCH v3 29/38] dm: core: Support writing a 64-bit value Simon Glass
2023-09-24 19:25 ` [PATCH v3 30/38] dm: core: Add tests for oftree_path() Simon Glass
2023-09-24 19:25 ` [PATCH v3 31/38] sandbox: Move reading the RAM buffer into a better place Simon Glass
2023-09-24 19:25 ` [PATCH v3 32/38] sandbox: Init the EC properly even if no state file is available Simon Glass
2023-09-24 19:25 ` [PATCH v3 33/38] sandbox: Only read the state if we have a state file Simon Glass
2023-09-24 19:25 ` [PATCH v3 34/38] sandbox: Move the bloblist down a little in memory Simon Glass
2023-09-24 19:25 ` [PATCH v3 35/38] bloblist: Support initing from multiple places Simon Glass
2023-09-24 19:25 ` [PATCH v3 36/38] fdt: Allow the devicetree to come from a bloblist Simon Glass
2023-09-24 19:25 ` [PATCH v3 37/38] command: Include a required header in command.h Simon Glass
2023-09-24 19:25 ` [PATCH v3 38/38] pci: serial: Support reading PCI-register size with base Simon Glass
2023-09-25 20:17 ` Tom Rini [this message]
2023-09-26 11:37 ` Simon Glass
2023-09-26 14:05 ` Tom Rini
2023-09-25 20:36 ` [PATCH v3 00/38] spl: Preparation for Universal Payload Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230925201709.GP305624@bill-the-cat \
--to=trini@konsulko.com \
--cc=GSS_MTK_Uboot_upstream@mediatek.com \
--cc=abdellatif.elkhlifi@arm.com \
--cc=andre.przywara@arm.com \
--cc=ashok.reddy.soma@amd.com \
--cc=bmeng.cn@gmail.com \
--cc=chunfeng.yun@mediatek.com \
--cc=dsankouski@gmail.com \
--cc=ilias.apalodimas@linaro.org \
--cc=marex@denx.de \
--cc=michal.simek@amd.com \
--cc=msuchanek@suse.de \
--cc=n-jain1@ti.com \
--cc=pali@kernel.org \
--cc=ryder.lee@mediatek.com \
--cc=sjg@chromium.org \
--cc=sr@denx.de \
--cc=u-boot@lists.denx.de \
--cc=weijie.gao@mediatek.com \
--cc=xypron.glpk@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox