Re: [PATCH RFC 10/10] board: ti: j721e: Enable ESM initialization for J7200

[Tom Rini <trini@konsulko.com>]

[-- Attachment #1: Type: text/plain, Size: 1080 bytes --]

On Tue, Oct 03, 2023 at 07:57:04PM +0530, Kumar, Udit wrote:
> 
> On 10/3/2023 1:40 PM, Keerthy wrote:
> > Enable ESM initialization for J7200
> > 
> > Signed-off-by: Keerthy <j-keerthy@ti.com>
> > ---
> >   board/ti/j721e/evm.c | 6 ++++--
> >   1 file changed, 4 insertions(+), 2 deletions(-)
> > 
> > diff --git a/board/ti/j721e/evm.c b/board/ti/j721e/evm.c
> > index 42fa94b7a5..070b28326f 100644
> > --- a/board/ti/j721e/evm.c
> > +++ b/board/ti/j721e/evm.c
> > @@ -543,7 +543,8 @@ void spl_board_init(void)
> >   	}
> >   #ifdef CONFIG_ESM_K3
> > -	if (board_ti_k3_is("J721EX-PM2-SOM")) {
> > +	if ((board_ti_k3_is("J721EX-PM2-SOM")) ||
> > +	    IS_ENABLED(CONFIG_TARGET_J7200_R5_EVM)) {
> 
> 
> Could we align on one kind of check,  For J721E check is done against
> board-id, whereas for J7200 checking

We should look at figuring out how to split this file in two.  One for
"generic J721E systems" and one for "TI EVMs", as I've mentioned in
other threads, so that it's easier for custom platforms to drop code
they don' require.

-- 
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]