[PATCH RFC 00/10] arm: dts: j7200/j721s2: Enable the ESM and PMIC ESM

[PATCH RFC 00/10] arm: dts: j7200/j721s2: Enable the ESM and PMIC ESM

[Keerthy]

This patch series is RFC. This is enabling ESM/PMIC_ESM modules
needed for watchdog functionality.

Keerthy (10):
  arm64: dts: ti: k3-j721s2: Add ESM instances
  arm64: dts: ti: k3-j7200: Add MCU domain ESM instance
  arm: dts: k3-j721s2-r5-common-proc-board: Add ESM PMIC and dependent
    nodes
  arm64: dts: ti: k3-j721e: Add MCU domain ESM instance
  board: ti: j721e: Initialize MCU ESM
  board: ti: j721s2: Initialize the ESM & PMIC ESM
  configs: j721s2_evm_r5_defconfig: Enable ESM & PMIC ESM configs
  arm: dts: k3-j7200-r5-common-proc-board: Add PMIC ESM node
  configs: j7200_evm_r5_defconfig: Enable the ESM configs
  board: ti: j721e: Enable ESM initialization for J7200

 arch/arm/dts/k3-j7200-mcu-wakeup.dtsi         |  7 ++++
 .../arm/dts/k3-j7200-r5-common-proc-board.dts | 14 +++++++
 arch/arm/dts/k3-j721e-mcu-wakeup.dtsi         |  7 ++++
 arch/arm/dts/k3-j721s2-main.dtsi              |  7 ++++
 arch/arm/dts/k3-j721s2-mcu-wakeup.dtsi        | 14 +++++++
 .../dts/k3-j721s2-r5-common-proc-board.dts    | 39 +++++++++++++++++++
 board/ti/j721e/evm.c                          | 11 +++++-
 board/ti/j721s2/evm.c                         | 27 +++++++++++++
 configs/j7200_evm_r5_defconfig                |  2 +
 configs/j721s2_evm_r5_defconfig               |  7 ++++
 10 files changed, 133 insertions(+), 2 deletions(-)

-- 
2.17.1

[PATCH RFC 01/10] arm64: dts: ti: k3-j721s2: Add ESM instances

[Keerthy]

Patch adds the ESM instances for j721s2. It has 3 instances.
One in the main domain and two in the mcu-wakeup domian.

Signed-off-by: Keerthy <j-keerthy@ti.com>
---
 arch/arm/dts/k3-j721s2-main.dtsi       |  7 +++++++
 arch/arm/dts/k3-j721s2-mcu-wakeup.dtsi | 14 ++++++++++++++
 2 files changed, 21 insertions(+)

diff --git a/arch/arm/dts/k3-j721s2-main.dtsi b/arch/arm/dts/k3-j721s2-main.dtsi
index 976ba1e95a..859b5124ae 100644
--- a/arch/arm/dts/k3-j721s2-main.dtsi
+++ b/arch/arm/dts/k3-j721s2-main.dtsi
@@ -934,4 +934,11 @@
 		interrupt-names = "int0", "int1";
 		bosch,mram-cfg = <0x0 128 64 64 64 64 32 32>;
 	};
+
+	main_esm: esm@700000 {
+		compatible = "ti,j721e-esm";
+		reg = <0x00 0x700000 0x00 0x1000>;
+		ti,esm-pins = <688>, <689>;
+		bootph-pre-ram;
+	};
 };
diff --git a/arch/arm/dts/k3-j721s2-mcu-wakeup.dtsi b/arch/arm/dts/k3-j721s2-mcu-wakeup.dtsi
index 7521963719..f28cf7df50 100644
--- a/arch/arm/dts/k3-j721s2-mcu-wakeup.dtsi
+++ b/arch/arm/dts/k3-j721s2-mcu-wakeup.dtsi
@@ -299,4 +299,18 @@
 			ti,cpts-periodic-outputs = <2>;
 		};
 	};
+
+	mcu_esm: esm@40800000 {
+		compatible = "ti,j721e-esm";
+		reg = <0x00 0x40800000 0x00 0x1000>;
+		ti,esm-pins = <95>;
+		bootph-pre-ram;
+	};
+
+	wkup_esm: esm@42080000 {
+		compatible = "ti,j721e-esm";
+		reg = <0x00 0x42080000 0x00 0x1000>;
+		ti,esm-pins = <63>;
+		bootph-pre-ram;
+	};
 };
-- 
2.17.1

[PATCH RFC 02/10] arm64: dts: ti: k3-j7200: Add MCU domain ESM instance

[Keerthy]

Patch adds the ESM instance for MCU domian of j7200.

Signed-off-by: Keerthy <j-keerthy@ti.com>
---
 arch/arm/dts/k3-j7200-mcu-wakeup.dtsi | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/arch/arm/dts/k3-j7200-mcu-wakeup.dtsi b/arch/arm/dts/k3-j7200-mcu-wakeup.dtsi
index 1044ec6c4b..2b185fa350 100644
--- a/arch/arm/dts/k3-j7200-mcu-wakeup.dtsi
+++ b/arch/arm/dts/k3-j7200-mcu-wakeup.dtsi
@@ -375,4 +375,11 @@
 			ti,loczrama = <1>;
 		};
 	};
+
+	mcu_esm: esm@40800000 {
+		compatible = "ti,j721e-esm";
+		reg = <0x00 0x40800000 0x00 0x1000>;
+		ti,esm-pins = <95>;
+		bootph-pre-ram;
+	};
 };
-- 
2.17.1

[PATCH RFC 03/10] arm: dts: k3-j721s2-r5-common-proc-board: Add ESM PMIC and dependent nodes

[Keerthy]

PMIC ESM is part of tps6594x PMIC and connected to WKUP_I2C instance.

Signed-off-by: Keerthy <j-keerthy@ti.com>
---
 .../dts/k3-j721s2-r5-common-proc-board.dts    | 39 +++++++++++++++++++
 1 file changed, 39 insertions(+)

diff --git a/arch/arm/dts/k3-j721s2-r5-common-proc-board.dts b/arch/arm/dts/k3-j721s2-r5-common-proc-board.dts
index c74e8e58ae..629706aaf1 100644
--- a/arch/arm/dts/k3-j721s2-r5-common-proc-board.dts
+++ b/arch/arm/dts/k3-j721s2-r5-common-proc-board.dts
@@ -142,6 +142,14 @@
 			J721S2_WKUP_IOPAD(0x0b4, PIN_OUTPUT, 0) /* (D27) WKUP_UART0_TXD */
 		>;
 	};
+
+	wkup_i2c0_pins_default: wkup-i2c0-pins-default {
+		bootph-pre-ram;
+		pinctrl-single,pins = <
+			J721S2_WKUP_IOPAD(0x100, PIN_INPUT, 0) /* (H24) WKUP_I2C0_SCL */
+			J721S2_WKUP_IOPAD(0x104, PIN_INPUT, 0) /* (H27) WKUP_I2C0_SDA */
+		>;
+	};
 };
 
 &sms {
@@ -197,4 +205,35 @@
 	ti,sci = <&dm_tifs>;
 };
 
+&wkup_i2c0 {
+	bootph-pre-ram;
+	pinctrl-names = "default";
+	pinctrl-0 = <&wkup_i2c0_pins_default>;
+	clock-frequency = <400000>;
+
+	tps659413: tps659413@48 {
+		compatible = "ti,tps659413";
+		reg = <0x48>;
+		bootph-pre-ram;
+
+		regulators: regulators {
+			bootph-pre-ram;
+			buck1234_reg: buck1234 {
+				/*VDD_CPU_AVS*/
+				regulator-name = "buck1234";
+				regulator-min-microvolt = <600000>;
+				regulator-max-microvolt = <900000>;
+				regulator-always-on;
+				regulator-boot-on;
+				bootph-pre-ram;
+			};
+		};
+
+		esm: esm {
+			compatible = "ti,tps659413-esm";
+			bootph-pre-ram;
+		};
+	};
+};
+
 #include "k3-j721s2-common-proc-board-u-boot.dtsi"
-- 
2.17.1

[PATCH RFC 04/10] arm64: dts: ti: k3-j721e: Add MCU domain ESM instance

[Keerthy]

Patch adds the ESM instance for MCU domian of j721e.

Signed-off-by: Keerthy <j-keerthy@ti.com>
---
 arch/arm/dts/k3-j721e-mcu-wakeup.dtsi | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/arch/arm/dts/k3-j721e-mcu-wakeup.dtsi b/arch/arm/dts/k3-j721e-mcu-wakeup.dtsi
index 22166c7942..66fdd6443f 100644
--- a/arch/arm/dts/k3-j721e-mcu-wakeup.dtsi
+++ b/arch/arm/dts/k3-j721e-mcu-wakeup.dtsi
@@ -408,4 +408,11 @@
 			ti,loczrama = <1>;
 		};
 	};
+
+	mcu_esm: esm@40800000 {
+		compatible = "ti,j721e-esm";
+		reg = <0x00 0x40800000 0x00 0x1000>;
+		ti,esm-pins = <95>;
+		bootph-pre-ram;
+	};
 };
-- 
2.17.1

[PATCH RFC 05/10] board: ti: j721e: Initialize MCU ESM

[Keerthy]

Initialize MCU ESM. This is needed to propagate MAIN domain
events to the PMIC.

Signed-off-by: Keerthy <j-keerthy@ti.com>
---
 board/ti/j721e/evm.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/board/ti/j721e/evm.c b/board/ti/j721e/evm.c
index 38fe447d8f..42fa94b7a5 100644
--- a/board/ti/j721e/evm.c
+++ b/board/ti/j721e/evm.c
@@ -548,7 +548,12 @@ void spl_board_init(void)
 						  DM_DRIVER_GET(k3_esm), &dev);
 		if (ret)
 			printf("ESM init failed: %d\n", ret);
+
+		ret = uclass_get_device_by_name(UCLASS_MISC, "esm@40800000", &dev);
+		if (ret)
+			printf("MISC init for esm@40800000 failed: %d\n", ret);
 	}
+
 #endif
 
 #ifdef CONFIG_ESM_PMIC
-- 
2.17.1

[PATCH RFC 06/10] board: ti: j721s2: Initialize the ESM & PMIC ESM

[Keerthy]

Initialize the ESM & PMIC ESM

Signed-off-by: Keerthy <j-keerthy@ti.com>
---
 board/ti/j721s2/evm.c | 27 +++++++++++++++++++++++++++
 1 file changed, 27 insertions(+)

diff --git a/board/ti/j721s2/evm.c b/board/ti/j721s2/evm.c
index 7795300abc..effa52ff5a 100644
--- a/board/ti/j721s2/evm.c
+++ b/board/ti/j721s2/evm.c
@@ -319,4 +319,31 @@ int board_late_init(void)
 
 void spl_board_init(void)
 {
+	struct udevice *dev;
+	int ret;
+
+	if (IS_ENABLED(CONFIG_ESM_K3)) {
+		ret = uclass_get_device_by_name(UCLASS_MISC, "esm@700000",
+						&dev);
+		if (ret)
+			printf("MISC init for esm@700000 failed: %d\n", ret);
+
+		ret = uclass_get_device_by_name(UCLASS_MISC, "esm@40800000",
+						&dev);
+		if (ret)
+			printf("MISC init for esm@40800000 failed: %d\n", ret);
+
+		ret = uclass_get_device_by_name(UCLASS_MISC, "esm@42080000",
+						&dev);
+		if (ret)
+			printf("MISC init for esm@42080000 failed: %d\n", ret);
+	}
+
+	if (IS_ENABLED(CONFIG_ESM_PMIC)) {
+		ret = uclass_get_device_by_driver(UCLASS_MISC,
+						  DM_DRIVER_GET(pmic_esm),
+						  &dev);
+		if (ret)
+			printf("ESM PMIC init failed: %d\n", ret);
+	}
 }
-- 
2.17.1

[PATCH RFC 07/10] configs: j721s2_evm_r5_defconfig: Enable ESM & PMIC ESM configs

[Keerthy]

Enable ESM & PMIC ESM configs

Signed-off-by: Keerthy <j-keerthy@ti.com>
---
 configs/j721s2_evm_r5_defconfig | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/configs/j721s2_evm_r5_defconfig b/configs/j721s2_evm_r5_defconfig
index 1e66ac23d0..b9ac56f34d 100644
--- a/configs/j721s2_evm_r5_defconfig
+++ b/configs/j721s2_evm_r5_defconfig
@@ -112,6 +112,8 @@ CONFIG_DM_MAILBOX=y
 CONFIG_K3_SEC_PROXY=y
 CONFIG_FS_LOADER=y
 CONFIG_SPL_FS_LOADER=y
+CONFIG_ESM_K3=y
+CONFIG_ESM_PMIC=y
 CONFIG_SUPPORT_EMMC_BOOT=y
 CONFIG_SPL_MMC_HS400_SUPPORT=y
 CONFIG_MMC_SDHCI=y
@@ -142,6 +144,11 @@ CONFIG_PINCTRL_SINGLE=y
 CONFIG_POWER_DOMAIN=y
 CONFIG_TI_POWER_DOMAIN=y
 CONFIG_K3_SYSTEM_CONTROLLER=y
+CONFIG_DM_PMIC=y
+CONFIG_PMIC_TPS65941=y
+CONFIG_DM_REGULATOR=y
+CONFIG_SPL_DM_REGULATOR=y
+CONFIG_DM_REGULATOR_TPS65941=y
 CONFIG_REMOTEPROC_TI_K3_ARM64=y
 CONFIG_RESET_TI_SCI=y
 CONFIG_DM_SERIAL=y
-- 
2.17.1

[PATCH RFC 08/10] arm: dts: k3-j7200-r5-common-proc-board: Add PMIC ESM node

[Keerthy]

Enable the TPS659413 has the ESM PMIC.

Signed-off-by: Keerthy <j-keerthy@ti.com>
---
 arch/arm/dts/k3-j7200-r5-common-proc-board.dts | 14 ++++++++++++++
 1 file changed, 14 insertions(+)

diff --git a/arch/arm/dts/k3-j7200-r5-common-proc-board.dts b/arch/arm/dts/k3-j7200-r5-common-proc-board.dts
index e62f9218e8..4e5e4a08f8 100644
--- a/arch/arm/dts/k3-j7200-r5-common-proc-board.dts
+++ b/arch/arm/dts/k3-j7200-r5-common-proc-board.dts
@@ -271,6 +271,20 @@
 		};
 	};
 
+	tps659413: tps659413@48 {
+		compatible = "ti,tps659413";
+		reg = <0x48>;
+		bootph-pre-ram;
+
+		regulators_a: regulators {
+			bootph-pre-ram;
+		};
+
+		esm: esm {
+			compatible = "ti,tps659413-esm";
+			bootph-pre-ram;
+		};
+	};
 };
 
 &wkup_vtm0 {
-- 
2.17.1

[PATCH RFC 09/10] configs: j7200_evm_r5_defconfig: Enable the ESM configs

[Keerthy]

Enable the ESM configs.

Signed-off-by: Keerthy <j-keerthy@ti.com>
---
 configs/j7200_evm_r5_defconfig | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/configs/j7200_evm_r5_defconfig b/configs/j7200_evm_r5_defconfig
index c4dd33627b..7adc230fc1 100644
--- a/configs/j7200_evm_r5_defconfig
+++ b/configs/j7200_evm_r5_defconfig
@@ -101,6 +101,8 @@ CONFIG_DM_MAILBOX=y
 CONFIG_K3_SEC_PROXY=y
 CONFIG_FS_LOADER=y
 CONFIG_SPL_FS_LOADER=y
+CONFIG_ESM_K3=y
+CONFIG_ESM_PMIC=y
 CONFIG_K3_AVS0=y
 CONFIG_SUPPORT_EMMC_BOOT=y
 CONFIG_SPL_MMC_HS400_SUPPORT=y
-- 
2.17.1

[PATCH RFC 10/10] board: ti: j721e: Enable ESM initialization for J7200

[Keerthy]

Enable ESM initialization for J7200

Signed-off-by: Keerthy <j-keerthy@ti.com>
---
 board/ti/j721e/evm.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/board/ti/j721e/evm.c b/board/ti/j721e/evm.c
index 42fa94b7a5..070b28326f 100644
--- a/board/ti/j721e/evm.c
+++ b/board/ti/j721e/evm.c
@@ -543,7 +543,8 @@ void spl_board_init(void)
 	}
 
 #ifdef CONFIG_ESM_K3
-	if (board_ti_k3_is("J721EX-PM2-SOM")) {
+	if ((board_ti_k3_is("J721EX-PM2-SOM")) ||
+	    IS_ENABLED(CONFIG_TARGET_J7200_R5_EVM)) {
 		ret = uclass_get_device_by_driver(UCLASS_MISC,
 						  DM_DRIVER_GET(k3_esm), &dev);
 		if (ret)
@@ -557,7 +558,8 @@ void spl_board_init(void)
 #endif
 
 #ifdef CONFIG_ESM_PMIC
-	if (board_ti_k3_is("J721EX-PM2-SOM")) {
+	if ((board_ti_k3_is("J721EX-PM2-SOM")) ||
+	    IS_ENABLED(CONFIG_TARGET_J7200_R5_EVM)) {
 		ret = uclass_get_device_by_driver(UCLASS_MISC,
 						  DM_DRIVER_GET(pmic_esm),
 						  &dev);
-- 
2.17.1

Re: [PATCH RFC 10/10] board: ti: j721e: Enable ESM initialization for J7200

[Kumar, Udit]

On 10/3/2023 1:40 PM, Keerthy wrote:
> Enable ESM initialization for J7200
>
> Signed-off-by: Keerthy <j-keerthy@ti.com>
> ---
>   board/ti/j721e/evm.c | 6 ++++--
>   1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/board/ti/j721e/evm.c b/board/ti/j721e/evm.c
> index 42fa94b7a5..070b28326f 100644
> --- a/board/ti/j721e/evm.c
> +++ b/board/ti/j721e/evm.c
> @@ -543,7 +543,8 @@ void spl_board_init(void)
>   	}
>   
>   #ifdef CONFIG_ESM_K3
> -	if (board_ti_k3_is("J721EX-PM2-SOM")) {
> +	if ((board_ti_k3_is("J721EX-PM2-SOM")) ||
> +	    IS_ENABLED(CONFIG_TARGET_J7200_R5_EVM)) {


Could we align on one kind of check,  For J721E check is done against 
board-id, whereas for J7200 checking

for config option.

>   		ret = uclass_get_device_by_driver(UCLASS_MISC,
>   						  DM_DRIVER_GET(k3_esm), &dev);
>   		if (ret)
> @@ -557,7 +558,8 @@ void spl_board_init(void)
>   #endif
>   
>   #ifdef CONFIG_ESM_PMIC
> -	if (board_ti_k3_is("J721EX-PM2-SOM")) {
> +	if ((board_ti_k3_is("J721EX-PM2-SOM")) ||
> +	    IS_ENABLED(CONFIG_TARGET_J7200_R5_EVM)) {
>   		ret = uclass_get_device_by_driver(UCLASS_MISC,
>   						  DM_DRIVER_GET(pmic_esm),
>   						  &dev);

Re: [PATCH RFC 10/10] board: ti: j721e: Enable ESM initialization for J7200

[Tom Rini]

[-- Attachment #1: Type: text/plain, Size: 1080 bytes --]

On Tue, Oct 03, 2023 at 07:57:04PM +0530, Kumar, Udit wrote:
> 
> On 10/3/2023 1:40 PM, Keerthy wrote:
> > Enable ESM initialization for J7200
> > 
> > Signed-off-by: Keerthy <j-keerthy@ti.com>
> > ---
> >   board/ti/j721e/evm.c | 6 ++++--
> >   1 file changed, 4 insertions(+), 2 deletions(-)
> > 
> > diff --git a/board/ti/j721e/evm.c b/board/ti/j721e/evm.c
> > index 42fa94b7a5..070b28326f 100644
> > --- a/board/ti/j721e/evm.c
> > +++ b/board/ti/j721e/evm.c
> > @@ -543,7 +543,8 @@ void spl_board_init(void)
> >   	}
> >   #ifdef CONFIG_ESM_K3
> > -	if (board_ti_k3_is("J721EX-PM2-SOM")) {
> > +	if ((board_ti_k3_is("J721EX-PM2-SOM")) ||
> > +	    IS_ENABLED(CONFIG_TARGET_J7200_R5_EVM)) {
> 
> 
> Could we align on one kind of check,  For J721E check is done against
> board-id, whereas for J7200 checking

We should look at figuring out how to split this file in two.  One for
"generic J721E systems" and one for "TI EVMs", as I've mentioned in
other threads, so that it's easier for custom platforms to drop code
they don' require.

-- 
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]

Re: [PATCH RFC 10/10] board: ti: j721e: Enable ESM initialization for J7200

[Neha Malcom Francis]

Hi Tom,

Trying to bring back this series here.

On 03/10/23 20:40, Tom Rini wrote:
> On Tue, Oct 03, 2023 at 07:57:04PM +0530, Kumar, Udit wrote:
>>
>> On 10/3/2023 1:40 PM, Keerthy wrote:
>>> Enable ESM initialization for J7200
>>>
>>> Signed-off-by: Keerthy <j-keerthy@ti.com>
>>> ---
>>>    board/ti/j721e/evm.c | 6 ++++--
>>>    1 file changed, 4 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/board/ti/j721e/evm.c b/board/ti/j721e/evm.c
>>> index 42fa94b7a5..070b28326f 100644
>>> --- a/board/ti/j721e/evm.c
>>> +++ b/board/ti/j721e/evm.c
>>> @@ -543,7 +543,8 @@ void spl_board_init(void)
>>>    	}
>>>    #ifdef CONFIG_ESM_K3
>>> -	if (board_ti_k3_is("J721EX-PM2-SOM")) {
>>> +	if ((board_ti_k3_is("J721EX-PM2-SOM")) ||
>>> +	    IS_ENABLED(CONFIG_TARGET_J7200_R5_EVM)) {
>>
>>
>> Could we align on one kind of check,  For J721E check is done against
>> board-id, whereas for J7200 checking
> 
> We should look at figuring out how to split this file in two.  One for
> "generic J721E systems" and one for "TI EVMs", as I've mentioned in
> other threads, so that it's easier for custom platforms to drop code
> they don' require.
> 

Yes that does make sense. Would it be okay if we solve that problem separately 
in a different patch series? We can move along with this current series for now 
(after making the required change in CONFIG/board-id for v2) since ESM support 
is important for these platforms.

-- 
Thanking You
Neha Malcom Francis

Re: [PATCH RFC 10/10] board: ti: j721e: Enable ESM initialization for J7200

[Tom Rini]

[-- Attachment #1: Type: text/plain, Size: 2194 bytes --]

On Thu, Nov 16, 2023 at 11:43:50AM +0530, Neha Malcom Francis wrote:
> Hi Tom,
> 
> Trying to bring back this series here.
> 
> On 03/10/23 20:40, Tom Rini wrote:
> > On Tue, Oct 03, 2023 at 07:57:04PM +0530, Kumar, Udit wrote:
> > > 
> > > On 10/3/2023 1:40 PM, Keerthy wrote:
> > > > Enable ESM initialization for J7200
> > > > 
> > > > Signed-off-by: Keerthy <j-keerthy@ti.com>
> > > > ---
> > > >    board/ti/j721e/evm.c | 6 ++++--
> > > >    1 file changed, 4 insertions(+), 2 deletions(-)
> > > > 
> > > > diff --git a/board/ti/j721e/evm.c b/board/ti/j721e/evm.c
> > > > index 42fa94b7a5..070b28326f 100644
> > > > --- a/board/ti/j721e/evm.c
> > > > +++ b/board/ti/j721e/evm.c
> > > > @@ -543,7 +543,8 @@ void spl_board_init(void)
> > > >    	}
> > > >    #ifdef CONFIG_ESM_K3
> > > > -	if (board_ti_k3_is("J721EX-PM2-SOM")) {
> > > > +	if ((board_ti_k3_is("J721EX-PM2-SOM")) ||
> > > > +	    IS_ENABLED(CONFIG_TARGET_J7200_R5_EVM)) {
> > > 
> > > 
> > > Could we align on one kind of check,  For J721E check is done against
> > > board-id, whereas for J7200 checking
> > 
> > We should look at figuring out how to split this file in two.  One for
> > "generic J721E systems" and one for "TI EVMs", as I've mentioned in
> > other threads, so that it's easier for custom platforms to drop code
> > they don' require.
> > 
> 
> Yes that does make sense. Would it be okay if we solve that problem
> separately in a different patch series? We can move along with this current
> series for now (after making the required change in CONFIG/board-id for v2)
> since ESM support is important for these platforms.

Well, I think part of the answer to your question is (and this is a more
general TI one too), what outstanding changes need to come in now to
make existing platforms functional for v2024.01 ? My first thought is
that this series would be taken to -next, if I took it now, which means
there's time before it would be in master, and so if it really makes the
re-org later easier, we could take it, but if not, can we re-org then do
this? But if we need this to deal with regressions, OK, yes, we can take
it like this now.

-- 
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]

Re: [PATCH RFC 10/10] board: ti: j721e: Enable ESM initialization for J7200

[Neha Malcom Francis]

Hi Tom

On 17/11/23 00:10, Tom Rini wrote:
> On Thu, Nov 16, 2023 at 11:43:50AM +0530, Neha Malcom Francis wrote:
>> Hi Tom,
>>
>> Trying to bring back this series here.
>>
>> On 03/10/23 20:40, Tom Rini wrote:
>>> On Tue, Oct 03, 2023 at 07:57:04PM +0530, Kumar, Udit wrote:
>>>>
>>>> On 10/3/2023 1:40 PM, Keerthy wrote:
>>>>> Enable ESM initialization for J7200
>>>>>
>>>>> Signed-off-by: Keerthy <j-keerthy@ti.com>
>>>>> ---
>>>>>     board/ti/j721e/evm.c | 6 ++++--
>>>>>     1 file changed, 4 insertions(+), 2 deletions(-)
>>>>>
>>>>> diff --git a/board/ti/j721e/evm.c b/board/ti/j721e/evm.c
>>>>> index 42fa94b7a5..070b28326f 100644
>>>>> --- a/board/ti/j721e/evm.c
>>>>> +++ b/board/ti/j721e/evm.c
>>>>> @@ -543,7 +543,8 @@ void spl_board_init(void)
>>>>>     	}
>>>>>     #ifdef CONFIG_ESM_K3
>>>>> -	if (board_ti_k3_is("J721EX-PM2-SOM")) {
>>>>> +	if ((board_ti_k3_is("J721EX-PM2-SOM")) ||
>>>>> +	    IS_ENABLED(CONFIG_TARGET_J7200_R5_EVM)) {
>>>>
>>>>
>>>> Could we align on one kind of check,  For J721E check is done against
>>>> board-id, whereas for J7200 checking
>>>
>>> We should look at figuring out how to split this file in two.  One for
>>> "generic J721E systems" and one for "TI EVMs", as I've mentioned in
>>> other threads, so that it's easier for custom platforms to drop code
>>> they don' require.
>>>
>>
>> Yes that does make sense. Would it be okay if we solve that problem
>> separately in a different patch series? We can move along with this current
>> series for now (after making the required change in CONFIG/board-id for v2)
>> since ESM support is important for these platforms.
> 
> Well, I think part of the answer to your question is (and this is a more
> general TI one too), what outstanding changes need to come in now to
> make existing platforms functional for v2024.01 ? My first thought is
> that this series would be taken to -next, if I took it now, which means
> there's time before it would be in master, and so if it really makes the
> re-org later easier, we could take it, but if not, can we re-org then do
> this? But if we need this to deal with regressions, OK, yes, we can take
> it like this now.
> 

Maybe focusing on the re-org after having in the changes would help give more 
perspective on how we can split? Not sure just a thought... in that case I 
prefer taking this in and having a working error signaling module in rather than 
delaying it if that's okay.

-- 
Thanking You
Neha Malcom Francis

Re: [PATCH RFC 10/10] board: ti: j721e: Enable ESM initialization for J7200

[Tom Rini]

[-- Attachment #1: Type: text/plain, Size: 2935 bytes --]

On Fri, Nov 17, 2023 at 02:00:43PM +0530, Neha Malcom Francis wrote:
> Hi Tom
> 
> On 17/11/23 00:10, Tom Rini wrote:
> > On Thu, Nov 16, 2023 at 11:43:50AM +0530, Neha Malcom Francis wrote:
> > > Hi Tom,
> > > 
> > > Trying to bring back this series here.
> > > 
> > > On 03/10/23 20:40, Tom Rini wrote:
> > > > On Tue, Oct 03, 2023 at 07:57:04PM +0530, Kumar, Udit wrote:
> > > > > 
> > > > > On 10/3/2023 1:40 PM, Keerthy wrote:
> > > > > > Enable ESM initialization for J7200
> > > > > > 
> > > > > > Signed-off-by: Keerthy <j-keerthy@ti.com>
> > > > > > ---
> > > > > >     board/ti/j721e/evm.c | 6 ++++--
> > > > > >     1 file changed, 4 insertions(+), 2 deletions(-)
> > > > > > 
> > > > > > diff --git a/board/ti/j721e/evm.c b/board/ti/j721e/evm.c
> > > > > > index 42fa94b7a5..070b28326f 100644
> > > > > > --- a/board/ti/j721e/evm.c
> > > > > > +++ b/board/ti/j721e/evm.c
> > > > > > @@ -543,7 +543,8 @@ void spl_board_init(void)
> > > > > >     	}
> > > > > >     #ifdef CONFIG_ESM_K3
> > > > > > -	if (board_ti_k3_is("J721EX-PM2-SOM")) {
> > > > > > +	if ((board_ti_k3_is("J721EX-PM2-SOM")) ||
> > > > > > +	    IS_ENABLED(CONFIG_TARGET_J7200_R5_EVM)) {
> > > > > 
> > > > > 
> > > > > Could we align on one kind of check,  For J721E check is done against
> > > > > board-id, whereas for J7200 checking
> > > > 
> > > > We should look at figuring out how to split this file in two.  One for
> > > > "generic J721E systems" and one for "TI EVMs", as I've mentioned in
> > > > other threads, so that it's easier for custom platforms to drop code
> > > > they don' require.
> > > > 
> > > 
> > > Yes that does make sense. Would it be okay if we solve that problem
> > > separately in a different patch series? We can move along with this current
> > > series for now (after making the required change in CONFIG/board-id for v2)
> > > since ESM support is important for these platforms.
> > 
> > Well, I think part of the answer to your question is (and this is a more
> > general TI one too), what outstanding changes need to come in now to
> > make existing platforms functional for v2024.01 ? My first thought is
> > that this series would be taken to -next, if I took it now, which means
> > there's time before it would be in master, and so if it really makes the
> > re-org later easier, we could take it, but if not, can we re-org then do
> > this? But if we need this to deal with regressions, OK, yes, we can take
> > it like this now.
> > 
> 
> Maybe focusing on the re-org after having in the changes would help give
> more perspective on how we can split? Not sure just a thought... in that
> case I prefer taking this in and having a working error signaling module in
> rather than delaying it if that's okay.

OK, please rebase on top of whatever other series are needed (and note
so in the cover letter) and mark it as non-RFC, thanks.

-- 
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]

Re: [PATCH RFC 10/10] board: ti: j721e: Enable ESM initialization for J7200

[Neha Malcom Francis]

Hi Tom,

On 17/11/23 19:37, Tom Rini wrote:
> On Fri, Nov 17, 2023 at 02:00:43PM +0530, Neha Malcom Francis wrote:
>> Hi Tom
>>
>> On 17/11/23 00:10, Tom Rini wrote:
>>> On Thu, Nov 16, 2023 at 11:43:50AM +0530, Neha Malcom Francis wrote:
>>>> Hi Tom,
>>>>
>>>> Trying to bring back this series here.
>>>>
>>>> On 03/10/23 20:40, Tom Rini wrote:
>>>>> On Tue, Oct 03, 2023 at 07:57:04PM +0530, Kumar, Udit wrote:
>>>>>>
>>>>>> On 10/3/2023 1:40 PM, Keerthy wrote:
>>>>>>> Enable ESM initialization for J7200
>>>>>>>
>>>>>>> Signed-off-by: Keerthy <j-keerthy@ti.com>
>>>>>>> ---
>>>>>>>      board/ti/j721e/evm.c | 6 ++++--
>>>>>>>      1 file changed, 4 insertions(+), 2 deletions(-)
>>>>>>>
>>>>>>> diff --git a/board/ti/j721e/evm.c b/board/ti/j721e/evm.c
>>>>>>> index 42fa94b7a5..070b28326f 100644
>>>>>>> --- a/board/ti/j721e/evm.c
>>>>>>> +++ b/board/ti/j721e/evm.c
>>>>>>> @@ -543,7 +543,8 @@ void spl_board_init(void)
>>>>>>>      	}
>>>>>>>      #ifdef CONFIG_ESM_K3
>>>>>>> -	if (board_ti_k3_is("J721EX-PM2-SOM")) {
>>>>>>> +	if ((board_ti_k3_is("J721EX-PM2-SOM")) ||
>>>>>>> +	    IS_ENABLED(CONFIG_TARGET_J7200_R5_EVM)) {
>>>>>>
>>>>>>
>>>>>> Could we align on one kind of check,  For J721E check is done against
>>>>>> board-id, whereas for J7200 checking
>>>>>
>>>>> We should look at figuring out how to split this file in two.  One for
>>>>> "generic J721E systems" and one for "TI EVMs", as I've mentioned in
>>>>> other threads, so that it's easier for custom platforms to drop code
>>>>> they don' require.
>>>>>
>>>>
>>>> Yes that does make sense. Would it be okay if we solve that problem
>>>> separately in a different patch series? We can move along with this current
>>>> series for now (after making the required change in CONFIG/board-id for v2)
>>>> since ESM support is important for these platforms.
>>>
>>> Well, I think part of the answer to your question is (and this is a more
>>> general TI one too), what outstanding changes need to come in now to
>>> make existing platforms functional for v2024.01 ? My first thought is
>>> that this series would be taken to -next, if I took it now, which means
>>> there's time before it would be in master, and so if it really makes the
>>> re-org later easier, we could take it, but if not, can we re-org then do
>>> this? But if we need this to deal with regressions, OK, yes, we can take
>>> it like this now.
>>>
>>
>> Maybe focusing on the re-org after having in the changes would help give
>> more perspective on how we can split? Not sure just a thought... in that
>> case I prefer taking this in and having a working error signaling module in
>> rather than delaying it if that's okay.
> 
> OK, please rebase on top of whatever other series are needed (and note
> so in the cover letter) and mark it as non-RFC, thanks.
> 

Thanks! I'll rebase and send the next version.

-- 
Thanking You
Neha Malcom Francis