Re: [PATCH] arm: The CHIP DIP SCAN option should not be displayed in other mach

[Andre Przywara <andre.przywara@arm.com>]

On Wed, 29 Jan 2025 09:28:56 +0800
"黄利亚" <1425075683@qq.com> wrote:

Hi LiYa,

Happy New Year!

> That's the first question.Now I see this option in menuconfig, it should not be available on other models.I used the following command:
> &nbsp;&nbsp;&nbsp; export CROSS_COMPILE=arm-none-eabi- ARCH=arm
> &nbsp;&nbsp;&nbsp; make stm32h750-art-pi_defconfig
> &nbsp;&nbsp;&nbsp; make menuconfig
> &nbsp; &nbsp; ARM architecture&nbsp; ---&gt;Enable DIPs detection for CHIP board (NEW)
> 
> So I implemented this patch to fix it.
> But I find that the root cause is that this&nbsp;
> config is not included in if ARCH_SUNXI.&nbsp;

Yes, as I mentioned, you are right, it shouldn't be there, that's a bug
when this option was introduced.

> This is the second problem.I tried to include it,&nbsp;
> but got a compiler error.
> 
> diff --git a/arch/arm/mach-sunxi/Kconfig b/arch/arm/mach-sunxi/Kconfig
> index ba1b1541437..b467ab098c0 100644
> --- a/arch/arm/mach-sunxi/Kconfig
> +++ b/arch/arm/mach-sunxi/Kconfig
> @@ -1133,8 +1133,6 @@ config BLUETOOTH_DT_DEVICE_FIXUP
> &nbsp;
> &nbsp;source "board/sunxi/Kconfig"
> &nbsp;
> -endif
> -

Ah, you just need to move that "source" line above together with the
endif, so that it ends up as:

==============
config CHIP_DIP_SCAN
....
source "board/sunxi/Kconfig"
endif
==============

That worked for me. If you can confirm this, please send a v2 with that
change, and I am happy to take it.

Cheers,
Andre


> &nbsp;config CHIP_DIP_SCAN
> &nbsp;	bool "Enable DIPs detection for CHIP board"
> &nbsp;	select SUPPORT_EXTENSION_SCAN
> @@ -1143,3 +1141,6 @@ config CHIP_DIP_SCAN
> &nbsp;	select W1_EEPROM
> &nbsp;	select W1_EEPROM_DS24XXX
> &nbsp;	select CMD_EXTENSION
> +
> +
> +endif
> 
> 
> 
> The error message for running make menuconfig is as follows:
> arch/arm/mach-sunxi/Kconfig:1146: 'endif' in different file than 'if'
> arch/arm/mach-sunxi/Kconfig:1: location of the 'if'
> arch/arm/Kconfig:2417: 'endmenu' in different file than 'menu'
> arch/arm/mach-sunxi/Kconfig:1: location of the 'menu
> 
> 
> Cheers,
> LiYa
> 
> 
> ------------------&nbsp;Original&nbsp;------------------
> From:                                                                                                                        "Andre Przywara"                                                                                    <andre.przywara@arm.com&gt;;
> Date:&nbsp;Tue, Jan 28, 2025 11:55 PM
> To:&nbsp;"黄利亚"<1425075683@qq.com&gt;;
> Cc:&nbsp;"Chris Morgan"<macromorgan@hotmail.com&gt;;"Jagan Teki"<jagan@amarulasolutions.com&gt;;"Jernej Skrabec"<jernej.skrabec@gmail.com&gt;;"Maksim Kiselev"<bigunclemax@gmail.com&gt;;"Michael Walle"<mwalle@kernel.org&gt;;"Samuel Holland"<samuel@sholland.org&gt;;"Simon Glass"<sjg@chromium.org&gt;;"SumitGarg"<sumit.garg@linaro.org&gt;;"Tom Rini"<trini@konsulko.com&gt;;"u-boot"<u-boot@lists.denx.de&gt;;
> Subject:&nbsp;Re: [PATCH] arm: The CHIP DIP SCAN option should not be displayed in other mach
> 
> 
> 
> On Tue, 28 Jan 2025 21:37:37 +0800
> 1425075683@qq.com wrote:
> 
> Hi,
> 
> &gt; From: Liya Huang <1425075683@qq.com&gt;
> &gt; 
> &gt; When I use mach STM32,
> &gt; menuconfig sees this option; It bothers me.
> &gt; I observed that the root cause was that the
> &gt; option was not included in the endif,
> &gt; but when I tried to fix it, an error occurred.
> 
> Can you say what the error is, exactly?
> Because you are right, it should be before the endif.
> I moved that, and compiled it for all Allwinner boards, which worked.
> So what is the problem there, exactly?
> 
> Cheers,
> Andre
> 
> &gt; I didn't find a solution. Only deponds can be used for hiding.
> &gt; 
> &gt; Signed-off-by: Liya Huang <1425075683@qq.com&gt;
> &gt; ---
> &gt; 
> &gt;&nbsp; arch/arm/mach-sunxi/Kconfig | 1 +
> &gt;&nbsp; 1 file changed, 1 insertion(+)
> &gt; 
> &gt; diff --git a/arch/arm/mach-sunxi/Kconfig b/arch/arm/mach-sunxi/Kconfig
> &gt; index ba1b1541437..48dd1e68363 100644
> &gt; --- a/arch/arm/mach-sunxi/Kconfig
> &gt; +++ b/arch/arm/mach-sunxi/Kconfig
> &gt; @@ -1137,6 +1137,7 @@ endif
> &gt;&nbsp; 
> &gt;&nbsp; config CHIP_DIP_SCAN
> &gt;&nbsp; 	bool "Enable DIPs detection for CHIP board"
> &gt; +	depends on ARCH_SUNXI
> &gt;&nbsp; 	select SUPPORT_EXTENSION_SCAN
> &gt;&nbsp; 	select W1
> &gt;&nbsp; 	select W1_GPIO