* [PATCH] arm: The CHIP DIP SCAN option should not be displayed in other mach @ 2025-01-28 13:37 1425075683 2025-01-28 15:55 ` Andre Przywara 0 siblings, 1 reply; 4+ messages in thread From: 1425075683 @ 2025-01-28 13:37 UTC (permalink / raw) To: Liya Huang Cc: Andre Przywara, Chris Morgan, Jagan Teki, Jernej Skrabec, Maksim Kiselev, Michael Walle, Samuel Holland, Simon Glass, Sumit Garg, Tom Rini, u-boot From: Liya Huang <1425075683@qq.com> When I use mach STM32, menuconfig sees this option; It bothers me. I observed that the root cause was that the option was not included in the endif, but when I tried to fix it, an error occurred. I didn't find a solution. Only deponds can be used for hiding. Signed-off-by: Liya Huang <1425075683@qq.com> --- arch/arm/mach-sunxi/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/mach-sunxi/Kconfig b/arch/arm/mach-sunxi/Kconfig index ba1b1541437..48dd1e68363 100644 --- a/arch/arm/mach-sunxi/Kconfig +++ b/arch/arm/mach-sunxi/Kconfig @@ -1137,6 +1137,7 @@ endif config CHIP_DIP_SCAN bool "Enable DIPs detection for CHIP board" + depends on ARCH_SUNXI select SUPPORT_EXTENSION_SCAN select W1 select W1_GPIO -- 2.25.1 ^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] arm: The CHIP DIP SCAN option should not be displayed in other mach 2025-01-28 13:37 [PATCH] arm: The CHIP DIP SCAN option should not be displayed in other mach 1425075683 @ 2025-01-28 15:55 ` Andre Przywara 2025-01-29 1:28 ` =?gb18030?B?u8bA+9HH?= 0 siblings, 1 reply; 4+ messages in thread From: Andre Przywara @ 2025-01-28 15:55 UTC (permalink / raw) To: 1425075683 Cc: Chris Morgan, Jagan Teki, Jernej Skrabec, Maksim Kiselev, Michael Walle, Samuel Holland, Simon Glass, Sumit Garg, Tom Rini, u-boot On Tue, 28 Jan 2025 21:37:37 +0800 1425075683@qq.com wrote: Hi, > From: Liya Huang <1425075683@qq.com> > > When I use mach STM32, > menuconfig sees this option; It bothers me. > I observed that the root cause was that the > option was not included in the endif, > but when I tried to fix it, an error occurred. Can you say what the error is, exactly? Because you are right, it should be before the endif. I moved that, and compiled it for all Allwinner boards, which worked. So what is the problem there, exactly? Cheers, Andre > I didn't find a solution. Only deponds can be used for hiding. > > Signed-off-by: Liya Huang <1425075683@qq.com> > --- > > arch/arm/mach-sunxi/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm/mach-sunxi/Kconfig b/arch/arm/mach-sunxi/Kconfig > index ba1b1541437..48dd1e68363 100644 > --- a/arch/arm/mach-sunxi/Kconfig > +++ b/arch/arm/mach-sunxi/Kconfig > @@ -1137,6 +1137,7 @@ endif > > config CHIP_DIP_SCAN > bool "Enable DIPs detection for CHIP board" > + depends on ARCH_SUNXI > select SUPPORT_EXTENSION_SCAN > select W1 > select W1_GPIO ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] arm: The CHIP DIP SCAN option should not be displayed in other mach 2025-01-28 15:55 ` Andre Przywara @ 2025-01-29 1:28 ` =?gb18030?B?u8bA+9HH?= 2025-01-29 1:34 ` Andre Przywara 0 siblings, 1 reply; 4+ messages in thread From: =?gb18030?B?u8bA+9HH?= @ 2025-01-29 1:28 UTC (permalink / raw) To: =?gb18030?B?QW5kcmUgUHJ6eXdhcmE=?= Cc: =?gb18030?B?Q2hyaXMgTW9yZ2Fu?=, =?gb18030?B?SmFnYW4gVGVraQ==?=, =?gb18030?B?SmVybmVqIFNrcmFiZWM=?=, =?gb18030?B?TWFrc2ltIEtpc2VsZXY=?=, =?gb18030?B?TWljaGFlbCBXYWxsZQ==?=, =?gb18030?B?U2FtdWVsIEhvbGxhbmQ=?=, =?gb18030?B?U2ltb24gR2xhc3M=?=, =?gb18030?B?U3VtaXRHYXJn?=, =?gb18030?B?VG9tIFJpbmk=?=, =?gb18030?B?dS1ib290?= [-- Warning: decoded text below may be mangled, UTF-8 assumed --] [-- Attachment #1: Type: text/plain; charset="gb18030", Size: 3701 bytes --] Hi, That's the first question.Now I see this option in menuconfig, it should not be available on other models.I used the following command: export CROSS_COMPILE=arm-none-eabi- ARCH=arm make stm32h750-art-pi_defconfig make menuconfig ARM architecture --->Enable DIPs detection for CHIP board (NEW) So I implemented this patch to fix it. But I find that the root cause is that this config is not included in if ARCH_SUNXI. This is the second problem.I tried to include it, but got a compiler error. diff --git a/arch/arm/mach-sunxi/Kconfig b/arch/arm/mach-sunxi/Kconfig index ba1b1541437..b467ab098c0 100644 --- a/arch/arm/mach-sunxi/Kconfig +++ b/arch/arm/mach-sunxi/Kconfig @@ -1133,8 +1133,6 @@ config BLUETOOTH_DT_DEVICE_FIXUP source "board/sunxi/Kconfig" -endif - config CHIP_DIP_SCAN bool "Enable DIPs detection for CHIP board" select SUPPORT_EXTENSION_SCAN @@ -1143,3 +1141,6 @@ config CHIP_DIP_SCAN select W1_EEPROM select W1_EEPROM_DS24XXX select CMD_EXTENSION + + +endif The error message for running make menuconfig is as follows: arch/arm/mach-sunxi/Kconfig:1146: 'endif' in different file than 'if' arch/arm/mach-sunxi/Kconfig:1: location of the 'if' arch/arm/Kconfig:2417: 'endmenu' in different file than 'menu' arch/arm/mach-sunxi/Kconfig:1: location of the 'menu Cheers, LiYa ------------------ Original ------------------ From: "Andre Przywara" <andre.przywara@arm.com>; Date: Tue, Jan 28, 2025 11:55 PM To: "»ÆÀûÑÇ"<1425075683@qq.com>; Cc: "Chris Morgan"<macromorgan@hotmail.com>;"Jagan Teki"<jagan@amarulasolutions.com>;"Jernej Skrabec"<jernej.skrabec@gmail.com>;"Maksim Kiselev"<bigunclemax@gmail.com>;"Michael Walle"<mwalle@kernel.org>;"Samuel Holland"<samuel@sholland.org>;"Simon Glass"<sjg@chromium.org>;"SumitGarg"<sumit.garg@linaro.org>;"Tom Rini"<trini@konsulko.com>;"u-boot"<u-boot@lists.denx.de>; Subject: Re: [PATCH] arm: The CHIP DIP SCAN option should not be displayed in other mach On Tue, 28 Jan 2025 21:37:37 +0800 1425075683@qq.com wrote: Hi, > From: Liya Huang <1425075683@qq.com> > > When I use mach STM32, > menuconfig sees this option; It bothers me. > I observed that the root cause was that the > option was not included in the endif, > but when I tried to fix it, an error occurred. Can you say what the error is, exactly? Because you are right, it should be before the endif. I moved that, and compiled it for all Allwinner boards, which worked. So what is the problem there, exactly? Cheers, Andre > I didn't find a solution. Only deponds can be used for hiding. > > Signed-off-by: Liya Huang <1425075683@qq.com> > --- > > arch/arm/mach-sunxi/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm/mach-sunxi/Kconfig b/arch/arm/mach-sunxi/Kconfig > index ba1b1541437..48dd1e68363 100644 > --- a/arch/arm/mach-sunxi/Kconfig > +++ b/arch/arm/mach-sunxi/Kconfig > @@ -1137,6 +1137,7 @@ endif > > config CHIP_DIP_SCAN > bool "Enable DIPs detection for CHIP board" > + depends on ARCH_SUNXI > select SUPPORT_EXTENSION_SCAN > select W1 > select W1_GPIO ^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] arm: The CHIP DIP SCAN option should not be displayed in other mach 2025-01-29 1:28 ` =?gb18030?B?u8bA+9HH?= @ 2025-01-29 1:34 ` Andre Przywara 0 siblings, 0 replies; 4+ messages in thread From: Andre Przywara @ 2025-01-29 1:34 UTC (permalink / raw) To: 黄利亚 Cc: Chris Morgan, Jagan Teki, Jernej Skrabec, Maksim Kiselev, Michael Walle, Samuel Holland, Simon Glass, SumitGarg, Tom Rini, u-boot On Wed, 29 Jan 2025 09:28:56 +0800 "黄利亚" <1425075683@qq.com> wrote: Hi LiYa, Happy New Year! > That's the first question.Now I see this option in menuconfig, it should not be available on other models.I used the following command: > export CROSS_COMPILE=arm-none-eabi- ARCH=arm > make stm32h750-art-pi_defconfig > make menuconfig > ARM architecture --->Enable DIPs detection for CHIP board (NEW) > > So I implemented this patch to fix it. > But I find that the root cause is that this > config is not included in if ARCH_SUNXI. Yes, as I mentioned, you are right, it shouldn't be there, that's a bug when this option was introduced. > This is the second problem.I tried to include it, > but got a compiler error. > > diff --git a/arch/arm/mach-sunxi/Kconfig b/arch/arm/mach-sunxi/Kconfig > index ba1b1541437..b467ab098c0 100644 > --- a/arch/arm/mach-sunxi/Kconfig > +++ b/arch/arm/mach-sunxi/Kconfig > @@ -1133,8 +1133,6 @@ config BLUETOOTH_DT_DEVICE_FIXUP > > source "board/sunxi/Kconfig" > > -endif > - Ah, you just need to move that "source" line above together with the endif, so that it ends up as: ============== config CHIP_DIP_SCAN .... source "board/sunxi/Kconfig" endif ============== That worked for me. If you can confirm this, please send a v2 with that change, and I am happy to take it. Cheers, Andre > config CHIP_DIP_SCAN > bool "Enable DIPs detection for CHIP board" > select SUPPORT_EXTENSION_SCAN > @@ -1143,3 +1141,6 @@ config CHIP_DIP_SCAN > select W1_EEPROM > select W1_EEPROM_DS24XXX > select CMD_EXTENSION > + > + > +endif > > > > The error message for running make menuconfig is as follows: > arch/arm/mach-sunxi/Kconfig:1146: 'endif' in different file than 'if' > arch/arm/mach-sunxi/Kconfig:1: location of the 'if' > arch/arm/Kconfig:2417: 'endmenu' in different file than 'menu' > arch/arm/mach-sunxi/Kconfig:1: location of the 'menu > > > Cheers, > LiYa > > > ------------------ Original ------------------ > From: "Andre Przywara" <andre.przywara@arm.com>; > Date: Tue, Jan 28, 2025 11:55 PM > To: "黄利亚"<1425075683@qq.com>; > Cc: "Chris Morgan"<macromorgan@hotmail.com>;"Jagan Teki"<jagan@amarulasolutions.com>;"Jernej Skrabec"<jernej.skrabec@gmail.com>;"Maksim Kiselev"<bigunclemax@gmail.com>;"Michael Walle"<mwalle@kernel.org>;"Samuel Holland"<samuel@sholland.org>;"Simon Glass"<sjg@chromium.org>;"SumitGarg"<sumit.garg@linaro.org>;"Tom Rini"<trini@konsulko.com>;"u-boot"<u-boot@lists.denx.de>; > Subject: Re: [PATCH] arm: The CHIP DIP SCAN option should not be displayed in other mach > > > > On Tue, 28 Jan 2025 21:37:37 +0800 > 1425075683@qq.com wrote: > > Hi, > > > From: Liya Huang <1425075683@qq.com> > > > > When I use mach STM32, > > menuconfig sees this option; It bothers me. > > I observed that the root cause was that the > > option was not included in the endif, > > but when I tried to fix it, an error occurred. > > Can you say what the error is, exactly? > Because you are right, it should be before the endif. > I moved that, and compiled it for all Allwinner boards, which worked. > So what is the problem there, exactly? > > Cheers, > Andre > > > I didn't find a solution. Only deponds can be used for hiding. > > > > Signed-off-by: Liya Huang <1425075683@qq.com> > > --- > > > > arch/arm/mach-sunxi/Kconfig | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/arch/arm/mach-sunxi/Kconfig b/arch/arm/mach-sunxi/Kconfig > > index ba1b1541437..48dd1e68363 100644 > > --- a/arch/arm/mach-sunxi/Kconfig > > +++ b/arch/arm/mach-sunxi/Kconfig > > @@ -1137,6 +1137,7 @@ endif > > > > config CHIP_DIP_SCAN > > bool "Enable DIPs detection for CHIP board" > > + depends on ARCH_SUNXI > > select SUPPORT_EXTENSION_SCAN > > select W1 > > select W1_GPIO ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2025-01-29 1:36 UTC | newest] Thread overview: 4+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2025-01-28 13:37 [PATCH] arm: The CHIP DIP SCAN option should not be displayed in other mach 1425075683 2025-01-28 15:55 ` Andre Przywara 2025-01-29 1:28 ` =?gb18030?B?u8bA+9HH?= 2025-01-29 1:34 ` Andre Przywara
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox