From: Jorge Ramirez-Ortiz <jorge.ramirez@oss.qualcomm.com>
To: jorge.ramirez@oss.qualcomm.com, caleb.connolly@linaro.org,
neil.armstrong@linaro.org, sumit.garg@kernel.org
Cc: u-boot-qcom@groups.io, u-boot@lists.denx.de
Subject: [PATCH 3/7] mmc: msm_sdhci: handle bulk clock initialization error
Date: Mon, 7 Apr 2025 10:19:23 +0200 [thread overview]
Message-ID: <20250407081927.138915-4-jorge.ramirez@oss.qualcomm.com> (raw)
In-Reply-To: <20250407081927.138915-1-jorge.ramirez@oss.qualcomm.com>
Some boards do not require all clocks to be available (i.e:
dragonboard820c).
This change provides a fallback to the core clock when the bulk cant be
retrived.
Signed-off-by: Jorge Ramirez-Ortiz <jorge.ramirez@oss.qualcomm.com>
---
drivers/mmc/msm_sdhci.c | 27 +++++++++++++++++++++++++--
1 file changed, 25 insertions(+), 2 deletions(-)
diff --git a/drivers/mmc/msm_sdhci.c b/drivers/mmc/msm_sdhci.c
index 27bb7052fca..8081330bd25 100644
--- a/drivers/mmc/msm_sdhci.c
+++ b/drivers/mmc/msm_sdhci.c
@@ -9,6 +9,7 @@
#include <clk.h>
#include <dm.h>
+#include <dm/devres.h>
#include <malloc.h>
#include <sdhci.h>
#include <wait_bit.h>
@@ -56,6 +57,17 @@ struct msm_sdhc_variant_info {
DECLARE_GLOBAL_DATA_PTR;
+static int get_core_clock(struct udevice *dev, struct clk_bulk *bulk)
+{
+ bulk->count = 1;
+
+ bulk->clks = devm_kcalloc(dev, 1, sizeof(struct clk), GFP_KERNEL);
+ if (!bulk->clks)
+ return -ENOMEM;
+
+ return clk_get_by_name(dev, "core", &bulk->clks[0]);
+}
+
static int msm_sdc_clk_init(struct udevice *dev)
{
struct msm_sdhc *prv = dev_get_priv(dev);
@@ -73,8 +85,15 @@ static int msm_sdc_clk_init(struct udevice *dev)
ret = clk_get_bulk(dev, &prv->clks);
if (ret) {
- log_warning("Couldn't get mmc clocks: %d\n", ret);
- return ret;
+ log_warning("Bulk clocks not available (%d), trying core clock\n", ret);
+
+ /* Sometimes not all clocks are needed - chainloading uboot */
+ ret = get_core_clock(dev, &prv->clks);
+ if (ret) {
+ log_warning("Core clock not available:(%d)\n", ret);
+ return ret;
+ }
+ n_clks = 1;
}
ret = clk_enable_bulk(&prv->clks);
@@ -83,6 +102,9 @@ static int msm_sdc_clk_init(struct udevice *dev)
return ret;
}
+ if (n_clks == 1)
+ goto set_rate;
+
/* If clock-names is unspecified, then the first clock is the core clock */
if (!ofnode_get_property(node, "clock-names", &n_clks)) {
if (!clk_set_rate(&prv->clks.clks[0], clk_rate)) {
@@ -105,6 +127,7 @@ static int msm_sdc_clk_init(struct udevice *dev)
return -EINVAL;
}
+set_rate:
/* The clock is already enabled by the clk_bulk above */
clk_rate = clk_set_rate(&prv->clks.clks[i], clk_rate);
/* If we get a rate of 0 then something has probably gone wrong. */
--
2.34.1
next prev parent reply other threads:[~2025-04-07 8:20 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-07 8:19 Dragonboard 820c - fix board support Jorge Ramirez-Ortiz
2025-04-07 8:19 ` [PATCH 1/7] board: qualcomm: dragonboard820c: udpate readme Jorge Ramirez-Ortiz
2025-04-07 9:01 ` neil.armstrong
2025-04-07 8:19 ` [PATCH 2/7] clk/qcom: apq8096: fix set rate for the uart clock Jorge Ramirez-Ortiz
2025-04-07 9:01 ` neil.armstrong
2025-04-07 8:19 ` Jorge Ramirez-Ortiz [this message]
2025-04-07 9:02 ` [PATCH 3/7] mmc: msm_sdhci: handle bulk clock initialization error neil.armstrong
2025-04-07 9:10 ` Neil Armstrong
2025-04-07 9:38 ` Jorge Ramirez
2025-04-07 9:53 ` Neil Armstrong
2025-04-07 10:36 ` Jorge Ramirez
2025-04-07 8:19 ` [PATCH 4/7] clk/qcom: apq8096: fix the sdhci clock Jorge Ramirez-Ortiz
2025-04-07 9:03 ` neil.armstrong
2025-04-07 8:19 ` [PATCH 5/7] configs: dragonboard820: enable GPIO Jorge Ramirez-Ortiz
2025-04-07 9:03 ` neil.armstrong
2025-04-07 8:19 ` [PATCH 6/7] mach-snapdragon: board interface to enforce fdt Jorge Ramirez-Ortiz
2025-04-07 9:04 ` neil.armstrong
2025-04-07 9:52 ` Jorge Ramirez
2025-04-07 10:02 ` Caleb Connolly
2025-04-07 10:33 ` Jorge Ramirez
2025-04-07 8:19 ` [PATCH 7/7] board: qualcommm: dragonboard820c: external fdt Jorge Ramirez-Ortiz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250407081927.138915-4-jorge.ramirez@oss.qualcomm.com \
--to=jorge.ramirez@oss.qualcomm.com \
--cc=caleb.connolly@linaro.org \
--cc=neil.armstrong@linaro.org \
--cc=sumit.garg@kernel.org \
--cc=u-boot-qcom@groups.io \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox