U-Boot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Tim Harvey <tharvey@gateworks.com>
To: u-boot@lists.denx.de, Stefano Babic <sbabic@nabladev.com>
Cc: Fabio Estevam <festevam@gmail.com>,
	"NXP i . MX U-Boot Team" <uboot-imx@nxp.com>,
	Tim Harvey <tharvey@gateworks.com>
Subject: [PATCH 08/13] board: venice: flip logic for GSC supervisor enable
Date: Fri, 23 May 2025 10:20:13 -0700	[thread overview]
Message-ID: <20250523172018.4164647-8-tharvey@gateworks.com> (raw)
In-Reply-To: <20250523172018.4164647-1-tharvey@gateworks.com>

Flip the logic used to determine if a board has the proper hardware to
support enabling the GSC voltage supervisor so that we do not need to
keep adding new models to the list.

Signed-off-by: Tim Harvey <tharvey@gateworks.com>
---
 board/gateworks/venice/spl.c | 18 ++++++++++--------
 1 file changed, 10 insertions(+), 8 deletions(-)

diff --git a/board/gateworks/venice/spl.c b/board/gateworks/venice/spl.c
index f14ab1497d70..e813f3e763ec 100644
--- a/board/gateworks/venice/spl.c
+++ b/board/gateworks/venice/spl.c
@@ -62,14 +62,16 @@ static int power_init_board(const char *model, struct udevice *gsc)
 	struct udevice *dev;
 	int ret;
 
-	/* Enable GSC voltage supervisor for new board models */
-	if ((!strncmp(model, "GW7100", 6) && model[10] > 'D') ||
-	    (!strncmp(model, "GW7101", 6) && model[10] > 'D') ||
-	    (!strncmp(model, "GW7200", 6) && model[10] > 'E') ||
-	    (!strncmp(model, "GW7201", 6) && model[10] > 'E') ||
-	    (!strncmp(model, "GW7300", 6) && model[10] > 'E') ||
-	    (!strncmp(model, "GW7301", 6) && model[10] > 'E') ||
-	    (!strncmp(model, "GW740", 5) && model[7] > 'B')) {
+	/* Enable GSC voltage supervisor only for newew board models */
+	if ((!strncmp(model, "GW7100", 6) && model[10] < 'E') ||
+	    (!strncmp(model, "GW7101", 6) && model[10] < 'E') ||
+	    (!strncmp(model, "GW7200", 6) && model[10] < 'F') ||
+	    (!strncmp(model, "GW7201", 6) && model[10] < 'F') ||
+	    (!strncmp(model, "GW7300", 6) && model[10] < 'F') ||
+	    (!strncmp(model, "GW7301", 6) && model[10] < 'F') ||
+	    (!strncmp(model, "GW740", 5) && model[7] < 'C')) {
+		printf("GSC     : voltage supervisor disabled\n");
+	} else {
 		u8 ver;
 
 		if (!dm_i2c_read(gsc, 14, &ver, 1) && ver > 62) {
-- 
2.25.1


  parent reply	other threads:[~2025-05-23 17:21 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-23 17:20 [PATCH 01/13] configs: imx8m*_venice: enable several commands useful for scripting Tim Harvey
2025-05-23 17:20 ` [PATCH 02/13] configs: imx8m*_venice: enable GPT support Tim Harvey
2025-05-26  8:21   ` Peng Fan
2025-05-23 17:20 ` [PATCH 03/13] board: venice: move soc-specific dram config into soc-specific files Tim Harvey
2025-05-26  8:21   ` Peng Fan
2025-05-23 17:20 ` [PATCH 04/13] board: venice: fix dram bus config for GW7902/GW7903/GW7904 Tim Harvey
2025-05-26  8:20   ` Peng Fan
2025-05-23 17:20 ` [PATCH 05/13] board: venice: fix dram size for GW7901-SP486 Tim Harvey
2025-05-26  8:20   ` Peng Fan
2025-05-23 17:20 ` [PATCH 06/13] board: venice: use baseboard model for family Tim Harvey
2025-05-26  8:20   ` Peng Fan
2025-05-23 17:20 ` [PATCH 07/13] board: venice: use SOM model for PMIC adjustment on SOM Tim Harvey
2025-05-26  8:19   ` Peng Fan
2025-05-23 17:20 ` Tim Harvey [this message]
2025-05-26  8:19   ` [PATCH 08/13] board: venice: flip logic for GSC supervisor enable Peng Fan
2025-05-23 17:20 ` [PATCH 09/13] board: venice: add imx8mp-gw82xx support Tim Harvey
2025-05-26  8:19   ` Peng Fan
2025-05-23 17:20 ` [PATCH 10/13] board: venice: add FSA support Tim Harvey
2025-05-26  8:19   ` Peng Fan
2025-05-23 17:20 ` [PATCH 11/13] board: venice: update model representation for venice-flex Tim Harvey
2025-05-26  8:18   ` Peng Fan
2025-05-23 17:20 ` [PATCH 12/13] board: venice: append configuration string to model Tim Harvey
2025-05-26  8:18   ` Peng Fan
2025-05-23 17:20 ` [PATCH 13/13] imx8mp-venice-gw74xx: add w_disable2 gpio configuration Tim Harvey
2025-05-26  8:17   ` Peng Fan
2025-05-26  8:21 ` [PATCH 01/13] configs: imx8m*_venice: enable several commands useful for scripting Peng Fan
2025-06-01 13:32 ` Fabio Estevam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250523172018.4164647-8-tharvey@gateworks.com \
    --to=tharvey@gateworks.com \
    --cc=festevam@gmail.com \
    --cc=sbabic@nabladev.com \
    --cc=u-boot@lists.denx.de \
    --cc=uboot-imx@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox