U-Boot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Tom Rini <trini@konsulko.com>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: u-boot@lists.denx.de, Ilias Apalodimas <ilias.apalodimas@linaro.org>
Subject: Re: [PATCH 0/1] armv8: reduce core errata dispatch work
Date: Tue, 26 May 2026 08:03:13 -0600	[thread overview]
Message-ID: <20260526140313.GR1858239@bill-the-cat> (raw)
In-Reply-To: <c67720e2-bb73-43ab-9d75-851ef1f4afaf@kernel.org>

[-- Attachment #1: Type: text/plain, Size: 1524 bytes --]

On Tue, May 26, 2026 at 08:01:16AM +0200, Krzysztof Kozlowski wrote:
> On 24/05/2026 14:38, Josh Law wrote:
> > Hey folks,
> > 
> > apply_core_errata() runs during early ARMv8 CPU entry, before
> > lowlevel_init(). Today it still checks the Cortex-A53 and Cortex-A57
> > paths even when the build has no matching core erratum enabled.
> > 
> > This patch leaves that dispatch code out unless one of the supported
> > errata is enabled. For the A57 errata case, it reads MIDR_EL1 once and
> > reuses the extracted CPU part number.
> > 
> > The erratum register writes stay behind the same CPU checks as before.
> > For qemu_arm64_defconfig, where none of these errata are enabled,
> > apply_core_errata() goes from 15 dispatch instructions to a single ret.
> > For ls2080aqds_qspi_defconfig, which keeps the A57 path, the dispatch
> > side goes from 33 instructions to 26. A KVM microbench of the same
> > dispatch sequences showed 1.30x for the no errata case and 1.09x for
> > the A57 miss case.
> > 
> > Josh Law (1):
> >   armv8: reduce core errata dispatch work
> 
> That's another identity from Josh Law, since all previous got NAKed, and
> 100% AI generated code without review and without tests (I don't believe
> what was claimed above).
> 
> I recommend ignoring and here is some background:
> 
> https://lore.kernel.org/all/cbd0aafa-bd45-4f4d-a2dd-440473657dba@lucifer.local/

Well crap. Thanks for the link! I've moved all of the submissions to
Deferred in patchwork.

-- 
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

      parent reply	other threads:[~2026-05-26 14:03 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-24 12:38 [PATCH 0/1] armv8: reduce core errata dispatch work Josh Law
2026-05-24 12:38 ` [PATCH 1/1] " Josh Law
2026-05-26  6:01 ` [PATCH 0/1] " Krzysztof Kozlowski
2026-05-26 11:11   ` Ilias Apalodimas
2026-05-26 11:48     ` Josh Law
2026-05-26 14:03   ` Tom Rini [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260526140313.GR1858239@bill-the-cat \
    --to=trini@konsulko.com \
    --cc=ilias.apalodimas@linaro.org \
    --cc=krzk@kernel.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox