From: Eric Chung <eric.chung@riscstar.com>
To: u-boot-spacemit@groups.io, u-boot@lists.denx.de
Cc: Tom Rini <trini@konsulko.com>, Peng Fan <peng.fan@nxp.com>,
Huan Zhou <pericycle.cc@gmail.com>,
Raymond Mao <raymond.mao@riscstar.com>,
Jaehoon Chung <jh80.chung@samsung.com>,
Bhimeswararao Matsa <bhimeswararao.matsa@gmail.com>,
Tanmay Kathpalia <tanmay.kathpalia@altera.com>,
Kaustabh Chakraborty <kauschluss@disroot.org>,
Han Xu <han.xu@nxp.com>, Yanir Levin <yanir.levin@tandemg.com>,
Christoph Stoidner <c.stoidner@phytec.de>,
Balsundar Ponnusamy <balsundar.ponnusamy@altera.com>,
Daniel Palmer <daniel@thingy.jp>, Anshul Dalal <anshuld@ti.com>,
Bastien Curutchet <bastien.curutchet@bootlin.com>,
Angelo Dureghello <angelo@kernel-space.org>,
Johan Jonker <jbx6244@gmail.com>, Rick Chen <rick@andestech.com>,
Leo <ycliang@andestech.com>,
Sam Protsenko <semen.protsenko@linaro.org>,
Guodong Xu <guodong.xu@riscstar.com>,
Eric Chung <eric.chung@riscstar.com>
Subject: [PATCH v2 v2 8/8] spacemit: k1: load product name from environment variable
Date: Mon, 29 Jun 2026 23:51:22 +0800 [thread overview]
Message-ID: <20260629-m4-v2-8-cbc91c6b83d8@riscstar.com> (raw)
In-Reply-To: <20260629-m4-v2-0-cbc91c6b83d8@riscstar.com>
Read the product name from the environment instead of EEPROM,
as the EEPROM may not be programmed and the environment always
contains this information.
Signed-off-by: Eric Chung <eric.chung@riscstar.com>
---
board/spacemit/k1/spl.c | 50 ++++++++++---------------------------------------
1 file changed, 10 insertions(+), 40 deletions(-)
diff --git a/board/spacemit/k1/spl.c b/board/spacemit/k1/spl.c
index 0db362130e4..4f8b2f1035d 100644
--- a/board/spacemit/k1/spl.c
+++ b/board/spacemit/k1/spl.c
@@ -12,6 +12,7 @@
#include <configs/k1.h>
#include <dm/device.h>
#include <dm/uclass.h>
+#include <env.h>
#include <i2c.h>
#include <linux/delay.h>
#include <log.h>
@@ -73,39 +74,6 @@ static void i2c_early_init(void)
}
}
-int read_product_name(char *name, int size)
-{
- u8 eeprom_data[TLV_TOTAL_LEN_MAX], *p;
- struct tlvinfo_header *tlv_hdr;
- struct tlvinfo_tlv *tlv_entry;
- int ret, i = 0;
- u32 entry_size;
-
- if (!name || size <= 0)
- return -EINVAL;
- ret = read_tlvinfo_tlv_eeprom(eeprom_data, &tlv_hdr,
- &tlv_entry, i);
- if (ret)
- return ret;
- p = (u8 *)tlv_entry;
- for (i = 0; i < tlv_hdr->totallen; ) {
- if (tlv_entry->type == TLV_CODE_PRODUCT_NAME) {
- if (tlv_entry->length < size)
- size = tlv_entry->length;
- memset(name, 0, size);
- memcpy(name, &tlv_entry->value[0], size);
- return 0;
- }
- if (tlv_entry->type == TLV_CODE_CRC_32)
- return -ENOENT;
- entry_size = tlv_entry->length + sizeof(struct tlvinfo_tlv);
- i += entry_size;
- p += entry_size;
- tlv_entry = (struct tlvinfo_tlv *)p;
- }
- return -ENOENT;
-}
-
static const struct {
const char *eeprom_name;
const char *fit_name;
@@ -117,9 +85,14 @@ static const struct {
static void fixup_product_name(void)
{
- char fdt_name[I2C_BUF_SIZE];
+ char fdt_name[I2C_BUF_SIZE], *name;
int i;
+ memset(product_name, 0, I2C_BUF_SIZE);
+ env_init();
+ env_load();
+ name = env_get("product_name");
+ snprintf(product_name, I2C_BUF_SIZE, "%s", name);
memset(fdt_name, 0, I2C_BUF_SIZE);
for (i = 0; i < ARRAY_SIZE(k1_board_map); i++) {
if (!strncmp(product_name, k1_board_map[i].eeprom_name,
@@ -384,13 +357,10 @@ u32 spl_boot_device(void)
void spl_board_init(void)
{
- int ret;
+}
- ret = read_product_name(product_name, I2C_BUF_SIZE);
- if (ret)
- log_info("Fail to detect board:%d\n", ret);
- else
- log_info("Get board name:%s\n", product_name);
+void spl_perform_board_fixups(struct spl_image_info *spl_image)
+{
fixup_product_name();
}
--
2.51.0
next prev parent reply other threads:[~2026-06-29 15:53 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-29 15:51 [PATCH v2 0/8] spacemit mmc driver Eric Chung
2026-06-29 15:51 ` [PATCH v2 v2 1/8] pinctrl: k1: add IO power domain configuration support Eric Chung
2026-06-30 8:55 ` Yao Zi
2026-06-29 15:51 ` [PATCH v2 v2 2/8] mmc: sdhci: add quirk to enable CMD23 for multi-block transfers Eric Chung
2026-06-30 2:47 ` Peng Fan
2026-06-29 15:51 ` [PATCH v2 v2 3/8] mmc: k1: add sdhci platform driver Eric Chung
2026-06-30 2:52 ` Peng Fan
2026-06-29 15:51 ` [PATCH v2 v2 4/8] dts: k1: add SD card support in u-boot overlay Eric Chung
2026-06-30 2:56 ` Peng Fan
2026-06-29 15:51 ` [PATCH v2 v2 5/8] configs: k1: enable SD and eMMC support Eric Chung
2026-06-29 15:51 ` [PATCH v2 v2 6/8] doc: spacemit: flash on K1 SoC based boards Eric Chung
2026-06-29 15:51 ` [PATCH v2 v2 7/8] config: k1: enable ENV support for eMMC Eric Chung
2026-06-29 15:51 ` Eric Chung [this message]
2026-06-30 2:55 ` [PATCH v2 v2 8/8] spacemit: k1: load product name from environment variable Peng Fan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260629-m4-v2-8-cbc91c6b83d8@riscstar.com \
--to=eric.chung@riscstar.com \
--cc=angelo@kernel-space.org \
--cc=anshuld@ti.com \
--cc=balsundar.ponnusamy@altera.com \
--cc=bastien.curutchet@bootlin.com \
--cc=bhimeswararao.matsa@gmail.com \
--cc=c.stoidner@phytec.de \
--cc=daniel@thingy.jp \
--cc=guodong.xu@riscstar.com \
--cc=han.xu@nxp.com \
--cc=jbx6244@gmail.com \
--cc=jh80.chung@samsung.com \
--cc=kauschluss@disroot.org \
--cc=peng.fan@nxp.com \
--cc=pericycle.cc@gmail.com \
--cc=raymond.mao@riscstar.com \
--cc=rick@andestech.com \
--cc=semen.protsenko@linaro.org \
--cc=tanmay.kathpalia@altera.com \
--cc=trini@konsulko.com \
--cc=u-boot-spacemit@groups.io \
--cc=u-boot@lists.denx.de \
--cc=yanir.levin@tandemg.com \
--cc=ycliang@andestech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox