From: Tom Rini <trini@konsulko.com>
To: Jonas Karlman <jonas@kwiboo.se>
Cc: Peng Fan <peng.fan@nxp.com>,
Jaehoon Chung <jh80.chung@samsung.com>,
u-boot@lists.denx.de
Subject: Re: [PATCH 11/11] spl: Use CONFIG_IS_ENABLED() for LIBCOMMON_SUPPORT checks
Date: Wed, 8 Jul 2026 19:53:13 -0600 [thread overview]
Message-ID: <20260709015313.GV749385@bill-the-cat> (raw)
In-Reply-To: <20260708220540.3368825-12-jonas@kwiboo.se>
[-- Attachment #1: Type: text/plain, Size: 452 bytes --]
On Wed, Jul 08, 2026 at 10:05:37PM +0000, Jonas Karlman wrote:
> Use CONFIG_IS_ENABLED(LIBCOMMON_SUPPORT) instead of directly checking
> CONFIG_SPL_LIBCOMMON_SUPPORT when guarding printf/log calls to depend on
> correct xPL_LIBCOMMON_SUPPORT symbol. Also change to use IS_ENABLED()
> for the XPL_BUILD symbol checks for consistency.
>
> Signed-off-by: Jonas Karlman <jonas@kwiboo.se>
Reviewed-by: Tom Rini <trini@konsulko.com>
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2026-07-09 1:53 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-08 22:05 [PATCH 00/11] treewide: Fix miscellaneous xPL related symbol issues Jonas Karlman
2026-07-08 22:05 ` [PATCH 01/11] Makefile: Drop redundant CONFIG_TPL_BUILD checks Jonas Karlman
2026-07-09 1:52 ` Tom Rini
2026-07-13 14:23 ` Simon Glass
2026-07-08 22:05 ` [PATCH 02/11] dm: core: Drop redundant CONFIG_TPL_BUILD check Jonas Karlman
2026-07-09 1:52 ` Tom Rini
2026-07-13 14:23 ` Simon Glass
2026-07-08 22:05 ` [PATCH 03/11] rockchip: clk: rk3368: Drop redundant CONFIG_TPL_BUILD checks Jonas Karlman
2026-07-09 1:52 ` Tom Rini
2026-07-13 14:23 ` Simon Glass
2026-07-08 22:05 ` [PATCH 04/11] x86: apl: fsp_bindings: Drop redundant CONFIG_TPL_BUILD check Jonas Karlman
2026-07-09 1:52 ` Tom Rini
2026-07-13 14:23 ` Simon Glass
2026-07-08 22:05 ` [PATCH 05/11] spl: Simplify xPL_BUILD conditional guard example Jonas Karlman
2026-07-09 1:52 ` Tom Rini
2026-07-13 14:24 ` Simon Glass
2026-07-08 22:05 ` [PATCH 06/11] Kconfig: Add missing depends on xPL to xPL_ symbols Jonas Karlman
2026-07-09 1:52 ` Tom Rini
2026-07-09 6:41 ` Jonas Karlman
2026-07-09 13:41 ` Tom Rini
2026-07-13 14:24 ` Simon Glass
2026-07-13 14:53 ` Jonas Karlman
2026-07-08 22:05 ` [PATCH 07/11] Kconfig: Depend on correct xPL symbol Jonas Karlman
2026-07-09 1:52 ` Tom Rini
2026-07-13 14:25 ` Simon Glass
2026-07-08 22:05 ` [PATCH 08/11] Kconfig: i2c: " Jonas Karlman
2026-07-09 1:52 ` Tom Rini
2026-07-09 7:12 ` Jonas Karlman
2026-07-09 13:19 ` Jonas Karlman
2026-07-09 13:43 ` Tom Rini
2026-07-10 13:50 ` Tom Rini
2026-07-10 15:39 ` Jonas Karlman
2026-07-10 15:56 ` Tom Rini
2026-07-10 23:52 ` Jonas Karlman
2026-07-13 21:48 ` Tom Rini
2026-07-13 14:28 ` Simon Glass
2026-07-13 15:02 ` Jonas Karlman
2026-07-13 15:17 ` Simon Glass
2026-07-08 22:05 ` [PATCH 09/11] Kconfig: serial: " Jonas Karlman
2026-07-09 1:53 ` Tom Rini
2026-07-09 7:27 ` Jonas Karlman
2026-07-09 13:44 ` Tom Rini
2026-07-13 14:30 ` Simon Glass
2026-07-13 15:10 ` Jonas Karlman
2026-07-08 22:05 ` [PATCH 10/11] console: Use CONFIG_IS_ENABLED() for SILENT_CONSOLE checks Jonas Karlman
2026-07-09 1:53 ` Tom Rini
2026-07-13 14:29 ` Simon Glass
2026-07-13 15:16 ` Jonas Karlman
2026-07-08 22:05 ` [PATCH 11/11] spl: Use CONFIG_IS_ENABLED() for LIBCOMMON_SUPPORT checks Jonas Karlman
2026-07-09 1:53 ` Tom Rini [this message]
2026-07-10 13:51 ` Tom Rini
2026-07-13 14:29 ` Simon Glass
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260709015313.GV749385@bill-the-cat \
--to=trini@konsulko.com \
--cc=jh80.chung@samsung.com \
--cc=jonas@kwiboo.se \
--cc=peng.fan@nxp.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox