Re: [PATCH 11/11] spl: Use CONFIG_IS_ENABLED() for LIBCOMMON_SUPPORT checks

[Tom Rini <trini@konsulko.com>]

[-- Attachment #1: Type: text/plain, Size: 1131 bytes --]

On Wed, Jul 08, 2026 at 07:53:13PM -0600, Tom Rini wrote:
> On Wed, Jul 08, 2026 at 10:05:37PM +0000, Jonas Karlman wrote:
> 
> > Use CONFIG_IS_ENABLED(LIBCOMMON_SUPPORT) instead of directly checking
> > CONFIG_SPL_LIBCOMMON_SUPPORT when guarding printf/log calls to depend on
> > correct xPL_LIBCOMMON_SUPPORT symbol. Also change to use IS_ENABLED()
> > for the XPL_BUILD symbol checks for consistency.
> > 
> > Signed-off-by: Jonas Karlman <jonas@kwiboo.se>
> 
> Reviewed-by: Tom Rini <trini@konsulko.com>

So, this isn't size-neutral:
   aarch64: (for 1/1 boards) all +77.0 rodata +57.0 text +20.0
            ax3005_scm3005 : all +77 rodata +57 text +20
               u-boot: add: 0/0, grow: 2/0 bytes: 41/0 (41)
                 function                                   old     new   delta
                 static.__func__                            285     306     +21
                 fit_find_config_node                       240     260     +20

(and a number of other boards). But I think it's a bug fix of
unintentional behavior today. So I'm just noting this here for the
record.

-- 
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]