Re: [PATCH 06/11] Kconfig: Add missing depends on xPL to xPL_ symbols

[Tom Rini <trini@konsulko.com>]

[-- Attachment #1: Type: text/plain, Size: 1666 bytes --]

On Thu, Jul 09, 2026 at 08:41:16AM +0200, Jonas Karlman wrote:
> Hi Tom,
> 
> On 7/9/2026 3:52 AM, Tom Rini wrote:
> > On Wed, Jul 08, 2026 at 10:05:32PM +0000, Jonas Karlman wrote:
> > 
> >> xPL_<name> symbols should typically depend on the associated xPL symbol.
> >>
> >> Add missing depends on xPL to xPL_<name> symbols to avoid the xPL_<name>
> >> symbols being available when the associated xPL symbol is disabled.
> >>
> >> Signed-off-by: Jonas Karlman <jonas@kwiboo.se>
> >> ---
> >>  common/Kconfig | 2 ++
> >>  lib/Kconfig    | 7 ++++++-
> >>  2 files changed, 8 insertions(+), 1 deletion(-)
> > 
> > Did this go through CI? I ask because with SPL/TPL, we have the problem
> > of PowerPC being special from the rest of the world with these symbols
> > and I want to be sure everything still is building, before I do a
> > before/after size check on the series (and probably keep the binaries,
> > so I can checksum before/after and make sure they're the same).
> > 
> 
> The CI has been run [1] on a branch that contains these changes and the
> pending Rockchip TPL cleanup/consistency series, not standalone.
> 
> Compared to the patches that was sent there is a small diff with && xPL
> being dropped in the final series sent to ML:
> 
>  config xPL_SERIAL_PRESENT
>         bool "Provide a serial driver in xPL"
> -       depends on xPL_DM_SERIAL && xPL
> +       depends on xPL_DM_SERIAL
>         default y
>         help
>           In very space-constrained devices even the full UART driver is too
> 
> [1] https://source.denx.de/u-boot/contributors/kwiboo/u-boot/-/pipelines/30636

OK, thanks.

-- 
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]