* [PATCH v2 2/3] riscv: dts: spacemit: k3: Drop guest properties from M-level IMSIC
2026-11-02 19:50 [PATCH v2 0/3] Spacemit K3 enable Linux boot E Shattow
2026-11-02 19:50 ` [PATCH v2 1/3] riscv: dts: spacemit: k3: override reserved status of mimsic and maplic E Shattow
@ 2026-11-02 19:50 ` E Shattow
2026-11-02 19:50 ` [PATCH v2 3/3] configs: spacemit: k3: enable CONFIG_BOOTSTD_FULL E Shattow
2 siblings, 0 replies; 4+ messages in thread
From: E Shattow @ 2026-11-02 19:50 UTC (permalink / raw)
To: u-boot, Sumit Garg, Yixun Lan, Tim Ouyang, Leo Liang, Yao Zi,
Tom Rini, Guodong Xu
Cc: Junhui Liu
From: Junhui Liu <junhui.liu@pigmoral.tech>
The mimsic node describes the machine-level IMSIC, whose MMIO region is
0x10000 (64 KiB) for all 8 harts. However, the node also specifies
riscv,guest-index-bits = <6>, and per the AIA specification the
per-hart stride is 2^(guest-index-bits + 12) bytes when guest interrupt
files exist, i.e. 2^(6 + 12) = 256 KiB per hart and 2 MiB for all 8
harts. The described region cannot hold even a single hart's files, so
the node contradicts itself. OpenSBI enforces exactly this constraint in
imsic_data_check() and rejects the node with -EINVAL, preventing the
M-level IMSIC from initializing:
fdt_driver_init_by_offset: interrupt-controller@f1000000 (riscv,imsics) init failed: -3
init_coldboot: irqchip init failed (error -3)
Moreover, guest interrupt files exist to act as the supervisor-level
interrupt files of virtual harts; there is no machine-level counterpart.
riscv,num-guest-ids is equally meaningless for the machine-level IMSIC.
Drop both "riscv,guest-index-bits" and "riscv,num-guest-ids" properties
from the mimsic node so the node matches the actual hardware layout.
Fixes: 56f37e391a62 ("riscv: dts: spacemit: add initial support for K3 SoC")
Signed-off-by: Junhui Liu <junhui.liu@pigmoral.tech>
Reviewed-by: Yixun Lan <dlan@kernel.org>
Link: https://patch.msgid.link/20260729-k3-mimsic-fix-v1-1-368c0aec04b9@pigmoral.tech
Signed-off-by: Yixun Lan <dlan@kernel.org>
[ upstream commit: 01e2f07c44fc46180bdb10e70506f8acf44a53dd ]
(cherry picked from commit d44cd4bcf93bb5c99a4762ed5f11656b93f9e5cc)
---
dts/upstream/src/riscv/spacemit/k3.dtsi | 2 --
1 file changed, 2 deletions(-)
diff --git a/dts/upstream/src/riscv/spacemit/k3.dtsi b/dts/upstream/src/riscv/spacemit/k3.dtsi
index c3f2dce0969c..2d022e1364f1 100644
--- a/dts/upstream/src/riscv/spacemit/k3.dtsi
+++ b/dts/upstream/src/riscv/spacemit/k3.dtsi
@@ -1287,9 +1287,7 @@
<&cpu4_intc 11>, <&cpu5_intc 11>,
<&cpu6_intc 11>, <&cpu7_intc 11>;
msi-controller;
- riscv,guest-index-bits = <6>;
riscv,hart-index-bits = <4>;
- riscv,num-guest-ids = <511>;
riscv,num-ids = <511>;
status = "reserved";
};
--
2.53.0
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH v2 3/3] configs: spacemit: k3: enable CONFIG_BOOTSTD_FULL
2026-11-02 19:50 [PATCH v2 0/3] Spacemit K3 enable Linux boot E Shattow
2026-11-02 19:50 ` [PATCH v2 1/3] riscv: dts: spacemit: k3: override reserved status of mimsic and maplic E Shattow
2026-11-02 19:50 ` [PATCH v2 2/3] riscv: dts: spacemit: k3: Drop guest properties from M-level IMSIC E Shattow
@ 2026-11-02 19:50 ` E Shattow
2 siblings, 0 replies; 4+ messages in thread
From: E Shattow @ 2026-11-02 19:50 UTC (permalink / raw)
To: u-boot, Yixun Lan, Tom Rini; +Cc: E Shattow
Define minimal env variables for boot in spacemit-k3.h with fdtfile
as the CFG_EXTRA_ENV_SETTINGS sentinel, and enable CONFIG_BOOTSTD_FULL
Signed-off-by: E Shattow <e@freeshell.de>
---
configs/spacemit_k3_defconfig | 9 +--------
include/configs/spacemit-k3.h | 6 ++++++
2 files changed, 7 insertions(+), 8 deletions(-)
diff --git a/configs/spacemit_k3_defconfig b/configs/spacemit_k3_defconfig
index f49442951c8f..9bf582564d07 100644
--- a/configs/spacemit_k3_defconfig
+++ b/configs/spacemit_k3_defconfig
@@ -19,25 +19,18 @@ CONFIG_RISCV_SMODE=y
CONFIG_RISCV_ISA_ZICBOM=y
CONFIG_STACK_SIZE=0x100000
CONFIG_FIT=y
-CONFIG_SUPPORT_RAW_INITRD=y
+CONFIG_BOOTSTD_FULL=y
CONFIG_SYS_CBSIZE=256
CONFIG_SYS_PBSIZE=276
# CONFIG_BOARD_INIT is not set
-CONFIG_HUSH_PARSER=y
CONFIG_CMD_TLV_EEPROM=y
CONFIG_CMD_GPIO=y
CONFIG_CMD_I2C=y
CONFIG_CMD_MTD=y
-CONFIG_CMD_DHCP=y
CONFIG_CMD_DNS=y
-CONFIG_CMD_MII=y
-CONFIG_CMD_PING=y
CONFIG_CMD_WGET=y
-CONFIG_CMD_PXE=y
CONFIG_CMD_PMIC=y
CONFIG_CMD_REGULATOR=y
-CONFIG_CMD_FAT=y
-CONFIG_CMD_FS_GENERIC=y
CONFIG_CMD_MTDPARTS=y
CONFIG_MTDIDS_DEFAULT="nor0=d420c000.spi"
CONFIG_MTDPARTS_DEFAULT="d420c000.spi:128k(bootinfo),512k(fsbl),64k(env),1024k(esos),384k(opensbi),-(uboot)"
diff --git a/include/configs/spacemit-k3.h b/include/configs/spacemit-k3.h
index 9dd545e2a3b2..39d10059926e 100644
--- a/include/configs/spacemit-k3.h
+++ b/include/configs/spacemit-k3.h
@@ -6,6 +6,12 @@
#ifndef __SPACEMIT_K3_H
#define __SPACEMIT_K3_H
+#define CFG_EXTRA_ENV_SETTINGS \
+ "ramdisk_addr_r=0x130000000\0" \
+ "fdt_addr_r=0x138000000\0" \
+ "kernel_addr_r=0x140000000\0" \
+ "fdtfile=" CONFIG_DEFAULT_FDT_FILE "\0"
+
#define CFG_SYS_NS16550_IER 0x40
#define RISCV_SMODE_TIMER_FREQ 24000000
--
2.53.0
^ permalink raw reply related [flat|nested] 4+ messages in thread