* [PATCH 1/1] espresso7420: remove unused symbol CONFIG_DEFAULT_CONSOLE
@ 2020-09-05 10:02 Heinrich Schuchardt
2020-09-05 10:55 ` Fwd: " Heinrich Schuchardt
2020-09-06 19:00 ` Andre Heider
0 siblings, 2 replies; 7+ messages in thread
From: Heinrich Schuchardt @ 2020-09-05 10:02 UTC (permalink / raw)
To: u-boot
Symbol CONFIG_DEFAULT_CONSOLE in include/configs/espresso7420.h is not used
for espresso7420_defconfig.
Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
---
include/configs/espresso7420.h | 3 ---
1 file changed, 3 deletions(-)
diff --git a/include/configs/espresso7420.h b/include/configs/espresso7420.h
index 5aeb009f03..2495db93f8 100644
--- a/include/configs/espresso7420.h
+++ b/include/configs/espresso7420.h
@@ -18,9 +18,6 @@
#define CONFIG_SPL_STACK CONFIG_IRAM_END
#define CONFIG_SYS_INIT_SP_ADDR CONFIG_IRAM_END
-/* select serial console configuration */
-#define CONFIG_DEFAULT_CONSOLE "console=ttySAC1,115200n8\0"
-
/* DRAM Memory Banks */
#define SDRAM_BANK_SIZE (256UL << 20UL) /* 256 MB */
--
2.28.0
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Fwd: [PATCH 1/1] espresso7420: remove unused symbol CONFIG_DEFAULT_CONSOLE
2020-09-05 10:02 [PATCH 1/1] espresso7420: remove unused symbol CONFIG_DEFAULT_CONSOLE Heinrich Schuchardt
@ 2020-09-05 10:55 ` Heinrich Schuchardt
2020-09-07 0:06 ` Thomas Abraham
2020-09-06 19:00 ` Andre Heider
1 sibling, 1 reply; 7+ messages in thread
From: Heinrich Schuchardt @ 2020-09-05 10:55 UTC (permalink / raw)
To: u-boot
Hello Thomas,
I tried to send an U-Boot patch to Thomas Abraham
<thomas.ab@samsung.com>. But the email address thomas.ab at samsung.com
does not exist anymore.
I assume that you are the same person.
What shall happen with board/samsung/espresso7420/MAINTAINERS?
Best regards
Heinrich
-------- Forwarded Message --------
Subject: [PATCH 1/1] espresso7420: remove unused symbol
CONFIG_DEFAULT_CONSOLE
Date: Sat, 5 Sep 2020 12:02:10 +0200
From: Heinrich Schuchardt <xypron.glpk@gmx.de>
To: Thomas Abraham <thomas.ab@samsung.com>
CC: u-boot at lists.denx.de, Heinrich Schuchardt <xypron.glpk@gmx.de>
Symbol CONFIG_DEFAULT_CONSOLE in include/configs/espresso7420.h is not used
for espresso7420_defconfig.
Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
---
include/configs/espresso7420.h | 3 ---
1 file changed, 3 deletions(-)
diff --git a/include/configs/espresso7420.h b/include/configs/espresso7420.h
index 5aeb009f03..2495db93f8 100644
--- a/include/configs/espresso7420.h
+++ b/include/configs/espresso7420.h
@@ -18,9 +18,6 @@
#define CONFIG_SPL_STACK CONFIG_IRAM_END
#define CONFIG_SYS_INIT_SP_ADDR CONFIG_IRAM_END
-/* select serial console configuration */
-#define CONFIG_DEFAULT_CONSOLE "console=ttySAC1,115200n8\0"
-
/* DRAM Memory Banks */
#define SDRAM_BANK_SIZE (256UL << 20UL) /* 256 MB */
--
2.28.0
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Fwd: [PATCH 1/1] espresso7420: remove unused symbol CONFIG_DEFAULT_CONSOLE
2020-09-05 10:55 ` Fwd: " Heinrich Schuchardt
@ 2020-09-07 0:06 ` Thomas Abraham
0 siblings, 0 replies; 7+ messages in thread
From: Thomas Abraham @ 2020-09-07 0:06 UTC (permalink / raw)
To: u-boot
Sorry, Heinrich. Unfortunately, we are not the same person.
Best regards,
Tom Abraham
On 9/5/20 6:55 AM, Heinrich Schuchardt wrote:
> Hello Thomas,
>
> I tried to send an U-Boot patch to Thomas Abraham
> <thomas.ab@samsung.com>. But the email address thomas.ab at samsung.com
> does not exist anymore.
>
> I assume that you are the same person.
>
> What shall happen with board/samsung/espresso7420/MAINTAINERS?
>
> Best regards
>
> Heinrich
>
> -------- Forwarded Message --------
> Subject: [PATCH 1/1] espresso7420: remove unused symbol
> CONFIG_DEFAULT_CONSOLE
> Date: Sat, 5 Sep 2020 12:02:10 +0200
> From: Heinrich Schuchardt <xypron.glpk@gmx.de>
> To: Thomas Abraham <thomas.ab@samsung.com>
> CC: u-boot at lists.denx.de, Heinrich Schuchardt <xypron.glpk@gmx.de>
>
> Symbol CONFIG_DEFAULT_CONSOLE in include/configs/espresso7420.h is not used
> for espresso7420_defconfig.
>
> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
> ---
> include/configs/espresso7420.h | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/include/configs/espresso7420.h b/include/configs/espresso7420.h
> index 5aeb009f03..2495db93f8 100644
> --- a/include/configs/espresso7420.h
> +++ b/include/configs/espresso7420.h
> @@ -18,9 +18,6 @@
> #define CONFIG_SPL_STACK CONFIG_IRAM_END
> #define CONFIG_SYS_INIT_SP_ADDR CONFIG_IRAM_END
>
> -/* select serial console configuration */
> -#define CONFIG_DEFAULT_CONSOLE "console=ttySAC1,115200n8\0"
> -
> /* DRAM Memory Banks */
> #define SDRAM_BANK_SIZE (256UL << 20UL) /* 256 MB */
>
> --
> 2.28.0
>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: pEpkey.asc
Type: application/pgp-keys
Size: 1753 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200906/8cc0d435/attachment.key>
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH 1/1] espresso7420: remove unused symbol CONFIG_DEFAULT_CONSOLE
2020-09-05 10:02 [PATCH 1/1] espresso7420: remove unused symbol CONFIG_DEFAULT_CONSOLE Heinrich Schuchardt
2020-09-05 10:55 ` Fwd: " Heinrich Schuchardt
@ 2020-09-06 19:00 ` Andre Heider
2020-09-06 19:33 ` Heinrich Schuchardt
1 sibling, 1 reply; 7+ messages in thread
From: Andre Heider @ 2020-09-06 19:00 UTC (permalink / raw)
To: u-boot
On 05/09/2020 12:02, Heinrich Schuchardt wrote:
> Symbol CONFIG_DEFAULT_CONSOLE in include/configs/espresso7420.h is not used
> for espresso7420_defconfig.
>
> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
I noticed that too while grepping for CONFIG_DEFAULT_CONSOLE. Afaict
there're quite some boards with it set but unused:
include/configs/arndale.h
include/configs/peach-pi.h
include/configs/peach-pit.h
include/configs/smdk5250.h
include/configs/smdkv310.h
include/configs/snow.h
include/configs/spring.h
This one even defines it twice (looks like a rebase gone wrong), still
unused:
include/configs/smdk5420.h
#define CONFIG_DEFAULT_CONSOLE "console=ttySAC1,115200n8\0"
#define CONFIG_DEFAULT_CONSOLE "console=ttySAC1,115200n8\0"
Last but not least:
include/configs/origen.h
#define CONFIG_DEFAULT_CONSOLE "console=ttySAC1,115200n8\0"
"console=ttySAC2,115200n8\0"
Btw, *all* hits for CONFIG_DEFAULT_CONSOLE are ttySAC*.
Regards,
Andre
> ---
> include/configs/espresso7420.h | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/include/configs/espresso7420.h b/include/configs/espresso7420.h
> index 5aeb009f03..2495db93f8 100644
> --- a/include/configs/espresso7420.h
> +++ b/include/configs/espresso7420.h
> @@ -18,9 +18,6 @@
> #define CONFIG_SPL_STACK CONFIG_IRAM_END
> #define CONFIG_SYS_INIT_SP_ADDR CONFIG_IRAM_END
>
> -/* select serial console configuration */
> -#define CONFIG_DEFAULT_CONSOLE "console=ttySAC1,115200n8\0"
> -
> /* DRAM Memory Banks */
> #define SDRAM_BANK_SIZE (256UL << 20UL) /* 256 MB */
>
> --
> 2.28.0
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH 1/1] espresso7420: remove unused symbol CONFIG_DEFAULT_CONSOLE
2020-09-06 19:00 ` Andre Heider
@ 2020-09-06 19:33 ` Heinrich Schuchardt
2020-09-07 5:10 ` Minkyu Kang
0 siblings, 1 reply; 7+ messages in thread
From: Heinrich Schuchardt @ 2020-09-06 19:33 UTC (permalink / raw)
To: u-boot
On 9/6/20 9:00 PM, Andre Heider wrote:
> On 05/09/2020 12:02, Heinrich Schuchardt wrote:
>> Symbol CONFIG_DEFAULT_CONSOLE in include/configs/espresso7420.h is not
>> used
>> for espresso7420_defconfig.
>>
>> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
>
> I noticed that too while grepping for CONFIG_DEFAULT_CONSOLE. Afaict
> there're quite some boards with it set but unused:
Thanks for reviewing. As the boards have different maintainers we should
treat them in separate patches.
Best regards
Heinrich
> include/configs/arndale.h
> include/configs/peach-pi.h
> include/configs/peach-pit.h
> include/configs/smdk5250.h
> include/configs/smdkv310.h
> include/configs/snow.h
> include/configs/spring.h
>
> This one even defines it twice (looks like a rebase gone wrong), still
> unused:
> include/configs/smdk5420.h
> #define CONFIG_DEFAULT_CONSOLE??? "console=ttySAC1,115200n8\0"
> #define CONFIG_DEFAULT_CONSOLE??????? "console=ttySAC1,115200n8\0"
>
> Last but not least:
> include/configs/origen.h
> #define CONFIG_DEFAULT_CONSOLE??????? "console=ttySAC1,115200n8\0"
> "console=ttySAC2,115200n8\0"
>
> Btw, *all* hits for CONFIG_DEFAULT_CONSOLE are ttySAC*.
>
> Regards,
> Andre
>
>> ---
>> ? include/configs/espresso7420.h | 3 ---
>> ? 1 file changed, 3 deletions(-)
>>
>> diff --git a/include/configs/espresso7420.h
>> b/include/configs/espresso7420.h
>> index 5aeb009f03..2495db93f8 100644
>> --- a/include/configs/espresso7420.h
>> +++ b/include/configs/espresso7420.h
>> @@ -18,9 +18,6 @@
>> ? #define CONFIG_SPL_STACK??????? CONFIG_IRAM_END
>> ? #define CONFIG_SYS_INIT_SP_ADDR??????? CONFIG_IRAM_END
>>
>> -/* select serial console configuration */
>> -#define CONFIG_DEFAULT_CONSOLE??? "console=ttySAC1,115200n8\0"
>> -
>> ? /* DRAM Memory Banks */
>> ? #define SDRAM_BANK_SIZE??????? (256UL << 20UL)??? /* 256 MB */
>>
>> --
>> 2.28.0
>>
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH 1/1] espresso7420: remove unused symbol CONFIG_DEFAULT_CONSOLE
2020-09-06 19:33 ` Heinrich Schuchardt
@ 2020-09-07 5:10 ` Minkyu Kang
2020-10-15 5:36 ` Minkyu Kang
0 siblings, 1 reply; 7+ messages in thread
From: Minkyu Kang @ 2020-09-07 5:10 UTC (permalink / raw)
To: u-boot
Dear Heinrich Schuchardt,
On 07/09/2020 04:33, Heinrich Schuchardt wrote:
> On 9/6/20 9:00 PM, Andre Heider wrote:
>> On 05/09/2020 12:02, Heinrich Schuchardt wrote:
>>> Symbol CONFIG_DEFAULT_CONSOLE in include/configs/espresso7420.h is not
>>> used
>>> for espresso7420_defconfig.
>>>
>>> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
>>
>> I noticed that too while grepping for CONFIG_DEFAULT_CONSOLE. Afaict
>> there're quite some boards with it set but unused:
>
> Thanks for reviewing. As the boards have different maintainers we should
> treat them in separate patches.
>
Because those are all Samsung boards, I can approve them.
If you want please send changes to patch-set or single patch with adding maintainers as a CC.
thomas.ab seems to exited from company.
I will find new maintainer soon.
Thanks,
Minkyu Kang.
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH 1/1] espresso7420: remove unused symbol CONFIG_DEFAULT_CONSOLE
2020-09-07 5:10 ` Minkyu Kang
@ 2020-10-15 5:36 ` Minkyu Kang
0 siblings, 0 replies; 7+ messages in thread
From: Minkyu Kang @ 2020-10-15 5:36 UTC (permalink / raw)
To: u-boot
Dear Heinrich Schuchardt,
On Mon, 7 Sep 2020 at 14:13, Minkyu Kang <mk7.kang@samsung.com> wrote:
> Dear Heinrich Schuchardt,
>
> On 07/09/2020 04:33, Heinrich Schuchardt wrote:
> > On 9/6/20 9:00 PM, Andre Heider wrote:
> >> On 05/09/2020 12:02, Heinrich Schuchardt wrote:
> >>> Symbol CONFIG_DEFAULT_CONSOLE in include/configs/espresso7420.h is not
> >>> used
> >>> for espresso7420_defconfig.
> >>>
> >>> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
> >>
> >> I noticed that too while grepping for CONFIG_DEFAULT_CONSOLE. Afaict
> >> there're quite some boards with it set but unused:
> >
> > Thanks for reviewing. As the boards have different maintainers we should
> > treat them in separate patches.
> >
>
> Because those are all Samsung boards, I can approve them.
> If you want please send changes to patch-set or single patch with adding
> maintainers as a CC.
>
> thomas.ab seems to exited from company.
> I will find new maintainer soon.
>
> Thanks,
> Minkyu Kang.
>
>
Your patch was replaced by Heider's patch.
I added your signed-off at that patch.
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2020-10-15 5:36 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-09-05 10:02 [PATCH 1/1] espresso7420: remove unused symbol CONFIG_DEFAULT_CONSOLE Heinrich Schuchardt
2020-09-05 10:55 ` Fwd: " Heinrich Schuchardt
2020-09-07 0:06 ` Thomas Abraham
2020-09-06 19:00 ` Andre Heider
2020-09-06 19:33 ` Heinrich Schuchardt
2020-09-07 5:10 ` Minkyu Kang
2020-10-15 5:36 ` Minkyu Kang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox