[U-Boot-Users] {Patch]: A small bug in PCI command

[U-Boot-Users] {Patch]: A small bug in PCI command

[Vladimir Gurevich]

Hello,

I've just noticed that "pci" command (or pci header)
fails to show the device class properly.

The problem is that the function pci_classes_str
uses an array of pointers to strings to connvert the 
class and these pointers don't get relocated after
u-boot is moved into RAM. Thus they still point
to some addresses in FLASH, which is not correct.

Is it only my problem or other people have similar
experience?

We can either do manual relocation (same way how
cmd_tbl is relocated in board_init_r()) or
replace this table with a (ugly?) switch statement.
That's the patch attached.

Thanks,
Vladimir
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: cmd_pci.diff
Url: http://lists.denx.de/pipermail/u-boot/attachments/20030311/6e6dd733/attachment.txt 

[U-Boot-Users] [Patch]: A small bug in PCI command

[Vladimir Gurevich]

This is a cleaner patch (I didn't notice
include/pci_ids.h initially).

Vladimir

Vladimir Gurevich wrote:
> I've just noticed that "pci" command (or pci header)
> fails to show the device class properly.
> 
> We can either do manual relocation (same way how
> cmd_tbl is relocated in board_init_r()) or
> replace this table with a (ugly?) switch statement.
> That's the patch attached.
> 

-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: cmd_pci.diff
Url: http://lists.denx.de/pipermail/u-boot/attachments/20030312/fe7d5bb6/attachment.txt 

[U-Boot-Users] [Patch]: A small bug in PCI command

[Wolfgang Denk]

In message <3E6F8D29.5010205@paulidav.org> you wrote:
>
> This is a cleaner patch (I didn't notice
> include/pci_ids.h initially).

Thanks. Added. Will show up on CVS in a couple of hours.

Best regards,

Wolfgang Denk

-- 
Software Engineering:  Embedded and Realtime Systems,  Embedded Linux
Phone: (+49)-8142-4596-87  Fax: (+49)-8142-4596-88  Email: wd at denx.de
If God had a beard, he'd be a UNIX programmer.