From: Scott Wood <scottwood@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] Noisily disable the legacy NAND subsystem.
Date: Wed, 01 Apr 2009 16:32:49 -0500 [thread overview]
Message-ID: <49D3DD81.4050508@freescale.com> (raw)
In-Reply-To: <78B9486C-B641-49A6-A1D9-9BBB3B7D04AE@kernel.crashing.org>
Becky Bruce wrote:
>
> On Apr 1, 2009, at 4:15 PM, Scott Wood wrote:
>
>> Legacy NAND is marked for feature removal after April 2009 (i.e. this
>> upcoming release). There are still several boards that reference it
>> (though many do so only for disk-on-chip support which has been silently
>> disabled for a while now). These boards will now fail to build with
>
> Drum roll....? You're missing the rest of your sentence, or you have
> too much sentence, or something.
D'oh. The next line started with "#error", so git treated it as a comment.
Commit amended to say "These boards will now fail to build with #error,
though the code is still there if the user removes #error."
>> +#error This code is broken and will be removed outright in the next
>> release.
>> +#error If you need diskonchip support, please update
>> +#error drivers/mtd/nand/diskonchip.c to work with u-boot.
>
> "to work with u-boot"? As opposed to what, exactly?
Linux, where the code was taken from as part of the NAND subsystem
importation.
> How about "please update blah to be functional"
"be functional" == "work". I was just clarifying the nature of the
fixing that needed to be done.
-Scott
next prev parent reply other threads:[~2009-04-01 21:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-01 21:15 [U-Boot] [PATCH] Noisily disable the legacy NAND subsystem Scott Wood
2009-04-01 21:27 ` Becky Bruce
2009-04-01 21:32 ` Scott Wood [this message]
2009-04-01 21:42 ` Becky Bruce
2009-04-01 21:38 ` Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49D3DD81.4050508@freescale.com \
--to=scottwood@freescale.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox