[U-Boot] [PATCH] Noisily disable the legacy NAND subsystem.

[U-Boot] [PATCH] Noisily disable the legacy NAND subsystem.

[Scott Wood]

Legacy NAND is marked for feature removal after April 2009 (i.e. this
upcoming release).  There are still several boards that reference it
(though many do so only for disk-on-chip support which has been silently
disabled for a while now).  These boards will now fail to build with

The plan is to remove the code outright in the next release, along with
any board code that refers to it (such as board/esd/common/auto_update.c).

Signed-off-by: Scott Wood <scottwood@freescale.com>
---
Applied to u-boot-nand-flash.

 common/cmd_doc.c                      |    4 ++++
 drivers/mtd/nand_legacy/nand_legacy.c |    3 +++
 2 files changed, 7 insertions(+), 0 deletions(-)

diff --git a/common/cmd_doc.c b/common/cmd_doc.c
index e2d4a42..cd221fc 100644
--- a/common/cmd_doc.c
+++ b/common/cmd_doc.c
@@ -14,6 +14,10 @@
 #include <linux/mtd/nftl.h>
 #include <linux/mtd/doc2000.h>
 
+#error This code is broken and will be removed outright in the next release.
+#error If you need diskonchip support, please update
+#error drivers/mtd/nand/diskonchip.c to work with u-boot.
+
 /*
  * ! BROKEN !
  *
diff --git a/drivers/mtd/nand_legacy/nand_legacy.c b/drivers/mtd/nand_legacy/nand_legacy.c
index 441780a..d9ae9c7 100644
--- a/drivers/mtd/nand_legacy/nand_legacy.c
+++ b/drivers/mtd/nand_legacy/nand_legacy.c
@@ -18,6 +18,9 @@
 #include <linux/mtd/nand_ids.h>
 #include <jffs2/jffs2.h>
 
+#error Legacy NAND is deprecated.  Please convert to the current NAND interface.
+#error This code will be removed outright in the next release.
+
 #ifdef CONFIG_OMAP1510
 void archflashwp(void *archdata, int wp);
 #endif
-- 
1.5.6.rc1.6.gc53ad

[U-Boot] [PATCH] Noisily disable the legacy NAND subsystem.

[Becky Bruce]

On Apr 1, 2009, at 4:15 PM, Scott Wood wrote:

> Legacy NAND is marked for feature removal after April 2009 (i.e. this
> upcoming release).  There are still several boards that reference it
> (though many do so only for disk-on-chip support which has been  
> silently
> disabled for a while now).  These boards will now fail to build with

Drum roll....?  You're missing the rest of your sentence, or you have  
too much sentence, or something.


>
>
> The plan is to remove the code outright in the next release, along  
> with
> any board code that refers to it (such as board/esd/common/ 
> auto_update.c).
>
> Signed-off-by: Scott Wood <scottwood@freescale.com>
> ---
> Applied to u-boot-nand-flash.
>
> common/cmd_doc.c                      |    4 ++++
> drivers/mtd/nand_legacy/nand_legacy.c |    3 +++
> 2 files changed, 7 insertions(+), 0 deletions(-)
>
> diff --git a/common/cmd_doc.c b/common/cmd_doc.c
> index e2d4a42..cd221fc 100644
> --- a/common/cmd_doc.c
> +++ b/common/cmd_doc.c
> @@ -14,6 +14,10 @@
> #include <linux/mtd/nftl.h>
> #include <linux/mtd/doc2000.h>
>
> +#error This code is broken and will be removed outright in the next  
> release.
> +#error If you need diskonchip support, please update
> +#error drivers/mtd/nand/diskonchip.c to work with u-boot.

"to work with u-boot"?  As opposed to what, exactly?  How about  
"please update blah to be functional"

-B


>
> +
> /*
>  * ! BROKEN !
>  *
> diff --git a/drivers/mtd/nand_legacy/nand_legacy.c b/drivers/mtd/ 
> nand_legacy/nand_legacy.c
> index 441780a..d9ae9c7 100644
> --- a/drivers/mtd/nand_legacy/nand_legacy.c
> +++ b/drivers/mtd/nand_legacy/nand_legacy.c
> @@ -18,6 +18,9 @@
> #include <linux/mtd/nand_ids.h>
> #include <jffs2/jffs2.h>
>
> +#error Legacy NAND is deprecated.  Please convert to the current  
> NAND interface.
> +#error This code will be removed outright in the next release.
> +
> #ifdef CONFIG_OMAP1510
> void archflashwp(void *archdata, int wp);
> #endif
> -- 
> 1.5.6.rc1.6.gc53ad
> _______________________________________________
> U-Boot mailing list
> U-Boot at lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot

[U-Boot] [PATCH] Noisily disable the legacy NAND subsystem.

[Scott Wood]

Becky Bruce wrote:
> 
> On Apr 1, 2009, at 4:15 PM, Scott Wood wrote:
> 
>> Legacy NAND is marked for feature removal after April 2009 (i.e. this
>> upcoming release).  There are still several boards that reference it
>> (though many do so only for disk-on-chip support which has been silently
>> disabled for a while now).  These boards will now fail to build with
> 
> Drum roll....?  You're missing the rest of your sentence, or you have 
> too much sentence, or something.

D'oh.  The next line started with "#error", so git treated it as a comment.

Commit amended to say "These boards will now fail to build with #error, 
though the code is still there if the user removes #error."

>> +#error This code is broken and will be removed outright in the next 
>> release.
>> +#error If you need diskonchip support, please update
>> +#error drivers/mtd/nand/diskonchip.c to work with u-boot.
> 
> "to work with u-boot"?  As opposed to what, exactly?

Linux, where the code was taken from as part of the NAND subsystem 
importation.

> How about "please update blah to be functional"

"be functional" == "work".  I was just clarifying the nature of the 
fixing that needed to be done.

-Scott

[U-Boot] [PATCH] Noisily disable the legacy NAND subsystem.

[Wolfgang Denk]

Dear Scott Wood,

In message <20090401211543.GA10944@ld0162-tx32.am.freescale.net> you wrote:
> Legacy NAND is marked for feature removal after April 2009 (i.e. this
> upcoming release).  There are still several boards that reference it
> (though many do so only for disk-on-chip support which has been silently
> disabled for a while now).  These boards will now fail to build with
> 

... fail to build with ... with what?


Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
A wise person makes his  own  decisions,  a  weak  one  obeys  public
opinion.                                           -- Chinese proverb

[U-Boot] [PATCH] Noisily disable the legacy NAND subsystem.

[Becky Bruce]

On Apr 1, 2009, at 4:32 PM, Scott Wood wrote:

> Becky Bruce wrote:
>> On Apr 1, 2009, at 4:15 PM, Scott Wood wrote:
>>> Legacy NAND is marked for feature removal after April 2009 (i.e.  
>>> this
>>> upcoming release).  There are still several boards that reference it
>>> (though many do so only for disk-on-chip support which has been  
>>> silently
>>> disabled for a while now).  These boards will now fail to build with
>> Drum roll....?  You're missing the rest of your sentence, or you  
>> have too much sentence, or something.
>
> D'oh.  The next line started with "#error", so git treated it as a  
> comment.
>
> Commit amended to say "These boards will now fail to build with  
> #error, though the code is still there if the user removes #error."

Thanks ;)

>
>
>>> +#error This code is broken and will be removed outright in the  
>>> next release.
>>> +#error If you need diskonchip support, please update
>>> +#error drivers/mtd/nand/diskonchip.c to work with u-boot.
>> "to work with u-boot"?  As opposed to what, exactly?
>
> Linux, where the code was taken from as part of the NAND subsystem  
> importation.
>
>> How about "please update blah to be functional"
>
> "be functional" == "work".  I was just clarifying the nature of the  
> fixing that needed to be done.

it wasn't the "work" I had a problem with, it was the "with u-boot"  
part, and getting rid of the "with u-boot" made "work" sound silly :)

But if you're actually talking about u-boot vs linux, the comment is  
fine as is.

Thanks,
B