* [U-Boot] [PATCH] s3c64xx: Add ifdef at the S3C64XX only codes
@ 2010-02-08 10:55 Joonyoung Shim
2010-02-08 11:23 ` Joonyoung Shim
0 siblings, 1 reply; 3+ messages in thread
From: Joonyoung Shim @ 2010-02-08 10:55 UTC (permalink / raw)
To: u-boot
The pheripheral port address(0x70000000 - 0x7fffffff) exists at only
S3C64XX cpu. The pheripheral port setup codes should be executed by only
S3C64XX cpu.
Signed-off-by: Joonyoung Shim <jy0922.shim@samsung.com>
---
cpu/arm1176/start.S | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/cpu/arm1176/start.S b/cpu/arm1176/start.S
index 68a356d..5d9fba9 100644
--- a/cpu/arm1176/start.S
+++ b/cpu/arm1176/start.S
@@ -190,10 +190,12 @@ mmu_disable:
#endif
mmu_disable_phys:
+#ifdef CONFIG_S3C64XX
/* Peri port setup */
ldr r0, =0x70000000
orr r0, r0, #0x13
mcr p15,0,r0,c15,c2,4 @ 256M (0x70000000 - 0x7fffffff)
+#endif
/*
* Go setup Memory and board specific bits prior to relocation.
--
1.6.3.3
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [U-Boot] [PATCH] s3c64xx: Add ifdef at the S3C64XX only codes
2010-02-08 10:55 [U-Boot] [PATCH] s3c64xx: Add ifdef at the S3C64XX only codes Joonyoung Shim
@ 2010-02-08 11:23 ` Joonyoung Shim
2010-02-08 12:51 ` Minkyu Kang
0 siblings, 1 reply; 3+ messages in thread
From: Joonyoung Shim @ 2010-02-08 11:23 UTC (permalink / raw)
To: u-boot
On 2/8/2010 7:55 PM, Joonyoung Shim wrote:
> The pheripheral port address(0x70000000 - 0x7fffffff) exists at only
> S3C64XX cpu. The pheripheral port setup codes should be executed by only
> S3C64XX cpu.
>
> Signed-off-by: Joonyoung Shim <jy0922.shim@samsung.com>
> ---
> cpu/arm1176/start.S | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
Sorry, i missed something. Please use the below patch.
^ permalink raw reply [flat|nested] 3+ messages in thread
* [U-Boot] [PATCH] s3c64xx: Add ifdef at the S3C64XX only codes
2010-02-08 11:23 ` Joonyoung Shim
@ 2010-02-08 12:51 ` Minkyu Kang
0 siblings, 0 replies; 3+ messages in thread
From: Minkyu Kang @ 2010-02-08 12:51 UTC (permalink / raw)
To: u-boot
Dear Joonyoung Shim,
On 8 February 2010 20:23, Joonyoung Shim <jy0922.shim@samsung.com> wrote:
> On 2/8/2010 7:55 PM, Joonyoung Shim wrote:
>> The pheripheral port address(0x70000000 - 0x7fffffff) exists at only
>> S3C64XX cpu. The pheripheral port setup codes should be executed by only
>> S3C64XX cpu.
>>
>> Signed-off-by: Joonyoung Shim <jy0922.shim@samsung.com>
>> ---
>> ?cpu/arm1176/start.S | ? ?2 ++
>> ?1 files changed, 2 insertions(+), 0 deletions(-)
>>
>
> Sorry, i missed something. Please use the below patch.
>
>
> From 89017aa05e1cbb94aeddb3625584eca474d57684 Mon Sep 17 00:00:00 2001
> From: Joonyoung Shim <jy0922.shim@samsung.com>
> Date: Mon, 8 Feb 2010 20:25:23 +0900
> Subject: [PATCH] s3c64xx: Add ifdef at the S3C64XX only codes
>
> The s3c6400.h file is only for S3C64XX cpu and the pheripheral port
> address(0x70000000 - 0x7fffffff) exists at only S3C64XX cpu, so they
> should be included by only S3C64XX cpu.
>
> Signed-off-by: Joonyoung Shim <jy0922.shim@samsung.com>
> ---
> ?cpu/arm1176/cpu.c ? | ? ?2 ++
> ?cpu/arm1176/start.S | ? ?4 ++++
> ?2 files changed, 6 insertions(+), 0 deletions(-)
>
Please add a version to the subject (like "[PATCH v2]").
So please resend the patch version 2.
Thanks
Minkyu Kang
--
from. prom.
www.promsoft.net
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-02-08 12:51 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-02-08 10:55 [U-Boot] [PATCH] s3c64xx: Add ifdef at the S3C64XX only codes Joonyoung Shim
2010-02-08 11:23 ` Joonyoung Shim
2010-02-08 12:51 ` Minkyu Kang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox