From: Li Yang <leoli@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] 85xx: Add is_serdes_configured() support for P2020SERDES
Date: Fri, 21 May 2010 19:43:11 +0800 [thread overview]
Message-ID: <4BF671CF.8020808@freescale.com> (raw)
In-Reply-To: <1274433478-31849-1-git-send-email-galak@kernel.crashing.org>
On 5/21/2010 5:17 PM, Kumar Gala wrote:
>
>Add the ability to determine if a given IP block connected on SERDES is
>configured. This is useful for things like PCIe and SRIO since they are
>only ever connected on SERDES.
>
>Signed-off-by: Kumar Gala <galak at kernel.crashing.org
<mailto:galak@kernel.crashing.org>>
I'm not sure why this code has to be re-done rather than using the patch
I submitted?
{snip}
>+int is_serdes_configured(enum srds_prtcl device) {
>+ int i;
>+ ccsr_gur_t *gur = (void *)(CONFIG_SYS_MPC85xx_GUTS_ADDR);
>+ u32 pordevsr = in_be32(&gur->pordevsr);
Wouldn't it be better to only read it once on fsl_serdes_init(), after
all it will not be changed after reset.
>+ u32 srds1_cfg = (pordevsr & MPC85xx_PORDEVSR_IO_SEL) >>
>+ MPC85xx_PORDEVSR_IO_SEL_SHIFT;
>+
>+ debug("%s: dev = %d\n", __FUNCTION__, device);
>+ debug("PORDEVSR[IO_SEL] = %x\n", srds1_cfg);
>+
>+ if (srds1_cfg > ARRAY_SIZE(serdes1_cfg_tbl)) {
>+ printf("Invalid PORDEVSR[IO_SEL] = %d\n", srds1_cfg);
>+ return 0;
>+ }
>+
>+ for (i = 0; i < SRDS1_MAX_LANES; i++) {
>+ if (serdes1_cfg_tbl[srds1_cfg][i] == device)
>+ return 1;
Given the fact that the is_serdes_configured() will be called multiple
times, it will be better to process the table in fsl_serdes_init() and
save time for every is_serdes_configured() judgment like what I did.
- Leo
>+ }
>+
>+ return 0;
>+}
>+
>+void fsl_serdes_init(void)
>+{
>+}
>--
>1.6.0.6
>
>_______________________________________________
>U-Boot mailing list
>U-Boot at lists.denx.de <mailto:U-Boot@lists.denx.de>
>http://lists.denx.de/mailman/listinfo/u-boot
next prev parent reply other threads:[~2010-05-21 11:43 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-21 9:17 [U-Boot] [PATCH] 85xx: Add is_serdes_configured() support for P2020 SERDES Kumar Gala
2010-05-21 9:17 ` [U-Boot] [PATCH] 85xx/p2020ds: Use is_serdes_configured() to determine of PCIe enabled Kumar Gala
2010-05-26 20:46 ` Timur Tabi
2010-05-26 21:37 ` Timur Tabi
2010-05-27 7:08 ` Wolfgang Denk
2010-05-27 8:42 ` Kumar Gala
2010-05-27 11:20 ` Wolfgang Denk
2010-05-27 12:45 ` Kumar Gala
2010-05-27 13:20 ` Wolfgang Denk
2010-05-27 15:47 ` Kumar Gala
2010-05-27 19:38 ` Scott Wood
2010-05-27 21:27 ` Kumar Gala
2010-05-27 21:28 ` Timur Tabi
2010-05-27 21:38 ` Timur Tabi
2010-05-28 12:53 ` Kumar Gala
2010-05-28 14:33 ` Timur Tabi
2010-05-21 11:43 ` Li Yang [this message]
[not found] ` <6D3E1D972AA8904199D0D412F4A64CBD024CF99A@zch01exm26.fsl.freescale.net>
2010-05-21 12:51 ` [U-Boot] [PATCH] 85xx: Add is_serdes_configured() support for P2020SERDES Kumar Gala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BF671CF.8020808@freescale.com \
--to=leoli@freescale.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox