public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] 85xx/p2020ds: Use is_serdes_configured() to determine of PCIe enabled
Date: Thu, 27 May 2010 09:08:46 +0200	[thread overview]
Message-ID: <20100527070846.85882EAC238@gemini.denx.de> (raw)
In-Reply-To: <1274433478-31849-2-git-send-email-galak@kernel.crashing.org>

Dear Kumar Gala,

In message <1274433478-31849-2-git-send-email-galak@kernel.crashing.org> you wrote:
> The new is_serdes_configured covers a broader range of devices than the
> PCI specific code.  Use it instead as we convert away from the
> is_fsl_pci_cfg() code.
> 
> Additionally move to setting LAWs for PCI based on if its configured.
> Also updated PCI FDT fixup code to remove PCI controllers from dtb if
> they are not configured.
...
>  #ifdef CONFIG_PCIE3
>  	ft_fsl_pci_setup(blob, "pci0", &pcie3_hose);
> +#else
> +	ft_fsl_pci_setup(blob, "pci0", NULL);
>  #endif
>  #ifdef CONFIG_PCIE2
>  	ft_fsl_pci_setup(blob, "pci1", &pcie2_hose);
> +#else
> +	ft_fsl_pci_setup(blob, "pci1", NULL);
>  #endif
>  #ifdef CONFIG_PCIE1
>  	ft_fsl_pci_setup(blob, "pci2", &pcie1_hose);
> +#else
> +	ft_fsl_pci_setup(blob, "pci2", NULL);
>  #endif

As Timur already pointed out: can we please clean up this mess of
3 = 0 = 3, 2 = 1 = 2, 1 = 2 = 1?

This is extremely confusing.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
He had been eight years upon a project for extracting sunbeams out of
cucumbers, which were to be put in vials hermetically sealed, and let
out to warm the air in raw inclement summers.        - Jonathan Swift
              _Gulliver's Travels_ ``A Voyage to Laputa, etc.'' ch. 5

  parent reply	other threads:[~2010-05-27  7:08 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-05-21  9:17 [U-Boot] [PATCH] 85xx: Add is_serdes_configured() support for P2020 SERDES Kumar Gala
2010-05-21  9:17 ` [U-Boot] [PATCH] 85xx/p2020ds: Use is_serdes_configured() to determine of PCIe enabled Kumar Gala
2010-05-26 20:46   ` Timur Tabi
2010-05-26 21:37   ` Timur Tabi
2010-05-27  7:08   ` Wolfgang Denk [this message]
2010-05-27  8:42     ` Kumar Gala
2010-05-27 11:20       ` Wolfgang Denk
2010-05-27 12:45         ` Kumar Gala
2010-05-27 13:20           ` Wolfgang Denk
2010-05-27 15:47             ` Kumar Gala
2010-05-27 19:38           ` Scott Wood
2010-05-27 21:27             ` Kumar Gala
2010-05-27 21:28               ` Timur Tabi
2010-05-27 21:38   ` Timur Tabi
2010-05-28 12:53     ` Kumar Gala
2010-05-28 14:33       ` Timur Tabi
2010-05-21 11:43 ` [U-Boot] [PATCH] 85xx: Add is_serdes_configured() support for P2020SERDES Li Yang
     [not found] ` <6D3E1D972AA8904199D0D412F4A64CBD024CF99A@zch01exm26.fsl.freescale.net>
2010-05-21 12:51   ` Kumar Gala

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100527070846.85882EAC238@gemini.denx.de \
    --to=wd@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox